Re: [Tomcat 7] OPENEJB-1261 present on 7.0.2

2010-10-13 Thread Matthias Wessendorf
I see similar issues, when rebooting tomcat.
Will check details and post results here

On Wed, Oct 13, 2010 at 1:10 AM, Jonathan Gallimore
jonathan.gallim...@gmail.com wrote:
 I've added the patch to my working copy here, and the installation seemed to
 complete ok, but I ran into a couple of problems with this using Tomcat
 7.0.2 on my Mac. The EJB lookup didn't work for me, and then once I had
 installed the Java agent, Tomcat refused to start with this exception:

 java.lang.reflect.InvocationTargetException
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260)
 at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414)
 Caused by: java.lang.NoClassDefFoundError: org/apache/catalina/ServerFactory
 at
 org.apache.openejb.tomcat.loader.OpenEJBListener.findOpenEjbWar(OpenEJBListener.java:77)
 at
 org.apache.openejb.tomcat.loader.OpenEJBListener.lifecycleEvent(OpenEJBListener.java:59)
 at
 org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)
 at
 org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:89)
 at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:313)
 at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:293)
 at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:97)
 at org.apache.catalina.startup.Catalina.load(Catalina.java:537)
 at org.apache.catalina.startup.Catalina.load(Catalina.java:560)
 ... 6 more
 Caused by: java.lang.ClassNotFoundException:
 org.apache.catalina.ServerFactory
 at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
 at java.security.AccessController.doPrivileged(Native Method)
 at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:248)
 ... 15 more

 At first glance it looks to me like the Tomcat 7 API had changed, and we
 probably just need to adapt some of our code to cope with it. I'll carry on
 having a look at this tomorrow, but please let me know if I've missed
 something obvious.

 Cheers

 Jon

 On Tue, Oct 12, 2010 at 11:48 PM, Jonathan Gallimore 
 jonathan.gallim...@gmail.com wrote:

 Hi Matthias

 Thanks for the patch, I'll take a look and get it committed.

 Jon

 On Tue, Oct 12, 2010 at 5:27 PM, Matthias Wessendorf 
 mat...@apache.orgwrote:

 On Mon, Oct 11, 2010 at 11:54 PM, David Blevins david.blev...@visi.com
 wrote:
 
  On Oct 11, 2010, at 12:11 PM, Matthias Wessendorf wrote:
 
  hello,
 
  what it is Tomcat 7 version that is supposed to work with OpenEJB 3.2
 SNAPSHOT ?
 
  The WAR from [1] does not work on 7.0.2.
 
  I reopened [2].
 
  I haven't tried Tomcat 7 yet myself, but that's the version we'll need
 to certify Web Profile.  Someone recently posted an error that looked like
 there was no longer a lib directory for us to put jars in.


 na, that's wrong . see OPENEJB-1367

 
  If you're interested in digging in, I have a standing offer to get on
 skype and fork over any info I have to anyone who'd like to help.
 
 
  -David
 
 
  [1]
 https://repository.apache.org/content/repositories/snapshots/org/apache/openejb/openejb-webapp/3.2-SNAPSHOT/
  [2] https://issues.apache.org/jira/browse/OPENEJB-1261
 
  --
  Matthias Wessendorf
 
  blog: http://matthiaswessendorf.wordpress.com/
  sessions: http://www.slideshare.net/mwessendorf
  twitter: http://twitter.com/mwessendorf
 
 
 



 --
 Matthias Wessendorf

 blog: http://matthiaswessendorf.wordpress.com/
 sessions: http://www.slideshare.net/mwessendorf
 twitter: http://twitter.com/mwessendorf







-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf


Re: [VOTE] OpenEJB 3.1.3 release (1st try)

2010-10-13 Thread Kevan Miller

On Oct 11, 2010, at 5:30 PM, David Blevins wrote:

 Alright, begin binary banging.
 
 Repo:
 
 https://repository.apache.org/content/repositories/orgapacheopenejb-017/
 
 Binaries:
 
 http://people.apache.org/~dblevins/staging/3.1.3/
 
 Branch (to become a tag):
 
 http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.3/
 
 Updated ant script for testing the binaries:
 
 http://people.apache.org/~dblevins/staging/build.xml
 
 ant test:all
 
 Still need to hammer out the release notes.

This isn't necessary, but it would be convenient, if we could pick up the 
following change in the release:

On Oct 12, 2010, at 10:08 PM, dblev...@apache.org wrote:

 Author: dblevins
 Date: Wed Oct 13 02:08:04 2010
 New Revision: 1021975
 
 URL: http://svn.apache.org/viewvc?rev=1021975view=rev
 Log:
 OPENEJB-1370: Broadcast InetAddress.getLocalHost() when ejbd is bound to 
 0.0.0.0
 
 Modified:
   
openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
 

The property handling updates would be most important, but the 0.0.0.0 update 
is useful, also.

--kevan

Re: svn commit: r1021975 - /openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java

2010-10-13 Thread Kevan Miller

On Oct 12, 2010, at 10:08 PM, dblev...@apache.org wrote:

 Author: dblevins
 Date: Wed Oct 13 02:08:04 2010
 New Revision: 1021975
 
 URL: http://svn.apache.org/viewvc?rev=1021975view=rev
 Log:
 OPENEJB-1370: Broadcast InetAddress.getLocalHost() when ejbd is bound to 
 0.0.0.0
 
 Modified:

 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
 
 Modified: 
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
 URL: 
 http://svn.apache.org/viewvc/openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java?rev=1021975r1=1021974r2=1021975view=diff
 ==
 --- 
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
  (original)
 +++ 
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
  Wed Oct 13 02:08:04 2010
 @@ -70,6 +70,7 @@ public class ServiceDaemon implements Se
 private boolean secure;
 private StringTemplate discoveryUriFormat;
 private URI uri;
 +private Properties props;
 
 public ServiceDaemon(ServerService next) {
 this.next = next;
 @@ -112,6 +113,8 @@ public class ServiceDaemon implements Se
 
 public void init(Properties props) throws Exception {
 
 +this.props = props;
 +
 String formatString = props.getProperty(discovery);
 if (formatString != null){
 discoveryUriFormat = new StringTemplate(formatString);
 @@ -171,9 +174,26 @@ public class ServiceDaemon implements Se
 DiscoveryAgent agent = 
 SystemInstance.get().getComponent(DiscoveryAgent.class);
 if (agent != null  discoveryUriFormat != null) {
 MapString,String map = new HashMapString,String();
 +
 +// add all the properties that were used to construct this 
 service
 +for (Map.EntryObject, Object entry : props.entrySet()) {
 +map.put(entry.getKey().toString(), 
 entry.getValue().toString());
 +}
 +
 map.put(port, Integer.toString(port));
 -map.put(host, ip);
 -map.put(bind, ip);
 +
 +String address = ip;
 +
 +if (0.0.0.0.equals(address)) {

Pretty sure that this approach will not work on IP v6 system. Anybody have a 
better way of detecting this?

--kevan 

Guessing the address (Re: svn commit: r1021975)

2010-10-13 Thread David Blevins

On Oct 13, 2010, at 5:33 PM, Kevan Miller wrote:

 
 On Oct 12, 2010, at 10:08 PM, dblev...@apache.org wrote:
 
 Author: dblevins
 Date: Wed Oct 13 02:08:04 2010
 New Revision: 1021975
 
 URL: http://svn.apache.org/viewvc?rev=1021975view=rev
 Log:
 OPENEJB-1370: Broadcast InetAddress.getLocalHost() when ejbd is bound to 
 0.0.0.0
 
 Modified:
   
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
 
 Modified: 
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
 URL: 
 http://svn.apache.org/viewvc/openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java?rev=1021975r1=1021974r2=1021975view=diff
 ==
 --- 
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
  (original)
 +++ 
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
  Wed Oct 13 02:08:04 2010
 @@ -70,6 +70,7 @@ public class ServiceDaemon implements Se
private boolean secure;
private StringTemplate discoveryUriFormat;
private URI uri;
 +private Properties props;
 
public ServiceDaemon(ServerService next) {
this.next = next;
 @@ -112,6 +113,8 @@ public class ServiceDaemon implements Se
 
public void init(Properties props) throws Exception {
 
 +this.props = props;
 +
String formatString = props.getProperty(discovery);
if (formatString != null){
discoveryUriFormat = new StringTemplate(formatString);
 @@ -171,9 +174,26 @@ public class ServiceDaemon implements Se
DiscoveryAgent agent = 
 SystemInstance.get().getComponent(DiscoveryAgent.class);
if (agent != null  discoveryUriFormat != null) {
MapString,String map = new HashMapString,String();
 +
 +// add all the properties that were used to construct this 
 service
 +for (Map.EntryObject, Object entry : props.entrySet()) {
 +map.put(entry.getKey().toString(), 
 entry.getValue().toString());
 +}
 +
map.put(port, Integer.toString(port));
 -map.put(host, ip);
 -map.put(bind, ip);
 +
 +String address = ip;
 +
 +if (0.0.0.0.equals(address)) {
 
 Pretty sure that this approach will not work on IP v6 system. Anybody have a 
 better way of detecting this?

Yeah, not sure.  At the very least an IP v6 address won't show up as 0.0.0.0 so 
will remain unaltered.  But it would be nice to get something there.

-David



Re: [VOTE] OpenEJB 3.1.3 release (1st try) -- CANCELLED

2010-10-13 Thread David Blevins

On Oct 13, 2010, at 6:42 AM, Kevan Miller wrote:

 
 On Oct 11, 2010, at 5:30 PM, David Blevins wrote:
 
 Alright, begin binary banging.
 
 Repo:
 
 https://repository.apache.org/content/repositories/orgapacheopenejb-017/
 
 Binaries:
 
 http://people.apache.org/~dblevins/staging/3.1.3/
 
 Branch (to become a tag):
 
 http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.3/
 
 Updated ant script for testing the binaries:
 
 http://people.apache.org/~dblevins/staging/build.xml
 
 ant test:all
 
 Still need to hammer out the release notes.
 
 This isn't necessary, but it would be convenient, if we could pick up the 
 following change in the release:
 
 On Oct 12, 2010, at 10:08 PM, dblev...@apache.org wrote:
 
 Author: dblevins
 Date: Wed Oct 13 02:08:04 2010
 New Revision: 1021975
 
 URL: http://svn.apache.org/viewvc?rev=1021975view=rev
 Log:
 OPENEJB-1370: Broadcast InetAddress.getLocalHost() when ejbd is bound to 
 0.0.0.0
 
 Modified:
   
 openejb/branches/openejb-3.1.x/server/openejb-server/src/main/java/org/apache/openejb/server/ServiceDaemon.java
  
 
 The property handling updates would be most important, but the 0.0.0.0 update 
 is useful, also.

Alright.  Since we haven't seen many votes, going to get these changes in and 
re-roll.


-David