Re: We did it!!!
Sweet! Kudos to everyone for delivering an awesome product. - Ranga From: Karan Malhi karan.ma...@gmail.com To: dev@openejb.apache.org Sent: Wednesday, October 5, 2011 6:17 AM Subject: Re: We did it!!! Fantastic work!. Its a great opportunity to involve more folks into the project. On Wed, Oct 5, 2011 at 1:50 AM, Jean-Louis MONTEIRO jeano...@gmail.com wrote: Yes, we did it, all together! When we first started talking about TomEE and our wish to certify it, it was during our annual get-together. After only few month but a lot of hacking, we finally the specification coverage growing. Fully agree with Romain, Andy and may be everyone around: it wouldn't be possible without you David. That's true, Romain, Jon and everybody helped certifying TomEE, but without you, without your energy, your time driving us, your great ideas (setup on the cloud, ...). Well done everyone. Time to have a look for next steps ;-) Jean-Louis 2011/10/5 stratwine tovishwan...@gmail.com Absolutely awesome ! I already am telling my friends, about this with so much excitement. Great work, guys !!! Time to roar :) -Vishwa -- View this message in context: http://openejb.979440.n4.nabble.com/We-did-it-tp3873492p3873668.html Sent from the OpenEJB Dev mailing list archive at Nabble.com. -- Karan Singh Malhi twitter.com/KaranSinghMalhi
Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1652
I've added some resource env-entry tests and re-factored the Servlet Listener tests. Please review patch attached to: https://issues.apache.org/jira/browse/OPENEJB-1652 - Ranga
Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651
Sure, I'll try to get something in next week for the JSF tests. - Ranga From: David Blevins david.blev...@gmail.com To: Ranga S sra...@yahoo.com Cc: dev@openejb.apache.org dev@openejb.apache.org Sent: Saturday, September 10, 2011 2:55 PM Subject: Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651 On Sep 9, 2011, at 7:09 PM, Ranga S wrote: I've done some re-factoring of the tests and have uploaded a patch to this issue. Please review. Reviewed and committed! Thank you! I'm currently looking at the CDI issues. Got it down to 51 failures as of this morning (from 75). Nearly all the remaining issues are in JSF integration. Would be fantastic to get some of these in: - Arquillian: JSF Managed Bean Tests https://issues.apache.org/jira/browse/OPENEJB-1653 -David From: David Blevins david.blev...@gmail.com To: dev@openejb.apache.org Cc: Ranga S sra...@yahoo.com Sent: Friday, September 2, 2011 6:17 PM Subject: Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651 Very excellent! Was just remembering in terms of injection w should add these built-in types. All are declared via @Resource or resource-env-ref. - java:comp/UserTransaction - java:comp/TransactionManager - java:comp/TransactionSynchronizationRegistry - java:comp/ValidatorFactory - java:comp/Validator Any of those things should be able to be looked up or injected. -David On Sep 2, 2011, at 5:11 PM, Ranga S wrote: Hi I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing. Please review. - Ranga
Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651
I've done some re-factoring of the tests and have uploaded a patch to this issue. Please review. - Ranga From: David Blevins david.blev...@gmail.com To: dev@openejb.apache.org Cc: Ranga S sra...@yahoo.com Sent: Friday, September 2, 2011 6:17 PM Subject: Re: Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651 Very excellent! Was just remembering in terms of injection w should add these built-in types. All are declared via @Resource or resource-env-ref. - java:comp/UserTransaction - java:comp/TransactionManager - java:comp/TransactionSynchronizationRegistry - java:comp/ValidatorFactory - java:comp/Validator Any of those things should be able to be looked up or injected. -David On Sep 2, 2011, at 5:11 PM, Ranga S wrote: Hi I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing. Please review. - Ranga
Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1650
Hi I've uploaded a new patch for the above mentioned issue. I split up the one test into three separate test classes. It still has 16 tests of which 3 are failing. Please review. - Ranga
Arquillian-Embedded: Patch for https://issues.apache.org/jira/browse/OPENEJB-1651
Hi I've uploaded a patch for the above mentioned issue. They contain unit tests for injection into ServletFilters. It has 16 tests of which 3 are failing. Please review. - Ranga
Arquillian-Embedded: Servlet Listeners
Hi I've uploaded a patch for the JIRA issue https://issues.apache.org/jira/browse/OPENEJB-1652. They contain unit tests for injection into Servlet Listeners. It has 32 tests of which 8 are failing. Please review. - Ranga
Re: Arquillian tests
Hi I've created a JIRA ticket for this: https://issues.apache.org/jira/browse/OPENEJB-1649 It contains the following 4 sub-tasks: * Servlets: https://issues.apache.org/jira/browse/OPENEJB-1650 * Filters: https://issues.apache.org/jira/browse/OPENEJB-1651 * Listeners: https://issues.apache.org/jira/browse/OPENEJB-1652 * JSF Bean: https://issues.apache.org/jira/browse/OPENEJB-1653 I've uploaded a patch for the Servlets sub-task: https://issues.apache.org/jira/browse/OPENEJB-1650 Could someone review it? Three tests fail and once the functionality is implemented, these tests should pass (after uncommenting the injections). - Ranga From: David Blevins david.blev...@gmail.com To: dev@openejb.apache.org Sent: Friday, August 26, 2011 1:27 PM Subject: Arquillian tests Ok, real quick thoughts on what we could use -- at least initially -- for TomEE unit tests. For each of: - Servlet (lazy startup) - Servlet (load on startup) - Filter - Listener - JSF ManagedBean We should test basic injection of: - @Resource - TransactionManager - env-entry - All Primitive wrappers - Enum - Class - String - DataSource - JMS - ConnectionFactory (JMS) - Topic - Queue - @EJB - @Local - @LocalBean - @Remote - JPA - @PersistenceContext - @PersistenceUnit - CDI - @Inject - WS - @WebServiceRef Then all of the above in the exact component class, then again in a parent class to make sure subclassing and injection works. Should give us some basic coverage. JMS and WS injection would be the lowest priority since they are not in the web profile. -David
Re: Arquillian
I updated the repositories in the MovieFun Example pom.xml to include the Jboss repo and it builds fine for me. repositories repository idapache-m2-snapshot/id nameApache Snapshot Repository/name urlhttp://repository.apache.org/snapshots/url /repository repository idjboss/id nameJboss Repository/name urlhttps://repository.jboss.org/nexus/content/groups/public/url /repository /repositories - Ranga From: Jonathan Gallimore jonathan.gallim...@gmail.com To: dev@openejb.apache.org Sent: Friday, August 19, 2011 1:12 PM Subject: Re: Arquillian David just pointed out to me on IRC that you'll need some artifacts from the JBoss repository. Here's the relevant profile section from my ~/.m2/settings.xml: profile idjboss-public-repository/id repositories repository idjboss-public-repository-group/id nameJBoss Public Maven Repository Group/name urlhttps://repository.jboss.org/nexus/content/groups/public-jboss//url layoutdefault/layout releases enabledtrue/enabled updatePolicynever/updatePolicy /releases snapshots enabledtrue/enabled updatePolicynever/updatePolicy /snapshots /repository /repositories pluginRepositories pluginRepository idjboss-public-repository-group/id nameJBoss Public Maven Repository Group/name urlhttps://repository.jboss.org/nexus/content/groups/public-jboss//url layoutdefault/layout releases enabledtrue/enabled updatePolicynever/updatePolicy /releases snapshots enabledtrue/enabled updatePolicynever/updatePolicy /snapshots /pluginRepository /pluginRepositories /profile We should probably include this in the pom.xml for the adaptor. Jon On Fri, Aug 19, 2011 at 7:54 AM, Jonathan Gallimore jonathan.gallim...@gmail.com wrote: Hi all, Just to let you know I committed some more Arquillian support into the sandbox area. There's now three modes of operation: 1. Remote (you have to have TomEE running) 2. Fully embedded (no need for a war file or anything like that) 3. Slightly less embeddded - this uses Arquillian/Shrinkwrap's Maven resolver to find a copy of openejb.war. I think a couple of the tests don't work in Maven, and you'll need an up to date build of trunk for it to work. Other than that, it hopefully works ok. Please shout if you see any problems. Jon
Re: @Disposes
Thanks Karan. I've uploaded a patch to the ticket. Please take a look. (LogFactory, LoggerImpl, LoggerTest). - Ranga From: Karan Malhi karan.ma...@gmail.com To: dev@openejb.apache.org; Ranga S sra...@yahoo.com Sent: Monday, July 18, 2011 3:33 AM Subject: Re: @Disposes Done On Mon, Jul 18, 2011 at 1:33 AM, Ranga S sra...@yahoo.com wrote: Hi Karan Could you assign the following JIRA ticket to me? I'll upload the code to the ticket. https://issues.apache.org/jira/browse/OPENEJB-1613 - Ranga From: Karan Malhi karan.ma...@gmail.com To: dev@openejb.apache.org; Ranga S sra...@yahoo.com Sent: Sunday, July 17, 2011 8:25 PM Subject: Re: @Disposes Hi Ranga, Is it possible to share the code? Might make it a bit easier to discuss the issue and extend some suggestions on it. On Sun, Jul 17, 2011 at 9:17 PM, Ranga S sra...@yahoo.com wrote: Hi I am trying to get an example working with the @Disposes annotation. The @Produces method gets invoked properly. However, the @Disposes method doesn't get invoked. I don't see any errors either. Could someone help me out? - Ranga -- Karan Singh Malhi twitter.com/KaranSinghMalhi -- Karan Singh Malhi twitter.com/KaranSinghMalhi
Re: @Disposes
Hi I am trying to get an example working with the @Disposes annotation. The @Produces method gets invoked properly. However, the @Disposes method doesn't get invoked. I don't see any errors either. Could someone help me out? - Ranga
https://issues.apache.org/jira/browse/OPENEJB-1608
Please review the latest patch for the above mentioned ticket. I've split the original example into three separate examples. - Ranga
svn diff
Hi I am trying to add an example directory. I've done an svn add and it displayed that all the files have been added. However, when I do a svn diff to submit a patch, I only see additions from the first level. I don't see any of the source code contents in the patch file. I thought diff would recurse and add the source contents as well. Here is the sample directory structure: ../ ++examples +++myexample pom.xml README.txt src Only the pom.xml and README.txt changes are included in the patch file. I don't see any of the source code from under the src directory. Appreciate any help with this. - Ranga
Re: Examples - CDI
Hi I've submitted a patch for this ticket. Please review. https://issues.apache.org/jira/browse/OPENEJB-1608 I shall start working on this ticket. https://issues.apache.org/jira/browse/OPENEJB-1613 - Ranga From: David Blevins david.blev...@gmail.com To: David Blevins david.blev...@gmail.com Cc: dev@openejb.apache.org Sent: Tuesday, June 28, 2011 1:49 PM Subject: Re: Road Map On Jun 28, 2011, at 12:18 PM, David Blevins wrote: On Jun 23, 2011, at 9:18 AM, Ranga S wrote: I'll work on https://issues.apache.org/jira/browse/OPENEJB-1608 Great! Can you sign up for a JIRA account and send me your ID? Trying to get everything organized and things clearly marked as to who is doing what -- avoiding duplication and all that :) Ok, all yours! -David From: David Blevins david.blev...@gmail.com To: David Blevins david.blev...@gmail.com Cc: dev@openejb.apache.org Sent: Wednesday, June 22, 2011 8:34 PM Subject: Re: Road Map On Jun 4, 2011, at 6:10 PM, David Blevins wrote: Sent a note out to the LA JavaUsers Group about two weeks ago to see if anyone wanted to get together to do some hacking. Got three responses and we all got together today to give them an intro to the project and technology (hello Hao, Alper and Ranga!) So when asking myself what does the project need, here are some things that came to mind in no particular order. Servlet/EE Examples CDI Examples Bean Validation Examples Embedded TomEE Arquilian adapter Standalone TomEE Arquillian adapter Servlet EE Tests CDI/TCK/TomEE Harness BeanVal/TomEE harness BeanVal/Embedded harness Ok, on the examples front I created a little JIRA and a few subtasks for specific examples: https://issues.apache.org/jira/browse/OPENEJB-1607 No real comments in any of them yet, so if in doubt, ask :) If anyone wants to work on one of them, just ping the list with the jira number and we can assign it to you! -David Document Examples Overall I was thinking at this point we really need to flush out the CDI/BeanVal stuff from a TCK perspective. Add examples for those things. Get some more complete Arquillian support for TomEE and beef up the examples there as well, plus migrate some of our iTests over. And of course, get Web Profile Certified. That's hard to do unless you're a committer with an NDA, so the Arquillian set of tests seems critical for making it so more people can help in that regard. Thoughts? -David
Re: Examples - CDI
Thanks Mark! Let me try to describe the example. I would like to implement a POJO CDI example to start with. It would show some of the concepts and annotations. Once I have that working, I was thinking about providing examples that show integration of CDI with EJBs or Servlets or JSF. Now, for the POJO CDI step, I have defined some classes that use some common CDI annotations. Structure shown below: + Interface A ++ Class A1 implements A (Default) ++ Class A2 implements A (Alternative) + Class B (needs to be injected with an implementation of A) However, I am stuck at how to initialize the CDI provider (CODI) in my test so that when I access Class B it should be available for me to use. From your email, it sounds like I should do something like what the BeanManagerProvider does. - Ranga From: Mark Struberg strub...@yahoo.de To: dev@openejb.apache.org Sent: Friday, June 10, 2011 3:47 AM Subject: Re: Examples - CDI Hi! new WebBeansContext().getBeanManagerImpl().getBeans(MyClass.class) You should avoid to use the WebBeansContext manually. And for sure not create a new instance at all ;) I fear I miss the context of what you try to achieve, but I guess you need to 'start' the CDI container before you can use it. You can take a look at OWBs cditest project [1]. It contains a container-independent API + an impl for OWB. If you are hacking against OWB internal stuff (so you skip container portability) then you could just use BeanManagerImpl.getInstance(). If you like to keep it portable, then you might use a trick like I wrote in CODIs BeanManagerProvider [2]. LieGrue, strub [1] https://svn.apache.org/repos/asf/openwebbeans/trunk/webbeans-test/ [2] https://svn.apache.org/repos/asf/myfaces/extensions/cdi/trunk/core/api/src/main/java/org/apache/myfaces/extensions/cdi/core/api/provider/BeanManagerProvider.java --- On Thu, 6/9/11, Ranga S sra...@yahoo.com wrote: From: Ranga S sra...@yahoo.com Subject: Re: Examples - CDI To: dev@openejb.apache.org dev@openejb.apache.org Date: Thursday, June 9, 2011, 11:16 PM Thanks! I tried using the createEJBContainer construct, but it complains about not finding any modules to deploy when I run it. However, I was trying to use the following, but it prints an empty list: new WebBeansContext().getBeanManagerImpl().getBeans(MyClass.class) - Ranga From: David Blevins david.blev...@gmail.com To: dev@openejb.apache.org Sent: Wednesday, June 8, 2011 4:03 PM Subject: Re: Examples - CDI On Jun 8, 2011, at 3:09 PM, Ranga S wrote: Thanks! I wanted to first get a simple stand-alone example up and running. I was wondering how to get access to the OWB container to lookup a Named bean. If a standalone example is out-of-the scope of this project, please let me know and I shall look at integrated examples. Just slipped this in: https://issues.apache.org/jira/browse/OPENEJB-1571 Should do the trick! The EJBContainer.createEJBContainer() is the best approach for our examples. -David From: Mark Struberg strub...@yahoo.de To: dev@openejb.apache.org; Ranga S sra...@yahoo.com Sent: Wednesday, June 8, 2011 12:59 PM Subject: Re: Examples - CDI hi! You could look at the maven archetypes for Apache MyFaces CODI [1] which is a CDI extension. $ mvn archetype:generate -DarchetypeCatalog=http://myfaces.apache.org It creates a small OWB + MyFaces +CODI based example stub. Just add OpenEJB on top (e.g. for the database service layer) and you're done ;) LieGrue, strub [1] http://myfaces.apache.org/extensions/cdi/index.html --- On Wed, 6/8/11, Ranga S sra...@yahoo.com wrote: From: Ranga S sra...@yahoo.com Subject: Re: Examples - CDI To: dev@openejb.apache.org dev@openejb.apache.org Date: Wednesday, June 8, 2011, 6:52 PM Hi I would like to take a crack at coming up with some examples for CDI. Let me read some documentation on it. Once I have something concrete, I shall send a note to this list. - Ranga
Re: Examples - CDI
Thanks! I tried using the createEJBContainer construct, but it complains about not finding any modules to deploy when I run it. However, I was trying to use the following, but it prints an empty list: new WebBeansContext().getBeanManagerImpl().getBeans(MyClass.class) - Ranga From: David Blevins david.blev...@gmail.com To: dev@openejb.apache.org Sent: Wednesday, June 8, 2011 4:03 PM Subject: Re: Examples - CDI On Jun 8, 2011, at 3:09 PM, Ranga S wrote: Thanks! I wanted to first get a simple stand-alone example up and running. I was wondering how to get access to the OWB container to lookup a Named bean. If a standalone example is out-of-the scope of this project, please let me know and I shall look at integrated examples. Just slipped this in: https://issues.apache.org/jira/browse/OPENEJB-1571 Should do the trick! The EJBContainer.createEJBContainer() is the best approach for our examples. -David From: Mark Struberg strub...@yahoo.de To: dev@openejb.apache.org; Ranga S sra...@yahoo.com Sent: Wednesday, June 8, 2011 12:59 PM Subject: Re: Examples - CDI hi! You could look at the maven archetypes for Apache MyFaces CODI [1] which is a CDI extension. $ mvn archetype:generate -DarchetypeCatalog=http://myfaces.apache.org It creates a small OWB + MyFaces +CODI based example stub. Just add OpenEJB on top (e.g. for the database service layer) and you're done ;) LieGrue, strub [1] http://myfaces.apache.org/extensions/cdi/index.html --- On Wed, 6/8/11, Ranga S sra...@yahoo.com wrote: From: Ranga S sra...@yahoo.com Subject: Re: Examples - CDI To: dev@openejb.apache.org dev@openejb.apache.org Date: Wednesday, June 8, 2011, 6:52 PM Hi I would like to take a crack at coming up with some examples for CDI. Let me read some documentation on it. Once I have something concrete, I shall send a note to this list. - Ranga
Re: Examples - CDI
Thanks David! Actually, I do have the beans.xml file in there. :) I tried the ApplicationComposer sample and the error is Test class should have at least one @Module method - Ranga From: David Blevins david.blev...@gmail.com To: dev@openejb.apache.org Sent: Thursday, June 9, 2011 5:19 PM Subject: Re: Examples - CDI On Jun 9, 2011, at 4:16 PM, Ranga S wrote: Thanks! I tried using the createEJBContainer construct, but it complains about not finding any modules to deploy when I run it. Add a src/main/resources/META-INF/beans.xml file. That should do the trick. CDI spec requires users to have a beans.xml even if it is an empty file. That said the EJB spec does not require an xml file so we end up having to scan everything anyway. So we could probably get it to work without the empty file. We're currently just looking for EJB annotations + @ManagedBean to determine if it is a module of interest, but we could easily expand that. Anyway, for now try with the extra xml file and give a shout if you run into any issues. -David
Re: Examples - CDI
Hi I would like to take a crack at coming up with some examples for CDI. Let me read some documentation on it. Once I have something concrete, I shall send a note to this list. - Ranga
Re: Examples - CDI
Thanks! I wanted to first get a simple stand-alone example up and running. I was wondering how to get access to the OWB container to lookup a Named bean. If a standalone example is out-of-the scope of this project, please let me know and I shall look at integrated examples. - Ranga From: Mark Struberg strub...@yahoo.de To: dev@openejb.apache.org; Ranga S sra...@yahoo.com Sent: Wednesday, June 8, 2011 12:59 PM Subject: Re: Examples - CDI hi! You could look at the maven archetypes for Apache MyFaces CODI [1] which is a CDI extension. $ mvn archetype:generate -DarchetypeCatalog=http://myfaces.apache.org It creates a small OWB + MyFaces +CODI based example stub. Just add OpenEJB on top (e.g. for the database service layer) and you're done ;) LieGrue, strub [1] http://myfaces.apache.org/extensions/cdi/index.html --- On Wed, 6/8/11, Ranga S sra...@yahoo.com wrote: From: Ranga S sra...@yahoo.com Subject: Re: Examples - CDI To: dev@openejb.apache.org dev@openejb.apache.org Date: Wednesday, June 8, 2011, 6:52 PM Hi I would like to take a crack at coming up with some examples for CDI. Let me read some documentation on it. Once I have something concrete, I shall send a note to this list. - Ranga
Re: Build Failure
Hi I just checked out the source code using SVN from: http://svn.apache.org/repos/asf/openejb/trunk/openejb3/ When I try to build using Maven (2.2.1), three tests are failing. Output from the failed tests is as follows: --- Test set: org.apache.openejb.core.webservices.HandlerResolverImplTest --- Tests run: 5, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.574 sec FAILURE! testServiceMatching(org.apache.openejb.core.webservices.HandlerResolverImplTest) Time elapsed: 0.008 sec ERROR! org.apache.openejb.OpenEJBException: Cannot unmarshall the webservices.xml file: file:/Users/sranga/TomEE/openejb3/container/openejb-core/target/test-classes/handlers_service.xml: java.lang.NullPointerException at org.apache.openejb.config.ReadDescriptors.readHandlerChains(ReadDescriptors.java:456) at org.apache.openejb.core.webservices.HandlerResolverImplTest.readHandlerChains(HandlerResolverImplTest.java:170) at org.apache.openejb.core.webservices.HandlerResolverImplTest.testServiceMatching(HandlerResolverImplTest.java:56) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ... ... testPortMatching(org.apache.openejb.core.webservices.HandlerResolverImplTest) Time elapsed: 0.056 sec ERROR! org.apache.openejb.OpenEJBException: Cannot unmarshall the webservices.xml file: file:/Users/sranga/TomEE/openejb3/container/openejb-core/target/test-classes/handlers_port.xml: java.lang.NullPointerException at org.apache.openejb.config.ReadDescriptors.readHandlerChains(ReadDescriptors.java:456) at org.apache.openejb.core.webservices.HandlerResolverImplTest.readHandlerChains(HandlerResolverImplTest.java:170) at org.apache.openejb.core.webservices.HandlerResolverImplTest.testPortMatching(HandlerResolverImplTest.java:109) ... ... testMixedMatching(org.apache.openejb.core.webservices.HandlerResolverImplTest) Time elapsed: 0.004 sec ERROR! org.apache.openejb.OpenEJBException: Cannot unmarshall the webservices.xml file: file:/Users/sranga/TomEE/openejb3/container/openejb-core/target/test-classes/handlers_mixed.xml: java.lang.NullPointerException at org.apache.openejb.config.ReadDescriptors.readHandlerChains(ReadDescriptors.java:456) at org.apache.openejb.core.webservices.HandlerResolverImplTest.readHandlerChains(HandlerResolverImplTest.java:170) at org.apache.openejb.core.webservices.HandlerResolverImplTest.testMixedMatching(HandlerResolverImplTest.java:139) ... ... Caused by: java.lang.NullPointerException at org.apache.openejb.jee.HandlerChainsStringQNameAdapter.unmarshal(HandlerChainsStringQNameAdapter.java:44) at org.apache.openejb.jee.HandlerChainsStringQNameAdapter.unmarshal(HandlerChainsStringQNameAdapter.java:29) at com.sun.xml.internal.bind.v2.runtime.reflect.AdaptedAccessor.set(AdaptedAccessor.java:70) - Ranga
