[jira] [Commented] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961860#comment-13961860 ] Rick Curtis commented on OPENJPA-2487: -- Do the unit tests pass with this change? upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961903#comment-13961903 ] Romain Manni-Bucau commented on OPENJPA-2487: - Actually I was never able to get a clean run of openjpa (I mean since I looked the project years ago) so no. We can discuss some issue son IRC (freenode, I'm on openejb for instance - not sure openjpa has one active) if you think it is faster to understand the issue you have (?). upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961962#comment-13961962 ] Kevin Sutter commented on OPENJPA-2487: --- The patch looks good from a Java 7 perspective. I've tested with Java 7 and your asm 5 xbean shaded jar. Everything looks good. From that perspective, we should be okay with integrating this change into trunk. When I have time, I'll try junit testing with Java 8. (FYI, we are not going to change OpenJPA to build with Java 8.) upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961971#comment-13961971 ] Romain Manni-Bucau edited comment on OPENJPA-2487 at 4/7/14 4:11 PM: - Well the goal is just to let the code supports java 8 (same constraint for CXF, OWB, OpenEJB and TomEE) was (Author: romain.manni-bucau): Well the goal is just to let the code support java 8 (same constraint for CXF, OWB, OpenEJB and TomEE) upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961971#comment-13961971 ] Romain Manni-Bucau commented on OPENJPA-2487: - Well the goal is just to let the code support java 8 (same constraint for CXF, OWB, OpenEJB and TomEE) upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961978#comment-13961978 ] Kevin Sutter commented on OPENJPA-2487: --- Right. Unfortunately, Java8 has introduced some incompatibilities with the OpenJPA test suite. As soon as I try to build the junit test suite with Java 8 (and asm 5), I immediately hit the issue documented by openjpa-2442. So, we could go ahead with your patch since it doesn't affect the Java 7 usage pattern. But, it does not resolve the overall issue of using Java 8 with OpenJPA applications. upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962232#comment-13962232 ] Romain Manni-Bucau commented on OPENJPA-2487: - hmm, well there are multiple things here: 1) in tomee we absolutely need an openjpa release with asm5 since we'll not ship asm3/4 anymore 2) is 2442 linked to dynamic proxying? If so we stil lhave static enhancement. If not openjpa enhancement should be rewritten with full asm support since serp is not upgraded anymore. Can be a bit too long so a pre-release with at least asm5 would be very welcomed (otherwise tomee will fork again to release which is a pain for everyone :() upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OPENJPA-2487) upgrade openjpa to asm5 to support java 8
[ https://issues.apache.org/jira/browse/OPENJPA-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962327#comment-13962327 ] Rick Curtis commented on OPENJPA-2487: -- Does TomEE need to be built at a Java 1.8 source level, or just needs to run on java 1.8? 2) is 2442 linked to dynamic proxying? If so we still have static enhancement. Static enhancement will not solve this problem. This bug is related to our dynamic proxies that get created for tracking non-standard types. If not openjpa enhancement should be rewritten with full asm support since serp is not upgraded anymore. Great idea, but it is not a trivial task... and I don't know who is going to step up and do the work. upgrade openjpa to asm5 to support java 8 - Key: OPENJPA-2487 URL: https://issues.apache.org/jira/browse/OPENJPA-2487 Project: OpenJPA Issue Type: Task Reporter: Romain Manni-Bucau Attachments: openjpa-asm5-release.patch, openjpa-asm5.patch -- This message was sent by Atlassian JIRA (v6.2#6252)
