Build failed in Jenkins: OpenMeetings ยป Red5-installer #63

2021-10-09 Thread Apache Jenkins Server
See 


Changes:


--
[...truncated 18.42 KB...]

Changing directory to: 
"

Processing script file: "red5.nsi"
Name: "Red5"
!define: "REGKEY"="SOFTWARE\$(^Name)"
!define: "COMPANY"="Red5 Server"
!define: "DESCRIPTION"="Red5 is an Open Source Media Server written in Java"
!define: "URL"="https://github.com/Red5";
!define: "BuildRoot"=".\work\red5-server"
!define: "ServiceRoot"=".\work\red5-service"
!define: "ImageRoot"="..\images"
!define: "CommonsDaemonVersion"="1.0.14"
PluginDir: ".\NSIS_Plugins"
 - AccessControl::ClearOnFile
 - AccessControl::ClearOnRegKey
 - AccessControl::DenyOnFile
 - AccessControl::DenyOnRegKey
 - AccessControl::DisableFileInheritance
 - AccessControl::DisableRegKeyInheritance
 - AccessControl::EnableFileInheritance
 - AccessControl::EnableRegKeyInheritance
 - AccessControl::GetCurrentUserName
 - AccessControl::GetFileGroup
 - AccessControl::GetFileOwner
 - AccessControl::GetRegKeyGroup
 - AccessControl::GetRegKeyOwner
 - AccessControl::GrantOnFile
 - AccessControl::GrantOnRegKey
 - AccessControl::IsUserTheAdministrator
 - AccessControl::RevokeOnFile
 - AccessControl::RevokeOnRegKey
 - AccessControl::SetFileGroup
 - AccessControl::SetFileOwner
 - AccessControl::SetOnFile
 - AccessControl::SetOnRegKey
 - AccessControl::SetRegKeyGroup
 - AccessControl::SetRegKeyOwner
 - AccessControl::SidToName
 - Dialogs::Author
 - Dialogs::Folder
 - Dialogs::InputBox
 - Dialogs::InputRegCode
 - Dialogs::Open
 - Dialogs::Save
 - Dialogs::Ver
 - ZipDLL::extractall
 - ZipDLL::extractfile
!define: "MUI_ICON"="..\images\red5.ico"
!define: "MUI_HEADERIMAGE"=""
!define: "MUI_HEADERIMAGE_BITMAP"="..\images\red5_header.bmp"
!define: "MUI_FINISHPAGE_NOAUTOCLOSE"=""
!define: "MUI_STARTMENUPAGE_REGISTRY_ROOT"="HKLM"
!define: "MUI_STARTMENUPAGE_REGISTRY_KEY"="SOFTWARE\$(^Name)"
!define: "MUI_STARTMENUPAGE_REGISTRY_VALUENAME"="StartMenuGroup"
!define: "MUI_STARTMENUPAGE_DEFAULTFOLDER"="Red5"
!include: "/usr/share/nsis/Include/Sections.nsh"
!define: "SECTIONS_INCLUDED"=""
!define: "SF_SELECTED"="1"
!define: "SF_SECGRP"="2"
!define: "SF_SUBSEC"="2"
!define: "SF_SECGRPEND"="4"
!define: "SF_SUBSECEND"="4"
!define: "SF_BOLD"="8"
!define: "SF_RO"="16"
!define: "SF_EXPAND"="32"
!define: "SF_PSELECTED"="64"
!define: "SF_TOGGLED"="128"
!define: "SF_NAMECHG"="256"
!define: "SECTION_OFF"="0xFFFE"
!define: "INSTTYPE_1"="1"
!define: "INSTTYPE_2"="2"
!define: "INSTTYPE_3"="4"
!define: "INSTTYPE_4"="8"
!define: "INSTTYPE_5"="16"
!define: "INSTTYPE_6"="32"
!define: "INSTTYPE_7"="64"
!define: "INSTTYPE_8"="128"
!define: "INSTTYPE_9"="256"
!define: "INSTTYPE_10"="512"
!define: "INSTTYPE_11"="1024"
!define: "INSTTYPE_12"="2048"
!define: "INSTTYPE_13"="4096"
!define: "INSTTYPE_14"="8192"
!define: "INSTTYPE_15"="16384"
!define: "INSTTYPE_16"="32768"
!define: "INSTTYPE_17"="65536"
!define: "INSTTYPE_18"="131072"
!define: "INSTTYPE_19"="262144"
!define: "INSTTYPE_20"="524288"
!define: "INSTTYPE_21"="1048576"
!define: "INSTTYPE_22"="2097152"
!define: "INSTTYPE_23"="4194304"
!define: "INSTTYPE_24"="8388608"
!define: "INSTTYPE_25"="16777216"
!define: "INSTTYPE_26"="33554432"
!define: "INSTTYPE_27"="67108864"
!define: "INSTTYPE_28"="134217728"
!define: "INSTTYPE_29"="268435456"
!define: "INSTTYPE_30"="536870912"
!define: "INSTTYPE_31"="1073741824"
!define: "INSTTYPE_32"="2147483648"
!include: closed: "/usr/share/nsis/Include/Sections.nsh"
!include: "/usr/share/nsis/Include/MUI.nsh"
!include: "/usr/share/nsis/Contrib/Modern UI/System.nsh"
NSIS Modern User Interface version 1.8 - Copyright 2002-2015 Joost Verburg 
(/usr/share/nsis/Contrib/Modern UI/System.nsh:8)
!define: "MUI_INCLUDED"=""
!define: "MUI_SYSVERSION"="1.8"
!define: "MUI_VERBOSE"="3"
!include: closed: "/usr/share/nsis/Contrib/Modern UI/System.nsh"
!include: closed: "/usr/share/nsis/Include/MUI.nsh"
!include: "./NSIS_Includes/AdvReplaceInFile.nsh"
Function: "AdvReplaceInFile"
Exch($0,0)
Exch(st(1),0)
Exch($1,0)
Exch(st(1),0)
Exch(st(2),0)
Exch($2,0)
Exch(st(2),0)
Exch(st(3),0)
Exch($3,0)
Exch(st(3),0)
Exch(st(4),0)
Exch($4,0)
Exch(st(4),0)
Push: $5
Push: $6
Push: $7
Push: $8
Push: $9
Push: $R0
Push: $R1
Push: $R2
Push: $R3
Push: $R4
Push: $R5
Push: $R6
GetTempFileName -> $R6
FileOpen: $0 as r -> $R1
FileOpen: $R6 as w -> $R0
StrLen $R3 "$4"
StrCpy $R4 "-1" () ()
StrCpy $R5 "-1" () ()
ClearErrors
FileRead: $R1->$R2 (max:)
IfErrors ?exit:
StrCpy $5 "0" () ()
StrCpy $7 "$R2" () ()
IntOp: $5=$5-1
StrCpy $6 "$7" ($R3) ($5)
StrCmp "$6" "" equal=file_write2, nonequal=
StrCmp "$6" "$4" equal=0, nonequal=loop_filter
StrCpy $8 "$7" ($5) ()
IntOp: $6=$5+$R3
IntCmp $6:0 equal=is0, < not0, > 
StrCpy $9 "" () ()
Goto: done
StrCpy $9 "$7" () ($6)
StrCpy $7 "$8$3$9" () ()
IntOp: $R4=$R4+1
StrCmp "$2" "all" equal=file_write1, nonequal=
StrCmp "$R4" "$2" equal=0, nonequal=file_write2
IntOp: $R

Updated mobile viewports to make icons and buttons clickable on mobile device in portrait mode

2021-10-09 Thread seba.wag...@gmail.com
I've updated the mobile viewports which makes OpenMeetings a lot more
usable on a Mobile device. Especially when in portrait mode it was pretty
much impossible to click any button or icon.Since they are literally 2x2
pixels in size on the screen.

There are some sample screens of forms, for example on the login form:
https://issues.apache.org/jira/browse/OPENMEETINGS-2685
or when you try to click the icons to share your webcam / microphone:
https://issues.apache.org/jira/browse/OPENMEETINGS-2686

However now in portrait mode on the mobile device: The whiteboard is very
small. This is in portrait mode. Landscape is proportionally fine.
See screenshots in https://issues.apache.org/jira/browse/OPENMEETINGS-2686

It would be better if in portrait mode on a mobile device screen: The
whiteboard should use more space. For example by toggling the user list to
be "minimised" + adding some additional screen buttons for sharing
webcam/microphone (outside of the user list).

I would argue the ability to share your audio/video is essential to be
visible. Also on a mobile device. But you don't need to see all the users
in the user list constantly. More important to see the whiteboard and other
users. However currently there isn't a way to minimise the user list _and_
show the audio/video sharing buttons. I'm thinking of adding this
functionality. Just for mobile devices to become more usable.

Thanks
Seb

Sebastian Wagner
Director Arrakeen Solutions, OM-Hosting.com
http://arrakeen-solutions.co.nz/
https://om-hosting.com - Cloud & Server Hosting for HTML5
Video-Conferencing OpenMeetings




[GitHub] [openmeetings] sebawagner merged pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browsers

2021-10-09 Thread GitBox


sebawagner merged pull request #162:
URL: https://github.com/apache/openmeetings/pull/162


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [openmeetings] sebawagner commented on pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browsers

2021-10-09 Thread GitBox


sebawagner commented on pull request #162:
URL: https://github.com/apache/openmeetings/pull/162#issuecomment-939368500


   This still works fine and has minimal impact on desktop browsers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [openmeetings] sebawagner commented on a change in pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browser

2021-10-09 Thread GitBox


sebawagner commented on a change in pull request #162:
URL: https://github.com/apache/openmeetings/pull/162#discussion_r725542714



##
File path: openmeetings-web/src/main/webapp/css/raw-general.css
##
@@ -1,7 +1,14 @@
 /* Licensed under the Apache License, Version 2.0 (the "License") 
http://www.apache.org/licenses/LICENSE-2.0 */
+:root {
+--app-height: 100%;
+}
 html, body {
-   height: 100%;
+   width: 100vw;

Review comment:
   Using viewport width, rather then 100%. See: 
https://www.w3schools.com/cssref/css_units.asp




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [openmeetings] sebawagner commented on a change in pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browser

2021-10-09 Thread GitBox


sebawagner commented on a change in pull request #162:
URL: https://github.com/apache/openmeetings/pull/162#discussion_r725542555



##
File path: openmeetings-web/src/main/webapp/css/raw-general.css
##
@@ -1,7 +1,14 @@
 /* Licensed under the Apache License, Version 2.0 (the "License") 
http://www.apache.org/licenses/LICENSE-2.0 */
+:root {
+--app-height: 100%;
+}
 html, body {
-   height: 100%;
+   width: 100vw;
+height: var(--app-height);

Review comment:
   See above comment on how this will be adjusted to fix for mobile 
browsers dynamically showing/toggling the URL/navigation bar when rotating from 
portrait to landscape mode.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [openmeetings] sebawagner commented on a change in pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browser

2021-10-09 Thread GitBox


sebawagner commented on a change in pull request #162:
URL: https://github.com/apache/openmeetings/pull/162#discussion_r725542555



##
File path: openmeetings-web/src/main/webapp/css/raw-general.css
##
@@ -1,7 +1,14 @@
 /* Licensed under the Apache License, Version 2.0 (the "License") 
http://www.apache.org/licenses/LICENSE-2.0 */
+:root {
+--app-height: 100%;
+}
 html, body {
-   height: 100%;
+   width: 100vw;
+height: var(--app-height);

Review comment:
   See above comment on how this will be adjusted to fix for mobile 
browsers dynamically showing/toggling the URL/navigation bar when rotating from 
landscape to portrait mode.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [openmeetings] sebawagner commented on a change in pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browser

2021-10-09 Thread GitBox


sebawagner commented on a change in pull request #162:
URL: https://github.com/apache/openmeetings/pull/162#discussion_r725542475



##
File path: 
openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.html
##
@@ -22,6 +22,7 @@
 http://wicket.apache.org/dtds.data/wicket-9.xsd"; 
wicket:id="html">
 

+   

Review comment:
   Adjust viewport. I think Bootstrap needs this tag also. But this will 
adjust the viewport for mobile devices




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [openmeetings] sebawagner commented on a change in pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browser

2021-10-09 Thread GitBox


sebawagner commented on a change in pull request #162:
URL: https://github.com/apache/openmeetings/pull/162#discussion_r725542445



##
File path: openmeetings-web/src/main/front/main/src/index.js
##
@@ -20,3 +20,10 @@ Object.assign(window, {
$('#busy-indicator').hide();
}
 });
+function _updateResize() {
+   const doc = document.documentElement
+doc.style.setProperty('--app-height', `${window.innerHeight}px`)

Review comment:
   This is a fix to adjust the height on iOS and mobile devices when the 
URL/navigation bar is hidden. Otherwise 100% will still show a white bar under 
the  because 100% on a mobile browser is assuming the 
URL/navigation bar of the browser is visible.
   
   This is particular annoying if on a mobile browser in landscape mode as it 
reduces the screen size by 10-20%.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [openmeetings] sebawagner opened a new pull request #162: OPENMEETINGS-2684, OPENMEETINGS-2280 Apply viewport and fix height to adjust when resizing occurs for iOS/Mobile browsers

2021-10-09 Thread GitBox


sebawagner opened a new pull request #162:
URL: https://github.com/apache/openmeetings/pull/162


   Fixes:
   **OPENMEETINGS-2685 - Login form on Mobile screens not user-friendly 
visibility**
   
   Old:
   
![IMG_0340](https://user-images.githubusercontent.com/5152064/136674692-a6653828-8544-4b53-bd3d-04c8ccf0b403.PNG)
   
   New:
   
![IMG_0342](https://user-images.githubusercontent.com/5152064/136674697-b0200f79-4eb3-437a-bb8e-5f484ca5dac5.PNG)
   
   
   OPENMEETINGS-2280 - Android landscape mode cannot sign up as virtual 
keyboard covers UI
   Old: no screenshot
   
   New:
   
![Screenshot_20211010-105821_Chrome](https://user-images.githubusercontent.com/5152064/136674701-bb35d411-fac4-4618-afdc-dd25fdc9258e.jpeg)
   
   OPENMEETINGS-2686 - Can't click buttons to share you webcam or microphone on 
mobile screen in portrait mode
   **no old**
   
   New:
   
![IMG_0344](https://user-images.githubusercontent.com/5152064/136674717-503d8533-3100-459c-a84d-470ce6dcb296.PNG)
   
   OPENMEETINGS-2684 - Rotating device landscape in iOS leaves whitespace and 
doesn't use full height
   Old:
   
![IMG_0341](https://user-images.githubusercontent.com/5152064/136674723-cd70c92e-f876-4905-8275-356f5bc662ec.jpeg)
   
   New:
   
![IMG_0344](https://user-images.githubusercontent.com/5152064/136674732-eb496835-7e2b-4a36-9163-c7db1b3136a9.PNG)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org