[GitHub] [openmeetings] sebawagner opened a new pull request #167: OPENMEETINGS-2693 Update instructions on how to change Mobile Icons.

2021-10-18 Thread GitBox 


sebawagner opened a new pull request #167:
URL: https://github.com/apache/openmeetings/pull/167


   Updates instructions on how to generate mobile icons.
   Move logo and icon into one page, and under "UI" section of configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Updated mobile viewports to make icons and buttons clickable on mobile device in portrait mode

2021-10-18 Thread seba.wag...@gmail.com 
Yeah let me update the docs and you can review

We can write _simple_ script to generate all those images using ImageMagic

There is actually an easier way to generate the icons, snippets and in a
single command. I think easier at least from my perspective.

Let me update the docs.

Thanks
Sebastian

Sebastian Wagner
Director Arrakeen Solutions, OM-Hosting.com
http://arrakeen-solutions.co.nz/
https://om-hosting.com - Cloud & Server Hosting for HTML5
Video-Conferencing OpenMeetings




On Mon, 18 Oct 2021 at 21:12, Maxim Solodovnik  wrote:

> Now I understand :(
> OK let it be
>
> But we can help our users
> We can write _simple_ script to generate all those images using ImageMagic
> (which is our pre-requisite)
> WDYT?
>
> On Mon, 18 Oct 2021 at 08:57, seba.wag...@gmail.com  >
> wrote:
>
> > >
> > > Lot's of our users (all of them) has their own icons
> >
> > => We can update the docs on how to customise those icons. It is not
> hard,
> > it's just not easy to automate.
> >
> >
> > > I doubt _we require_ these icons :(
> > > I see nothing so special in ios
> > > And I believe there should some sort of fallback
> >
> > Manifest file uses only 2 images
> >
> > => iOS does not use the icons from the manifest file. It uses the  ...
> > > tags from inside the html file.
> > => Most of those icons are the "splash" screen for iOS, not the actual
> home
> > screen icon.
> >
> > All these added images are no more than a favicons (including those
> > > listed in manifest)
> > > One svg can provide substitute fir all of them :)
> >
> > => In fact all those images are generated from a single SVG file.
> > But unfortunately Android/iOS does not support SVG for home screen icons
> > and preview icons.
> > And also iOS does not support it for the splash screen. So it needs the
> > images pre-rendered.
> >
> > We can provide some instructions on how to update the icons for
> > customisation. Like I say, it's not hard, it is just not that easy to
> > automate (and reference a single SVG as you suggested for example).
> >
> > Thanks
> > Sebastian
> >
> > Sebastian Wagner
> > Director Arrakeen Solutions, OM-Hosting.com
> > http://arrakeen-solutions.co.nz/
> > https://om-hosting.com - Cloud & Server Hosting for HTML5
> > Video-Conferencing OpenMeetings
> > <
> >
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> > >
> > <
> >
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> > >
> >
> >
> > On Mon, 18 Oct 2021 at 14:40, Maxim Solodovnik 
> > wrote:
> >
> > > from mobile (sorry for typos ;)
> > >
> > >
> > > On Mon, Oct 18, 2021, 03:23 seba.wag...@gmail.com <
> seba.wag...@gmail.com
> > >
> > > wrote:
> > >
> > > > >
> > > > > I would add 30 new icons I believe this is too much :(
> > > >
> > > > =>They are generated from the same icon, see:
> > > > https://github.com/onderceylan/pwa-asset-generator
> > > > But I doubt anybody needs to do that again. Unless OpenMeetings
> changes
> > > its
> > > > icon/logo.
> > > >
> > >
> > > Lot's of our users (all of them) has their own icons
> > > So *every* om user should recreate those icons
> > >
> > >
> > > > We require those icons because iOS requires different icons
> > pre-rendered
> > > in
> > > > different screen resolutions. Because iOS is special :)
> > > >
> > >
> > > I doubt _we require_ these icons :(
> > > I see nothing so special in ios
> > > And I believe there should some sort of fallback
> > >
> > > Manifest file uses only 2 images
> > >
> > > But also it's common in Mobile development to require images in
> different
> > > > screen resolutions pre-compiled.
> > > >
> > > > I would modify favicon to be SVG
> > > >
> > > > => I did not change the favicon. The Favicon declaration has been the
> > > same
> > > > since 3 years ago.
> > > >
> > > >
> > >
> >
> https://github.com/apache/openmeetings/blame/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.html#L55
> > >
> > >
> > > All these added images are no more than a favicons (including those
> > listed
> > > in manifest)
> > > One svg can provide substitute fir all of them :)
> > >
> > >
> > > >
> > > > Thanks
> > > > Sebastian
> > > >
> > > > Sebastian Wagner
> > > > Director Arrakeen Solutions, OM-Hosting.com
> > > > http://arrakeen-solutions.co.nz/
> > > > https://om-hosting.com - Cloud & Server Hosting for HTML5
> > > > Video-Conferencing OpenMeetings
> > > > <
> > > >
> > >
> >
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> > > > >
> > > > <
> > > >
> > >
> >
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> > > > >
> > > >
> > > >
> > > > On Mon, 18 Oct 2021 at 04:40, Maxim Solodovnik  >
> > > > wrote:
> > > >
> > > > > Just have added some review comments
> > > > >
> > >

[GitHub] [openmeetings] sebawagner opened a new pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-18 Thread GitBox 


sebawagner opened a new pull request #166:
URL: https://github.com/apache/openmeetings/pull/166


   Parse Path part via java.net.URI API 
   
   See also: 
https://github.com/apache/openmeetings/pull/165#discussion_r730640402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Build failed in Jenkins: OpenMeetings » Red5-server » Red5 :: Server #43

2021-10-18 Thread Apache Jenkins Server 
See 


Changes:

[github] Update red5.properties

[github] Refactored so accept is inside while loop


--
[...truncated 110.17 KB...]
[INFO] [loading modules/java.base/java/nio/channels/SeekableByteChannel.class]
[INFO] [loading modules/java.base/java/nio/channels/ByteChannel.class]
[INFO] [loading modules/java.base/java/nio/channels/ReadableByteChannel.class]
[INFO] [loading 
/home/jenkins/.m2/repository/org/apache/mina/mina-core/2.0.21/mina-core-2.0.21.jar(/org/apache/mina/core/polling/AbstractPollingIoConnector.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/apache/mina/mina-core/2.0.21/mina-core-2.0.21.jar(/org/apache/mina/core/service/AbstractIoConnector.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/apache/mina/mina-core/2.0.21/mina-core-2.0.21.jar(/org/apache/mina/core/service/IoService.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/apache/mina/mina-core/2.0.21/mina-core-2.0.21.jar(/org/apache/mina/core/session/IoSessionInitializer.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/apache/mina/mina-core/2.0.21/mina-core-2.0.21.jar(/org/apache/mina/core/future/IoFuture.class)]
[INFO] [wrote 

[INFO] [checking org.red5.logging.DerbyLogInterceptor]
[INFO] [loading modules/java.base/java/lang/InterruptedException.class]
[INFO] [loading modules/java.base/java/lang/StringBuffer.class]
[INFO] [loading modules/java.base/java/lang/AbstractStringBuilder.class]
[INFO] [wrote 

[INFO] [wrote 

[INFO] [checking org.red5.server.jmx.JMXUtil]
[INFO] [loading 
modules/java.management/javax/management/MBeanServerConnection.class]
[INFO] [loading modules/java.management/javax/management/DescriptorRead.class]
[INFO] [loading modules/java.management/javax/management/MBeanFeatureInfo.class]
[INFO] [loading 
modules/java.management/javax/management/MBeanParameterInfo.class]
[INFO] [loading modules/java.base/java/lang/NoSuchMethodException.class]
[INFO] [loading modules/java.base/java/lang/SecurityException.class]
[INFO] [loading modules/java.base/java/lang/reflect/Executable.class]
[INFO] [loading modules/java.base/java/lang/reflect/Member.class]
[INFO] [loading modules/java.base/java/lang/reflect/AccessibleObject.class]
[INFO] [loading modules/java.base/java/lang/InstantiationException.class]
[INFO] [loading modules/java.base/java/lang/IllegalAccessException.class]
[INFO] [loading 
modules/java.base/java/lang/reflect/InvocationTargetException.class]
[INFO] [loading 
modules/java.management/javax/management/NotCompliantMBeanException.class]
[INFO] [loading modules/java.management/javax/management/ObjectInstance.class]
[INFO] [loading 
modules/java.management/javax/management/InstanceNotFoundException.class]
[INFO] [loading 
modules/java.management/javax/management/OperationsException.class]
[INFO] [loading modules/java.management/javax/management/JMException.class]
[INFO] [loading 
modules/java.management/javax/management/IntrospectionException.class]
[INFO] [loading 
modules/java.management/javax/management/ReflectionException.class]
[INFO] [loading 
modules/java.management/javax/management/MalformedObjectNameException.class]
[INFO] [loading 
modules/java.management/javax/management/InstanceAlreadyExistsException.class]
[INFO] [loading 
modules/java.management/javax/management/MBeanRegistrationException.class]
[INFO] [loading modules/java.management/javax/management/MBeanException.class]
[INFO] [wrote 

[INFO] [checking org.red5.server.net.IConnectionEventQueue]
[INFO] [wrote 

[INFO] [checking org.red5.server.api.stream.support.DenyAllStreamAccess]
[INFO] [wrote 

[INFO] [checking org.red5.server.stream.ConsumerService]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/stream/OutputStream.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/net/rtmp/Channel.class)]
[INFO] [wrote

Build failed in Jenkins: OpenMeetings » Red5-server #43

2021-10-18 Thread Apache Jenkins Server 
See 


Changes:

[github] Update red5.properties

[github] Refactored so accept is inside while loop


--
[...truncated 114.27 KB...]
[INFO] [loading modules/java.base/java/lang/reflect/Member.class]
[INFO] [loading modules/java.base/java/lang/reflect/AccessibleObject.class]
[INFO] [loading modules/java.base/java/lang/InstantiationException.class]
[INFO] [loading modules/java.base/java/lang/IllegalAccessException.class]
[INFO] [loading 
modules/java.base/java/lang/reflect/InvocationTargetException.class]
[INFO] [loading 
modules/java.management/javax/management/NotCompliantMBeanException.class]
[INFO] [loading modules/java.management/javax/management/ObjectInstance.class]
[INFO] [loading 
modules/java.management/javax/management/InstanceNotFoundException.class]
[INFO] [loading 
modules/java.management/javax/management/OperationsException.class]
[INFO] [loading modules/java.management/javax/management/JMException.class]
[INFO] [loading 
modules/java.management/javax/management/IntrospectionException.class]
[INFO] [loading 
modules/java.management/javax/management/ReflectionException.class]
[INFO] [loading 
modules/java.management/javax/management/MalformedObjectNameException.class]
[INFO] [loading 
modules/java.management/javax/management/InstanceAlreadyExistsException.class]
[INFO] [loading 
modules/java.management/javax/management/MBeanRegistrationException.class]
[INFO] [loading modules/java.management/javax/management/MBeanException.class]
[INFO] [wrote 

[INFO] [checking org.red5.server.net.IConnectionEventQueue]
[INFO] [wrote 

[INFO] [checking org.red5.server.api.stream.support.DenyAllStreamAccess]
[INFO] [wrote 

[INFO] [checking org.red5.server.stream.ConsumerService]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/stream/OutputStream.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/net/rtmp/Channel.class)]
[INFO] [wrote 

[INFO] [checking org.red5.server.net.rtmps.RTMPSIoFilter]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/jmx/mxbeans/RTMPMinaConnectionMXBean.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/jmx/mxbeans/RTMPConnectionMXBean.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/net/rtmpe/EncryptedWriteRequest.class)]
[INFO] [checking org.red5.server.net.rtmpe.RTMPEIoFilter]
[INFO] [wrote 

[INFO] [wrote 

[INFO] [checking org.red5.server.persistence.FilePersistence]
[INFO] [loading 
/home/jenkins/.m2/repository/org/springframework/spring-core/5.3.2/spring-core-5.3.2.jar(/org/springframework/core/io/AbstractFileResolvingResource.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/springframework/spring-core/5.3.2/spring-core-5.3.2.jar(/org/springframework/core/io/AbstractResource.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/springframework/spring-core/5.3.2/spring-core-5.3.2.jar(/org/springframework/core/io/ContextResource.class)]
[INFO] [loading modules/java.base/java/util/AbstractQueue.class]
[INFO] [wrote 

[INFO] [wrote 

[INFO] [checking org.red5.server.net.rtmpt.BaseRTMPTConnection]
[INFO] [loading modules/java.base/java/lang/IndexOutOfBoundsException.class]
[INFO] [loading modules/java.base/java/util/concurrent/BlockingQueue.class]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-1.2.8.jar(/org/red5/server/net/rtmp/codec/IEventDecoder.class)]
[INFO] [loading 
/home/jenkins/.m2/repository/org/red5/red5-server-common/1.2.8/red5-server-common-

Re: future of OM frontend

2021-10-18 Thread Maxim Solodovnik 
On Mon, 18 Oct 2021 at 03:13, seba.wag...@gmail.com 
wrote:

> If it's just JS + CSS changes you an update the files in a running
> openmeetings server using those scripts:
>
> https://openmeetings.apache.org/BuildInstructions.html#update-javascript-and-css-at-runtime
>
> This will take ~10seconds + refresh the browser. Compared to 2-3 minutes to
> do a rebuild and then restart the server.
>
> However it won't work if you happen to need to update any of the HTML
> files.
>

I prefer to restart
let me do some coffee and think a little bit :)


>
> Thanks
> Seb
>
> Sebastian Wagner
> Director Arrakeen Solutions, OM-Hosting.com
> http://arrakeen-solutions.co.nz/
> https://om-hosting.com - Cloud & Server Hosting for HTML5
> Video-Conferencing OpenMeetings
> <
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> >
> <
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> >
>
>
> On Mon, 18 Oct 2021 at 04:44, Maxim Solodovnik 
> wrote:
>
> > On Sun, 17 Oct 2021 at 05:04, seba.wag...@gmail.com <
> seba.wag...@gmail.com
> > >
> > wrote:
> >
> > > >
> > > > At my 5-7 years old laptop
> > > > "unpacked" build tooks 7-9 minutes
> > > > "quick" build tooks 01:01 minute
> > >
> > > You are missing that it's not only the build time. You also need to
> > restart
> > > the server. Which is another 1-2mins. And you need to re-login +
> navigate
> > > to the place where you were before. Which depending on the scenario can
> > be
> > > even more complicated.
> > >
> >
> > I'm using "Remember login" option (different browsers - different users)
> > And links for the "area of test" like you can go directly to room
> > via `#room/5` hash
> >
> > The startup time can also be reduced by using
> > `-Djava.security.egd=file:/dev/./urandom`
> >
> > Will try to commit some code and re-check my memories on this :)
> >
> > >
> > > Well, I always thought it is impossible to create a PWA out of a server
> > > > side based web application
> > > > Can you share PoC?
> > >
> > > Will do PR shortly. I wouldn't call it a PWA. It's basically a fancy
> > > bookmark to the home screen. With the ability to have an icon + name +
> > > splash screen + pre-configured browser settings (hide nav bar). Not
> using
> > > any of the other PWA features like offline mode or anything. You can do
> > > that with any website. How much it uses "pwa" features just depends on
> > what
> > > the website provides in the manifest file.
> > >
> > > Thanks,
> > > Seb
> > >
> > > Sebastian Wagner
> > > Director Arrakeen Solutions, OM-Hosting.com
> > > http://arrakeen-solutions.co.nz/
> > > https://om-hosting.com - Cloud & Server Hosting for HTML5
> > > Video-Conferencing OpenMeetings
> > > <
> > >
> >
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> > > >
> > > <
> > >
> >
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> > > >
> > >
> > >
> > > On Sat, 16 Oct 2021 at 05:23, Maxim Solodovnik 
> > > wrote:
> > >
> > > > On Wed, 13 Oct 2021 at 04:49, seba.wag...@gmail.com <
> > > seba.wag...@gmail.com
> > > > >
> > > > wrote:
> > > >
> > > > > OFFTOPIC: I don't really like webpack-and-friends, it's output is
> > often
> > > > > unpredictable and hard to debug.
> > > > > Additionally I have difficulties to set it up to do what I need
> > > > > This is why I'm trying to find something that "just works" and
> > produces
> > > > no
> > > > > damage :)
> > > > >
> > > > > Your offtopic sounds more like a rant :)
> > > > >
> > > >
> > > > I would say "grumbling"  :))
> > > >
> > > >
> > > > > webpack-and-friends, it's output is often unpredictable and hard to
> > > > debug.
> > > > > >
> > > > > Additionally I have difficulties to set it up to do what I need
> > > > >
> > > > > => Actually I mostly used webpack just during development. Not when
> > > > > productionising. During development you can use webpack to start a
> > task
> > > > > which enables you to reload the JS+HTML while in a page. E.g. in
> > > > > OpenMeetings changing the HTML takes around 3minutes, cause you
> need
> > to
> > > > > restart the entire server + navigate back to where you were in a
> > > browser.
> > > > > See: https://webpack.js.org/configuration/dev-server/
> > > > >
> > > > > This greatly improves the development cycle, it cuts it down to
> > seconds
> > > > > what previously took minutes.
> > > > >
> > > >
> > > > At my 5-7 years old laptop
> > > > "unpacked" build tooks 7-9 minutes
> > > > "quick" build tooks 01:01 minute
> > > >
> > > > not too much :)))
> > > > the number can be lower, for whatever reason site is generated even
> if
> > `
> > > > maven.site.skip` is passed :(
> > > >
> > > >
> > > > > => Unfortunately it won't be possible to integrate this into
> > > OpenMeetings
> > > > > for now. Because it won't work with Apache Wicket.
> > > > >
> > > > > It seems like you are putting all of those different tools and
> > > > technologies
> > > >

Re: Updated mobile viewports to make icons and buttons clickable on mobile device in portrait mode

2021-10-18 Thread Maxim Solodovnik 
Now I understand :(
OK let it be

But we can help our users
We can write _simple_ script to generate all those images using ImageMagic
(which is our pre-requisite)
WDYT?

On Mon, 18 Oct 2021 at 08:57, seba.wag...@gmail.com 
wrote:

> >
> > Lot's of our users (all of them) has their own icons
>
> => We can update the docs on how to customise those icons. It is not hard,
> it's just not easy to automate.
>
>
> > I doubt _we require_ these icons :(
> > I see nothing so special in ios
> > And I believe there should some sort of fallback
>
> Manifest file uses only 2 images
>
> => iOS does not use the icons from the manifest file. It uses the  > tags from inside the html file.
> => Most of those icons are the "splash" screen for iOS, not the actual home
> screen icon.
>
> All these added images are no more than a favicons (including those
> > listed in manifest)
> > One svg can provide substitute fir all of them :)
>
> => In fact all those images are generated from a single SVG file.
> But unfortunately Android/iOS does not support SVG for home screen icons
> and preview icons.
> And also iOS does not support it for the splash screen. So it needs the
> images pre-rendered.
>
> We can provide some instructions on how to update the icons for
> customisation. Like I say, it's not hard, it is just not that easy to
> automate (and reference a single SVG as you suggested for example).
>
> Thanks
> Sebastian
>
> Sebastian Wagner
> Director Arrakeen Solutions, OM-Hosting.com
> http://arrakeen-solutions.co.nz/
> https://om-hosting.com - Cloud & Server Hosting for HTML5
> Video-Conferencing OpenMeetings
> <
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> >
> <
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> >
>
>
> On Mon, 18 Oct 2021 at 14:40, Maxim Solodovnik 
> wrote:
>
> > from mobile (sorry for typos ;)
> >
> >
> > On Mon, Oct 18, 2021, 03:23 seba.wag...@gmail.com  >
> > wrote:
> >
> > > >
> > > > I would add 30 new icons I believe this is too much :(
> > >
> > > =>They are generated from the same icon, see:
> > > https://github.com/onderceylan/pwa-asset-generator
> > > But I doubt anybody needs to do that again. Unless OpenMeetings changes
> > its
> > > icon/logo.
> > >
> >
> > Lot's of our users (all of them) has their own icons
> > So *every* om user should recreate those icons
> >
> >
> > > We require those icons because iOS requires different icons
> pre-rendered
> > in
> > > different screen resolutions. Because iOS is special :)
> > >
> >
> > I doubt _we require_ these icons :(
> > I see nothing so special in ios
> > And I believe there should some sort of fallback
> >
> > Manifest file uses only 2 images
> >
> > But also it's common in Mobile development to require images in different
> > > screen resolutions pre-compiled.
> > >
> > > I would modify favicon to be SVG
> > >
> > > => I did not change the favicon. The Favicon declaration has been the
> > same
> > > since 3 years ago.
> > >
> > >
> >
> https://github.com/apache/openmeetings/blame/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.html#L55
> >
> >
> > All these added images are no more than a favicons (including those
> listed
> > in manifest)
> > One svg can provide substitute fir all of them :)
> >
> >
> > >
> > > Thanks
> > > Sebastian
> > >
> > > Sebastian Wagner
> > > Director Arrakeen Solutions, OM-Hosting.com
> > > http://arrakeen-solutions.co.nz/
> > > https://om-hosting.com - Cloud & Server Hosting for HTML5
> > > Video-Conferencing OpenMeetings
> > > <
> > >
> >
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> > > >
> > > <
> > >
> >
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> > > >
> > >
> > >
> > > On Mon, 18 Oct 2021 at 04:40, Maxim Solodovnik 
> > > wrote:
> > >
> > > > Just have added some review comments
> > > >
> > > > The code is very compact
> > > > And I like the idea of using InfoWebService for customizing manifest
> :)
> > > >
> > > > I would add 30 new icons
> > > > I believe this is too much :(
> > > > I would modify favicon to be SVG
> > > >
> > > >
> > >
> >
> https://medium.com/swlh/are-you-using-svg-favicons-yet-a-guide-for-modern-browsers-836a6aace3df
> > > >
> > > >
> > > > On Sun, 17 Oct 2021 at 07:03, seba.wag...@gmail.com <
> > > seba.wag...@gmail.com
> > > > >
> > > > wrote:
> > > >
> > > > > Done. I've added some details and screenshots in the PR and linked
> > wiki
> > > > > page. It's actually quite a small PR part from adding a few icons
> in
> > > > > different resolutions.
> > > > >
> > > > > This adds so that when using the mobile browsers "Add to home
> screen"
> > > > > function:
> > > > >
> > > > >- Show a nice icon in the screens and on the mobile device
> > > > >- Show a nice name for the app in the mobile
> > > > >- Show a nice splash screen when opening OpenMeetings after
> saving
> > > to
> > > > >

[GitHub] [openmeetings] solomax commented on a change in pull request #164: OPENMEETINGS-2683 Add manifest file for adding icon, splash screen and browser settings for when adding to home screen on mo

2021-10-18 Thread GitBox 


solomax commented on a change in pull request #164:
URL: https://github.com/apache/openmeetings/pull/164#discussion_r730653161



##
File path: 
openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.html
##
@@ -23,6 +23,35 @@
 


+   
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

Review comment:
   well
   "iOS is very special" explain nothing :( unfortunately
   If it is not possible to use one vector image
   
   I would both
   
   1. Update documentation (I saw JIRA is created, thanks for this :)
   2. Add some script to generate all those images.
   
   Never like/understand these duplication :(((
   AFAIK Android reduces the size of APK by dropping redundant resources as 
soon as particular user push "Install" :))




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] solomax commented on a change in pull request #165: OPENMEETINGS-2692 Update manifest to get webapp name from base URL config.

2021-10-18 Thread GitBox 


solomax commented on a change in pull request #165:
URL: https://github.com/apache/openmeetings/pull/165#discussion_r730640402



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -248,6 +248,14 @@ public static String getBaseUrl() {
return baseUrl;
}
 
+   public static String getWebappPath() {
+   String webappPath = baseUrl;
+   if (webappPath.endsWith("/")) {
+   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   }
+   return webappPath.substring(webappPath.lastIndexOf("/") + 1);

Review comment:
   this method can be as simple as `new URL(baseUrl).getPath()` :)
   or `new URI(baseUrl).getPath()` :))




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org