Build failed in Jenkins: OpenMeetings ยป openmeetings #54

2021-10-19 Thread Apache Jenkins Server 
See 


Changes:

[Sebastian Wagner] OPENMEETINGS-2693 Update instructions on how to change 
Mobile Icons.

[Sebastian Wagner] OPENMEETINGS-2693 Update docs and convert to markdown.


--
[...truncated 309.67 KB...]
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
at 
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at 
org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at 
org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
at 
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at 
org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at 
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at 
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at 
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at

Re: [VOTE] Apache OpenMeetings 6.2.0 based on Release Candidate 2

2021-10-19 Thread seba.wag...@gmail.com 
>
> I believe all these points are non-blockers due to
> almost everything below is something new
> 6.2.0 intended to be bug-fix release (fixing serious issue at iPad )

Ok. Lets just vote and do that in 7.0.0

I would say this is something user can *guess* to do :)
> it will provide much more space

 Lets do landscape rotating user prompt in v7.0.0 (or 6.3.0)

This might be moved to network-testing-tool
> I doubt there is ready to use browser list we can use
> And there is definitely no browser+version list :(((

Lets do in v7.0.0 but I think this is really necessary. We don't need a
"exclusive" list. E.g. we can just check for Safari for a start where we
know v15.x is a minimum.
Also I'm thinking this "prompt" can be non blocking == Meaning if you have
an old browser you can still use it, you just need to click away the prompt.

Well
> OM is currently shipped with self-signed-HTTPS ready to use
> And It prompts user HTTPS is required
> And all documentation states HTTPS is required


> It is bad idea to drop HTTP just because it is the "right way" to set up
> front-end proxy
> (Like it currently set-up on all demo servers)

I'm not suggesting the "drop" HTTP.
I am suggesting to change the "default" redirect when you enter
http://myhost:port/ and redirect not only to /openmeetings but to https
And potentially when you arrive at "BasePage.html" to make sure it redirect
you to "HTTPS" in case you are not.
That is it.

That will not have an impact on any HTTPS/proxy. You can still run NGINX or
Apache mod_proxy to terminate SSL and have OpenMeetings run over HTTP/Non
SSL.
That will still work fine. All of the above are client side redirects
(meaning if the client detects they are on http they redirect to https).

Anyway, let me start voting on 6.2.0. And then we can address the above.

Thanks
Seb

Sebastian Wagner
Director Arrakeen Solutions, OM-Hosting.com
http://arrakeen-solutions.co.nz/
https://om-hosting.com - Cloud & Server Hosting for HTML5
Video-Conferencing OpenMeetings




On Wed, 20 Oct 2021 at 05:55, Maxim Solodovnik  wrote:

> On Sun, 17 Oct 2021 at 09:40, seba.wag...@gmail.com  >
> wrote:
>
> > There might be a few relatively small but impactful things to add to the
> > release:
> >
> >
> I believe all these points are non-blockers due to
> almost everything below is something new
> 6.2.0 intended to be bug-fix release (fixing serious issue at iPad )
>
>
> > *Prompt mobile browsers to use landscape mode *
> > I would add this only inside the conference room, not outside. Outside of
> > the conference room it's actually okay to be in portrait mode.
> > But inside the conference room portrait mode really just doesn't work.
> With
> > the viewport that I've added you can finally click on some of the icons
> > inside the conference room, but it's still un-usable. It just doesn't
> have
> > enough space on the screen in portrait mode.
> > So adding a simple and small prompt for users to suggest to rotate to
> > landscape mode will be good. And maybe only add that inside the
> conference
> > room as outside is actually okay.
> >
>
> I would say this is something user can *guess* to do :)
> it will provide much more space
>
>
> >
> > *Check for minimum browser versions, especially on mobile devices*
> > e.g. Safari we know is broken for webRTC if Safari version is smaller
> then
> > v15.x. I'm sure other browsers have similar minimum versions.
> > It will just otherwise lead to a lot of frustration or users give up on
> > OpenMeetings cause they don't understand that their problem is with their
> > browser. Not OpenMeetings. And in most scenarios this does not indicate
> > anything to users. It just silently breaks.
> >
> >
> This might be moved to network-testing-tool
> I doubt there is ready to use browser list we can use
> And there is definitely no browser+version list :(((
>
>
>
> > *Update initial check to redirect all users to HTTPS*
> > OpenMeetings really does not work without SSL/HTTPS.
> > Most of the HTML5/webRTC APIs require HTTPS. But also e.g. the
> > "Notification" API requires HTTPS (see
> > https://developer.mozilla.org/en-US/docs/Web/API/notification). So users
> > can not  watch a video conference. Nor publish mic/cam. And that is not
> > just "inside" the conference room. It looks increasingly difficult to
> > safeguard every possible scenario where a JS API requires HTTPS with an
> > additional pop up to prompt users.
> > I know we have some prompts, but I think you could just redirect on page
> > load of the main landing page to HTTPS. Really easy to fix. If somebody
> > doesn't like that they can (a) just accept the self signed certificate
> (b)
> > deep link to another page. This could be also easily made configurable
> (if
> > required).
> >
>
> Well
> OM is currently shipped with self-signed-HTTPS ready to use

[GitHub] [openmeetings] sebawagner merged pull request #167: OPENMEETINGS-2693 Update instructions on how to change Mobile Icons.

2021-10-19 Thread GitBox 


sebawagner merged pull request #167:
URL: https://github.com/apache/openmeetings/pull/167


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #167: OPENMEETINGS-2693 Update instructions on how to change Mobile Icons.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #167:
URL: https://github.com/apache/openmeetings/pull/167#discussion_r732409021



##
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##
@@ -0,0 +1,45 @@
+

Review comment:
   done

##
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##
@@ -0,0 +1,45 @@
+
+
+http://maven.apache.org/XDOC/2.0;
+   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation="http://maven.apache.org/XDOC/2.0 
http://maven.apache.org/xsd/xdoc-2.0.xsd;>
+   
+   Webapp Name / Path
+   Apache OpenMeetings 
Team
+   
+   
+   
+   If you want to set up your logo in Openmeetings 
header you can do the following:
+   
+   create your logo image as PNG 40px 
height
+   replace 
/opt/om/webapps/openmeetings/css/images/logo.png with your logo 
file
+   
+   
+   
+   This is available in OpenMeetings 6.2.0 or 7.0.0 and 
later

Review comment:
   I wasn't sure, changed to 6.2.0

##
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##
@@ -0,0 +1,45 @@
+
+
+http://maven.apache.org/XDOC/2.0;
+   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation="http://maven.apache.org/XDOC/2.0 
http://maven.apache.org/xsd/xdoc-2.0.xsd;>
+   
+   Webapp Name / Path
+   Apache OpenMeetings 
Team
+   
+   
+   
+   If you want to set up your logo in Openmeetings 
header you can do the following:
+   
+   create your logo image as PNG 40px 
height
+   replace 
/opt/om/webapps/openmeetings/css/images/logo.png with your logo 
file
+   
+   
+   
+   This is available in OpenMeetings 6.2.0 or 7.0.0 and 
later
+   First: create the mobile icons assets. This can 
be done via a script
+   This example is generating assets using https://github.com/onderceylan/pwa-asset-generator; 
target="_blank">https://github.com/onderceylan/pwa-asset-generator
+   
+   Install the generation script: npm install 
--global pwa-asset-generator

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732403113



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   > Sure, let it log :) I believe WARN without stacktrace would be 
sufficient :) `URI.create` shouldn't throw, but we shouldn't crash on bad user 
import :)))
   
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732402303



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -21,9 +21,16 @@
 import static org.apache.wicket.csp.CSPDirectiveSrcValue.SELF;
 import static org.apache.wicket.csp.CSPDirectiveSrcValue.STRICT_DYNAMIC;
 
+import java.net.URI;
+import java.net.URISyntaxException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.github.openjson.JSONObject;
 
 public class OpenmeetingsVariables {
+   private static final Logger log = 
LoggerFactory.getLogger(OpenmeetingsVariables.class);

Review comment:
   There is a try/catch block. That should log sth.
   
https://www.overops.com/blog/swallowed-exceptions-the-silent-killer-of-java-applications/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732402032



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   Updated to above syntax




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732401983



##
File path: 
openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/InfoWebService.java
##
@@ -106,7 +106,7 @@ public String getManifest() {
manifest.put("name", OpenmeetingsVariables.getApplicationName() 
+ " " + Version.getVersion());
manifest.put("short_name", 
OpenmeetingsVariables.getApplicationName() + " " + Version.getVersion());
manifest.put("description", "Openmeetings provides video 
conferencing, instant messaging, white board, collaborative document editing 
and other groupware tools.");
-   manifest.put("start_url", "/" + 
OpenmeetingsVariables.getWebappPath() + "/?pwa=true");
+   manifest.put("start_url",  
OpenmeetingsVariables.getWebappPath() + "?pwa=true");

Review comment:
   Updated to use URI.resolve




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732397491



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   also the constructor new URI will not compile without a try/catch block. 
Or re-throwing the exception.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732398683



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   I can refactor it a bit, but your proposal doesn't translate that easy 
into code. You not even using "baseURL" to construct the URI anymore. Some of 
those would just return the same string as passed into.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732398683



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   I can refactor it a bit, but your proposal doesn't translate that easy 
into code. You not even using "baseURL" anymore. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732397491



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   also the constructor new URI not compile without a try/catch block. Or 
re-throwing the exception.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] solomax commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


solomax commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732397258



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   Sure, let it log :)
   I believe WARN without stacktrace would be sufficient :)
   `URI.create` shouldn't throw, but we shouldn't crash on bad user import :)))
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732397029



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   silent exception / swallowing exceptions is not good. For various 
reasons:
   
https://www.overops.com/blog/swallowed-exceptions-the-silent-killer-of-java-applications/
   
   I think you should at least create a log if you catch an exception. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


sebawagner commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732396315



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   shouldn't it log something if there is an exception ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] solomax commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


solomax commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732016487



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   Sorry for the late response
   Tuesday is a bit crazy day :(((
   
   I've just played with `URI`s in `jshell`
   and here is what I propose :)))
   
   This method can be rewritten as
   ```
   private static URI getWebappPath(url) {
   return URI.create(new URI(url + "/").normalize().getPath());
   }
   
   public static URI getWebappPath() {
   try {
   return getWebappPath(url);
   } catch (URISyntaxException e) {
   return getWebappPath(DEFAULT_BASE_URL);
   }
   }
   ```
   
   this way the `URI` returned will always have trailing '/'
   
   UPDATE: `try-catch` added back, just in-case :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Apache OpenMeetings 6.2.0 based on Release Candidate 2

2021-10-19 Thread Maxim Solodovnik 
On Sun, 17 Oct 2021 at 09:40, seba.wag...@gmail.com 
wrote:

> There might be a few relatively small but impactful things to add to the
> release:
>
>
I believe all these points are non-blockers due to
almost everything below is something new
6.2.0 intended to be bug-fix release (fixing serious issue at iPad )


> *Prompt mobile browsers to use landscape mode *
> I would add this only inside the conference room, not outside. Outside of
> the conference room it's actually okay to be in portrait mode.
> But inside the conference room portrait mode really just doesn't work. With
> the viewport that I've added you can finally click on some of the icons
> inside the conference room, but it's still un-usable. It just doesn't have
> enough space on the screen in portrait mode.
> So adding a simple and small prompt for users to suggest to rotate to
> landscape mode will be good. And maybe only add that inside the conference
> room as outside is actually okay.
>

I would say this is something user can *guess* to do :)
it will provide much more space


>
> *Check for minimum browser versions, especially on mobile devices*
> e.g. Safari we know is broken for webRTC if Safari version is smaller then
> v15.x. I'm sure other browsers have similar minimum versions.
> It will just otherwise lead to a lot of frustration or users give up on
> OpenMeetings cause they don't understand that their problem is with their
> browser. Not OpenMeetings. And in most scenarios this does not indicate
> anything to users. It just silently breaks.
>
>
This might be moved to network-testing-tool
I doubt there is ready to use browser list we can use
And there is definitely no browser+version list :(((



> *Update initial check to redirect all users to HTTPS*
> OpenMeetings really does not work without SSL/HTTPS.
> Most of the HTML5/webRTC APIs require HTTPS. But also e.g. the
> "Notification" API requires HTTPS (see
> https://developer.mozilla.org/en-US/docs/Web/API/notification). So users
> can not  watch a video conference. Nor publish mic/cam. And that is not
> just "inside" the conference room. It looks increasingly difficult to
> safeguard every possible scenario where a JS API requires HTTPS with an
> additional pop up to prompt users.
> I know we have some prompts, but I think you could just redirect on page
> load of the main landing page to HTTPS. Really easy to fix. If somebody
> doesn't like that they can (a) just accept the self signed certificate (b)
> deep link to another page. This could be also easily made configurable (if
> required).
>

Well
OM is currently shipped with self-signed-HTTPS ready to use
And It prompts user HTTPS is required
And all documentation states HTTPS is required

It is bad idea to drop HTTP just because it is the "right way" to set up
front-end proxy
(Like it currently set-up on all demo servers)


>
> I think the above items would be useful things to do before releasing. I
> can convert that to Jira's. But I think not fixing those makes it very
> difficult for non-expert users to understand what is broken. I think the
> majority of users will think OpenMeetings is broken. While actually it's a
> limitation with their setup/environment. And I think most of those users
> will just stop using OpenMeetings. They do not complain to the mailing list
> (fortunately or unfortunately :) ). But they just give up and evaluate
> other software/applications.
>
> So I think those could be minor fixes. But may have a big impact.
>
> Thanks
> Seb
>
> Sebastian Wagner
> Director Arrakeen Solutions, OM-Hosting.com
> http://arrakeen-solutions.co.nz/
> https://om-hosting.com - Cloud & Server Hosting for HTML5
> Video-Conferencing OpenMeetings
> <
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> >
> <
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> >
>
>
> On Mon, 4 Oct 2021 at 18:47, Alvaro  wrote:
>
> > Good morning,
> >
> > Thanks Maxim, Sebastian. Then could you please
> > tell me when the definitive release 6.2.0 will
> > be ready?
> > I need to know it to build the live iso with the
> > right file release.
> >
> > Thanks again.
> >
> > Alvaro
> >
> >
> > 
> >
> > On Mon, 4 Oct 2021 15:42:06 +1300
> > "seba.wag...@gmail.com"  wrote:
> >
> > > >
> > > > My daughter was sick, now she is much better :)
> > >
> > > Hope things get better quickly!
> > >
> > > The fix is as easy
> > >
> > > ok thx let me try that and spin up another demo server with the fix to
> > test
> > > on an iOS device
> > >
> > > Thanks
> > > Seb
> > >
> > > Sebastian Wagner
> > > Director Arrakeen Solutions, OM-Hosting.com
> > > http://arrakeen-solutions.co.nz/
> > > https://om-hosting.com - Cloud & Server Hosting for HTML5
> > > Video-Conferencing OpenMeetings
> > > <
> >
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> > >
> > > <
> >
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url

Re: Updated mobile viewports to make icons and buttons clickable on mobile device in portrait mode

2021-10-19 Thread Maxim Solodovnik 
wrote some comments in PRs :)
Hopefully `npm-way` will be welcomed by the community :)

On Tue, 19 Oct 2021 at 08:48, seba.wag...@gmail.com 
wrote:

> Yeah let me update the docs and you can review
>
> We can write _simple_ script to generate all those images using ImageMagic
>
> There is actually an easier way to generate the icons, snippets and in a
> single command. I think easier at least from my perspective.
>
> Let me update the docs.
>
> Thanks
> Sebastian
>
> Sebastian Wagner
> Director Arrakeen Solutions, OM-Hosting.com
> http://arrakeen-solutions.co.nz/
> https://om-hosting.com - Cloud & Server Hosting for HTML5
> Video-Conferencing OpenMeetings
> <
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> >
> <
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> >
>
>
> On Mon, 18 Oct 2021 at 21:12, Maxim Solodovnik 
> wrote:
>
> > Now I understand :(
> > OK let it be
> >
> > But we can help our users
> > We can write _simple_ script to generate all those images using
> ImageMagic
> > (which is our pre-requisite)
> > WDYT?
> >
> > On Mon, 18 Oct 2021 at 08:57, seba.wag...@gmail.com <
> seba.wag...@gmail.com
> > >
> > wrote:
> >
> > > >
> > > > Lot's of our users (all of them) has their own icons
> > >
> > > => We can update the docs on how to customise those icons. It is not
> > hard,
> > > it's just not easy to automate.
> > >
> > >
> > > > I doubt _we require_ these icons :(
> > > > I see nothing so special in ios
> > > > And I believe there should some sort of fallback
> > >
> > > Manifest file uses only 2 images
> > >
> > > => iOS does not use the icons from the manifest file. It uses the  > ...
> > > > tags from inside the html file.
> > > => Most of those icons are the "splash" screen for iOS, not the actual
> > home
> > > screen icon.
> > >
> > > All these added images are no more than a favicons (including those
> > > > listed in manifest)
> > > > One svg can provide substitute fir all of them :)
> > >
> > > => In fact all those images are generated from a single SVG file.
> > > But unfortunately Android/iOS does not support SVG for home screen
> icons
> > > and preview icons.
> > > And also iOS does not support it for the splash screen. So it needs the
> > > images pre-rendered.
> > >
> > > We can provide some instructions on how to update the icons for
> > > customisation. Like I say, it's not hard, it is just not that easy to
> > > automate (and reference a single SVG as you suggested for example).
> > >
> > > Thanks
> > > Sebastian
> > >
> > > Sebastian Wagner
> > > Director Arrakeen Solutions, OM-Hosting.com
> > > http://arrakeen-solutions.co.nz/
> > > https://om-hosting.com - Cloud & Server Hosting for HTML5
> > > Video-Conferencing OpenMeetings
> > > <
> > >
> >
> https://www.youracclaim.com/badges/da4e8828-743d-4968-af6f-49033f10d60a/public_url
> > > >
> > > <
> > >
> >
> https://www.youracclaim.com/badges/b7e709c6-aa87-4b02-9faf-099038475e36/public_url
> > > >
> > >
> > >
> > > On Mon, 18 Oct 2021 at 14:40, Maxim Solodovnik 
> > > wrote:
> > >
> > > > from mobile (sorry for typos ;)
> > > >
> > > >
> > > > On Mon, Oct 18, 2021, 03:23 seba.wag...@gmail.com <
> > seba.wag...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > >
> > > > > > I would add 30 new icons I believe this is too much :(
> > > > >
> > > > > =>They are generated from the same icon, see:
> > > > > https://github.com/onderceylan/pwa-asset-generator
> > > > > But I doubt anybody needs to do that again. Unless OpenMeetings
> > changes
> > > > its
> > > > > icon/logo.
> > > > >
> > > >
> > > > Lot's of our users (all of them) has their own icons
> > > > So *every* om user should recreate those icons
> > > >
> > > >
> > > > > We require those icons because iOS requires different icons
> > > pre-rendered
> > > > in
> > > > > different screen resolutions. Because iOS is special :)
> > > > >
> > > >
> > > > I doubt _we require_ these icons :(
> > > > I see nothing so special in ios
> > > > And I believe there should some sort of fallback
> > > >
> > > > Manifest file uses only 2 images
> > > >
> > > > But also it's common in Mobile development to require images in
> > different
> > > > > screen resolutions pre-compiled.
> > > > >
> > > > > I would modify favicon to be SVG
> > > > >
> > > > > => I did not change the favicon. The Favicon declaration has been
> the
> > > > same
> > > > > since 3 years ago.
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/openmeetings/blame/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/BasePage.html#L55
> > > >
> > > >
> > > > All these added images are no more than a favicons (including those
> > > listed
> > > > in manifest)
> > > > One svg can provide substitute fir all of them :)
> > > >
> > > >
> > > > >
> > > > > Thanks
> > > > > Sebastian
> > > > >
> > > > > Sebastian Wagner
> > > > > Director Arrakeen Solutions, OM-Hosting.com
> > > > > http://arrakeen-solutions.co.nz/
> > >

[GitHub] [openmeetings] solomax commented on a change in pull request #167: OPENMEETINGS-2693 Update instructions on how to change Mobile Icons.

2021-10-19 Thread GitBox 


solomax commented on a change in pull request #167:
URL: https://github.com/apache/openmeetings/pull/167#discussion_r732022351



##
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##
@@ -0,0 +1,45 @@
+

Review comment:
   Maybe It would be better to add this one as 
`openmeetings-server/src/site/markdown/LogoAndIcons.md`
   It would be easier to maintain and maybe contribute :))

##
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##
@@ -0,0 +1,45 @@
+
+
+http://maven.apache.org/XDOC/2.0;
+   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation="http://maven.apache.org/XDOC/2.0 
http://maven.apache.org/xsd/xdoc-2.0.xsd;>
+   
+   Webapp Name / Path
+   Apache OpenMeetings 
Team
+   
+   
+   
+   If you want to set up your logo in Openmeetings 
header you can do the following:
+   
+   create your logo image as PNG 40px 
height
+   replace 
/opt/om/webapps/openmeetings/css/images/logo.png with your logo 
file
+   
+   
+   
+   This is available in OpenMeetings 6.2.0 or 7.0.0 and 
later

Review comment:
   I guess there is no need to mention `7.0.0` here

##
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##
@@ -0,0 +1,45 @@
+
+
+http://maven.apache.org/XDOC/2.0;
+   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation="http://maven.apache.org/XDOC/2.0 
http://maven.apache.org/xsd/xdoc-2.0.xsd;>
+   
+   Webapp Name / Path
+   Apache OpenMeetings 
Team
+   
+   
+   
+   If you want to set up your logo in Openmeetings 
header you can do the following:
+   
+   create your logo image as PNG 40px 
height
+   replace 
/opt/om/webapps/openmeetings/css/images/logo.png with your logo 
file
+   
+   
+   
+   This is available in OpenMeetings 6.2.0 or 7.0.0 and 
later
+   First: create the mobile icons assets. This can 
be done via a script
+   This example is generating assets using https://github.com/onderceylan/pwa-asset-generator; 
target="_blank">https://github.com/onderceylan/pwa-asset-generator
+   
+   Install the generation script: npm install 
--global pwa-asset-generator

Review comment:
   I believe commands need to be formatted as commands 
   `` OR `` for xdoc 
   wrap with ` for MD




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] solomax commented on a change in pull request #166: OPENMEETINGS-2692 Update review comments on parsing path element.

2021-10-19 Thread GitBox 


solomax commented on a change in pull request #166:
URL: https://github.com/apache/openmeetings/pull/166#discussion_r732013739



##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -21,9 +21,16 @@
 import static org.apache.wicket.csp.CSPDirectiveSrcValue.SELF;
 import static org.apache.wicket.csp.CSPDirectiveSrcValue.STRICT_DYNAMIC;
 
+import java.net.URI;
+import java.net.URISyntaxException;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.github.openjson.JSONObject;
 
 public class OpenmeetingsVariables {
+   private static final Logger log = 
LoggerFactory.getLogger(OpenmeetingsVariables.class);

Review comment:
   this can be dropped

##
File path: 
openmeetings-util/src/main/java/org/apache/openmeetings/util/OpenmeetingsVariables.java
##
@@ -249,11 +256,12 @@ public static String getBaseUrl() {
}
 
public static String getWebappPath() {
-   String webappPath = baseUrl;
-   if (webappPath.endsWith("/")) {
-   webappPath = webappPath.substring(0, 
webappPath.length() - 1);
+   try {

Review comment:
   Sorry for the late response
   Tuesday is a bit crazy day :(((
   
   I've just played with `URI`s in `jshell`
   and here is what I propose :)))
   
   This method can be rewritten as
   ```
   public static URI getWebappPath() {
   return URI.create(URI.create(baseUrl + "/").normalize().getPath());
   }
   ```
   
   this way the `URI` returned will always have trailing '/'

##
File path: 
openmeetings-webservice/src/main/java/org/apache/openmeetings/webservice/InfoWebService.java
##
@@ -106,7 +106,7 @@ public String getManifest() {
manifest.put("name", OpenmeetingsVariables.getApplicationName() 
+ " " + Version.getVersion());
manifest.put("short_name", 
OpenmeetingsVariables.getApplicationName() + " " + Version.getVersion());
manifest.put("description", "Openmeetings provides video 
conferencing, instant messaging, white board, collaborative document editing 
and other groupware tools.");
-   manifest.put("start_url", "/" + 
OpenmeetingsVariables.getWebappPath() + "/?pwa=true");
+   manifest.put("start_url",  
OpenmeetingsVariables.getWebappPath() + "?pwa=true");

Review comment:
   here you can do something like:
   
   ```
   URI omPath = OpenmeetingsVariables.getWebappPath(); // to avoid 
recalculations
   
   then
   
   omPath.resolve("?pwa=true")
   
   omPath.resolve("images/icons/" + name)
   OR 
   omPath.resolve("images/icons/").resolve(name)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [openmeetings] sebawagner opened a new pull request #167: OPENMEETINGS-2693 Update instructions on how to change Mobile Icons.

2021-10-19 Thread GitBox 


sebawagner opened a new pull request #167:
URL: https://github.com/apache/openmeetings/pull/167


   Updates instructions on how to generate mobile icons.
   Move logo and icon into one page, and under "UI" section of configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org