solomax commented on a change in pull request #167:
URL: https://github.com/apache/openmeetings/pull/167#discussion_r732022351
##########
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##########
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
Maybe It would be better to add this one as
`openmeetings-server/src/site/markdown/LogoAndIcons.md`
It would be easier to maintain and maybe contribute :))
##########
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##########
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+<document xmlns="http://maven.apache.org/XDOC/2.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/XDOC/2.0
http://maven.apache.org/xsd/xdoc-2.0.xsd";>
+ <properties>
+ <title>Webapp Name / Path</title>
+ <author email="dev@openmeetings.apache.org">Apache OpenMeetings
Team</author>
+ </properties>
+ <body>
+ <section name="Customize Openmeetings logo">
+ <p>If you want to set up your logo in Openmeetings
header you can do the following:</p>
+ <ol>
+ <li>create your logo image as PNG 40px
height</li>
+ <li>replace
<tt>/opt/om/webapps/openmeetings/css/images/logo.png</tt> with your logo
file</li>
+ </ol>
+ </section>
+ <section name="Customize Openmeetings mobile icons">
+ <i>This is available in OpenMeetings 6.2.0 or 7.0.0 and
later</i>
Review comment:
I guess there is no need to mention `7.0.0` here
##########
File path: openmeetings-server/src/site/xdoc/LogoAndIcons.xml
##########
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+<document xmlns="http://maven.apache.org/XDOC/2.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/XDOC/2.0
http://maven.apache.org/xsd/xdoc-2.0.xsd";>
+ <properties>
+ <title>Webapp Name / Path</title>
+ <author email="dev@openmeetings.apache.org">Apache OpenMeetings
Team</author>
+ </properties>
+ <body>
+ <section name="Customize Openmeetings logo">
+ <p>If you want to set up your logo in Openmeetings
header you can do the following:</p>
+ <ol>
+ <li>create your logo image as PNG 40px
height</li>
+ <li>replace
<tt>/opt/om/webapps/openmeetings/css/images/logo.png</tt> with your logo
file</li>
+ </ol>
+ </section>
+ <section name="Customize Openmeetings mobile icons">
+ <i>This is available in OpenMeetings 6.2.0 or 7.0.0 and
later</i>
+ <p><b>First: create the mobile icons assets. This can
be done via a script</b></p>
+ <p><i>This example is generating assets using <a
href="https://github.com/onderceylan/pwa-asset-generator";
target="_blank">https://github.com/onderceylan/pwa-asset-generator</a></i></p>
+ <ol>
+ <li>Install the generation script: npm install
--global pwa-asset-generator</li>
Review comment:
I believe commands need to be formatted as commands
`<source>` OR `<tt>` for xdoc
wrap with ` for MD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openmeetings.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
