Re: Re[8]: Google Closure Whiteboard
Hi All, I have re-factored the whiteboard code to fit in to WicketStuff repo and got the committership there. Will let you know after committing the whiteboard there. Thanks! On Wed, Aug 21, 2013 at 10:55 AM, Andun Sameera andun...@gmail.com wrote: I would like to go for the WicketStuff option also. Will change the code accordingly. Also I will work on the above two features with the help of Andrey. Thanks! On Wed, Aug 21, 2013 at 7:57 AM, Maxim Solodovnik solomax...@gmail.comwrote: Hello Andun, I'll try to review the code this week. If this WB is not using wicket-jquery-ui I believe it should be integrated into OM or added to the wicketstuff. The second option is preferable since this component will be available for wider community, but it should be selected only if you going to maintain it. According to functionality: AFAIK 2 features are still missing: add clipart, add document + change page On Wed, Aug 21, 2013 at 9:21 AM, Andun Sameera andun...@gmail.comwrote: Hi All, This is the current status of the whiteboard, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart Since we are in the final stage of the GSOC what are the other requirements which should focus on ? Like documentation etc. Also currently whteboard is plugin of wicket-jquery-ui(But we are not using any wicket-jquery-ui thing). So are we keeping like that or are we moving? Thanks! On Sat, Aug 3, 2013 at 9:43 AM, Andun Sameera andun...@gmail.comwrote: I have created the Jira Issues! @Andrey, I think I can implement Undo, Save Content features quickly. Please instruct me to do those. Also for other things, I need your help a lot. Currently I am looking at possibikites to integrate these features to your code! Thanks! On Sat, Aug 3, 2013 at 2:48 AM, Maxim Solodovnik solomax...@gmail.comwrote: Draw Underline is just draw thick line, I believe it can easily be merged in draw line functionality (only line thickness should be configurable) @Andun sure please add new issues, Ill connect them to the https://issues.apache.org/jira/browse/OPENMEETINGS-551 On Fri, Aug 2, 2013 at 8:04 PM, Andun Sameera andun...@gmail.comwrote: Hi Maxim, I will add at. Please instruct me to proceed. @Andrey Can you give me some clues and help to implement the easy to-dos first! Thanks! On Fri, Aug 2, 2013 at 6:15 PM, Bogdanov Andrey ba...@mail.ruwrote: Most of requested features could be easily implemented, but some of them need discussion - I don't really inderstand what is needed. For example, I don't remeber what is Draw Underline in old whiteboard. I think we shouldn't litter dev-list with all these discussions - the better way is to create Jira Issues for all requested features and discuss there. Пятница, 2 августа 2013, 18:48 +07:00 от Maxim Solodovnik solomax...@gmail.com: Thanks! please also include What is currently missing is the ability to limit WB in size (currently you can scroll endlessly to any direction) I believe there are some more features from my previous email, this is to priority! On Fri, Aug 2, 2013 at 5:53 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, Here is the feature table you requested, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart I think the Save Content part can be Easily Implemented. Also the Undo part. For other parts I have to get the help of Andrey. Thanks! On Fri, Jul 26, 2013 at 9:36 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, The evaluation will begin on 29th. I will fil the form on that day. Is there any comments or instructions to proceed forward? Thanks! On Mon, Jul 22, 2013 at 8:11 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Thanks Maxim! On Jul 22, 2013 7:51 AM, Maxim Solodovnik solomax...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com wrote: Hello Andun, I'll double check the docs, As I can see right now you should fill you evaluation form in Melange. I'll try to review your code today. And I guess we need to schedule meeting to discuss what should be done next On Mon, Jul 22, 2013 at 1:59 AM, Andun Sameera
Re: Re[8]: Google Closure Whiteboard
Hi Maxim, I have re-factored the code and committed that. Thanks! On Mon, Aug 26, 2013 at 6:11 PM, Maxim Solodovnik solomax...@gmail.comwrote: I guess I'll do review in a form of the patch. On Mon, Aug 26, 2013 at 7:37 PM, Maxim Solodovnik solomax...@gmail.comwrote: Hello Andun, I'm afraid the code you have contributed to wickedstuff should be changed ASAP: Top package: /src/main/java/com/googlecode/wicket/jquery/ui/plugins/whiteboard Should be changed to:/src/main/java/org/wicketstuff/whiteboard I'm going to review the code right now On Mon, Aug 26, 2013 at 7:03 PM, Andun Sameera andun...@gmail.comwrote: Hi All, I have re-factored the whiteboard code to fit in to WicketStuff repo and got the committership there. Will let you know after committing the whiteboard there. Thanks! On Wed, Aug 21, 2013 at 10:55 AM, Andun Sameera andun...@gmail.comwrote: I would like to go for the WicketStuff option also. Will change the code accordingly. Also I will work on the above two features with the help of Andrey. Thanks! On Wed, Aug 21, 2013 at 7:57 AM, Maxim Solodovnik solomax...@gmail.com wrote: Hello Andun, I'll try to review the code this week. If this WB is not using wicket-jquery-ui I believe it should be integrated into OM or added to the wicketstuff. The second option is preferable since this component will be available for wider community, but it should be selected only if you going to maintain it. According to functionality: AFAIK 2 features are still missing: add clipart, add document + change page On Wed, Aug 21, 2013 at 9:21 AM, Andun Sameera andun...@gmail.comwrote: Hi All, This is the current status of the whiteboard, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart Since we are in the final stage of the GSOC what are the other requirements which should focus on ? Like documentation etc. Also currently whteboard is plugin of wicket-jquery-ui(But we are not using any wicket-jquery-ui thing). So are we keeping like that or are we moving? Thanks! On Sat, Aug 3, 2013 at 9:43 AM, Andun Sameera andun...@gmail.comwrote: I have created the Jira Issues! @Andrey, I think I can implement Undo, Save Content features quickly. Please instruct me to do those. Also for other things, I need your help a lot. Currently I am looking at possibikites to integrate these features to your code! Thanks! On Sat, Aug 3, 2013 at 2:48 AM, Maxim Solodovnik solomax...@gmail.com wrote: Draw Underline is just draw thick line, I believe it can easily be merged in draw line functionality (only line thickness should be configurable) @Andun sure please add new issues, Ill connect them to the https://issues.apache.org/jira/browse/OPENMEETINGS-551 On Fri, Aug 2, 2013 at 8:04 PM, Andun Sameera andun...@gmail.comwrote: Hi Maxim, I will add at. Please instruct me to proceed. @Andrey Can you give me some clues and help to implement the easy to-dos first! Thanks! On Fri, Aug 2, 2013 at 6:15 PM, Bogdanov Andrey ba...@mail.ruwrote: Most of requested features could be easily implemented, but some of them need discussion - I don't really inderstand what is needed. For example, I don't remeber what is Draw Underline in old whiteboard. I think we shouldn't litter dev-list with all these discussions - the better way is to create Jira Issues for all requested features and discuss there. Пятница, 2 августа 2013, 18:48 +07:00 от Maxim Solodovnik solomax...@gmail.com: Thanks! please also include What is currently missing is the ability to limit WB in size (currently you can scroll endlessly to any direction) I believe there are some more features from my previous email, this is to priority! On Fri, Aug 2, 2013 at 5:53 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, Here is the feature table you requested, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart I think the Save Content part can be Easily Implemented. Also the Undo part. For other parts I have to get the help of Andrey. Thanks! On Fri, Jul 26, 2013 at 9:36 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, The evaluation will begin on 29th. I will fil the form on that day. Is there any comments or instructions to proceed
Re: Re[8]: Google Closure Whiteboard
I would like to go for the WicketStuff option also. Will change the code accordingly. Also I will work on the above two features with the help of Andrey. Thanks! On Wed, Aug 21, 2013 at 7:57 AM, Maxim Solodovnik solomax...@gmail.comwrote: Hello Andun, I'll try to review the code this week. If this WB is not using wicket-jquery-ui I believe it should be integrated into OM or added to the wicketstuff. The second option is preferable since this component will be available for wider community, but it should be selected only if you going to maintain it. According to functionality: AFAIK 2 features are still missing: add clipart, add document + change page On Wed, Aug 21, 2013 at 9:21 AM, Andun Sameera andun...@gmail.com wrote: Hi All, This is the current status of the whiteboard, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart Since we are in the final stage of the GSOC what are the other requirements which should focus on ? Like documentation etc. Also currently whteboard is plugin of wicket-jquery-ui(But we are not using any wicket-jquery-ui thing). So are we keeping like that or are we moving? Thanks! On Sat, Aug 3, 2013 at 9:43 AM, Andun Sameera andun...@gmail.com wrote: I have created the Jira Issues! @Andrey, I think I can implement Undo, Save Content features quickly. Please instruct me to do those. Also for other things, I need your help a lot. Currently I am looking at possibikites to integrate these features to your code! Thanks! On Sat, Aug 3, 2013 at 2:48 AM, Maxim Solodovnik solomax...@gmail.comwrote: Draw Underline is just draw thick line, I believe it can easily be merged in draw line functionality (only line thickness should be configurable) @Andun sure please add new issues, Ill connect them to the https://issues.apache.org/jira/browse/OPENMEETINGS-551 On Fri, Aug 2, 2013 at 8:04 PM, Andun Sameera andun...@gmail.comwrote: Hi Maxim, I will add at. Please instruct me to proceed. @Andrey Can you give me some clues and help to implement the easy to-dos first! Thanks! On Fri, Aug 2, 2013 at 6:15 PM, Bogdanov Andrey ba...@mail.ru wrote: Most of requested features could be easily implemented, but some of them need discussion - I don't really inderstand what is needed. For example, I don't remeber what is Draw Underline in old whiteboard. I think we shouldn't litter dev-list with all these discussions - the better way is to create Jira Issues for all requested features and discuss there. Пятница, 2 августа 2013, 18:48 +07:00 от Maxim Solodovnik solomax...@gmail.com: Thanks! please also include What is currently missing is the ability to limit WB in size (currently you can scroll endlessly to any direction) I believe there are some more features from my previous email, this is to priority! On Fri, Aug 2, 2013 at 5:53 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, Here is the feature table you requested, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart I think the Save Content part can be Easily Implemented. Also the Undo part. For other parts I have to get the help of Andrey. Thanks! On Fri, Jul 26, 2013 at 9:36 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, The evaluation will begin on 29th. I will fil the form on that day. Is there any comments or instructions to proceed forward? Thanks! On Mon, Jul 22, 2013 at 8:11 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Thanks Maxim! On Jul 22, 2013 7:51 AM, Maxim Solodovnik solomax...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com wrote: Hello Andun, I'll double check the docs, As I can see right now you should fill you evaluation form in Melange. I'll try to review your code today. And I guess we need to schedule meeting to discuss what should be done next On Mon, Jul 22, 2013 at 1:59 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, We have the mid evaluation dead line of GSOC on 29th. What should be the content which I prepare for the evaluation? Thanks1 On Fri, Jul 19, 2013 at 9:40 PM, Andun Sameera
Re: Re[8]: Google Closure Whiteboard
Hi Maxim, I will add at. Please instruct me to proceed. @Andrey Can you give me some clues and help to implement the easy to-dos first! Thanks! On Fri, Aug 2, 2013 at 6:15 PM, Bogdanov Andrey ba...@mail.ru wrote: Most of requested features could be easily implemented, but some of them need discussion - I don't really inderstand what is needed. For example, I don't remeber what is Draw Underline in old whiteboard. I think we shouldn't litter dev-list with all these discussions - the better way is to create Jira Issues for all requested features and discuss there. Пятница, 2 августа 2013, 18:48 +07:00 от Maxim Solodovnik solomax...@gmail.com: Thanks! please also include What is currently missing is the ability to limit WB in size (currently you can scroll endlessly to any direction) I believe there are some more features from my previous email, this is to priority! On Fri, Aug 2, 2013 at 5:53 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, Here is the feature table you requested, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart I think the Save Content part can be Easily Implemented. Also the Undo part. For other parts I have to get the help of Andrey. Thanks! On Fri, Jul 26, 2013 at 9:36 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, The evaluation will begin on 29th. I will fil the form on that day. Is there any comments or instructions to proceed forward? Thanks! On Mon, Jul 22, 2013 at 8:11 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Thanks Maxim! On Jul 22, 2013 7:51 AM, Maxim Solodovnik solomax...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com wrote: Hello Andun, I'll double check the docs, As I can see right now you should fill you evaluation form in Melange. I'll try to review your code today. And I guess we need to schedule meeting to discuss what should be done next On Mon, Jul 22, 2013 at 1:59 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, We have the mid evaluation dead line of GSOC on 29th. What should be the content which I prepare for the evaluation? Thanks1 On Fri, Jul 19, 2013 at 9:40 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, I have implemented the whiteboard cleaning logic. Thanks! On Tue, Jul 16, 2013 at 11:39 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: OK Maxim! @Andrey, Corrected. Sorry my bad! :) Thanks! On Tue, Jul 16, 2013 at 11:37 AM, Maxim Solodovnik solomax...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com wrote: Hello Andun, Currently in OM Whiteboard need to be cleaned up (by selecting appropriate action) otherwise the drawings stays until OM is restarted I'll take a look at the code later :) On Tue, Jul 16, 2013 at 12:54 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, The editedElement looks like {id: 0, type: PointFree, x: -614, y: 57}. I tried to use a enum with values. But it got bit harder. Thus I have made the else if ladder a simple one with some changes. Also I have done all the changes which you have requested! I need another small clarification. Say one person come sand open the white board, then he draws. After that he goes by closing it. Then another ones comes after sometime and open the whiteboard. Should previous drawings have to be there? Basically if clientcount=0 did white board have to be cleaned? Thanks! On Tue, Jul 16, 2013 at 8:03 AM, Maxim Solodovnik solomax...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com wrote: Thanks Andun :) Here are couple more comments: 1) WhiteboardBehavior.respond: how the string editedElement looks like? Maybe it is better to create *enum* with element names and use *switch*instead of nested if...else...if 2) WhiteboardBehavior.renderHead: I would recommend JSONArray instead of concatenating JSONObject.toString(). The code will be very smple in this case: for (Element e : elementMap.values()) { array.add(element.getJSON()); } 3) the bullet above also will require getJSON() method be changed to return JSONObject 4) I also would change Boolean hidden=null; try{ hidden=(Boolean)object.get(hidden);
Re: Re[8]: Google Closure Whiteboard
I have created the Jira Issues! @Andrey, I think I can implement Undo, Save Content features quickly. Please instruct me to do those. Also for other things, I need your help a lot. Currently I am looking at possibikites to integrate these features to your code! Thanks! On Sat, Aug 3, 2013 at 2:48 AM, Maxim Solodovnik solomax...@gmail.comwrote: Draw Underline is just draw thick line, I believe it can easily be merged in draw line functionality (only line thickness should be configurable) @Andun sure please add new issues, Ill connect them to the https://issues.apache.org/jira/browse/OPENMEETINGS-551 On Fri, Aug 2, 2013 at 8:04 PM, Andun Sameera andun...@gmail.com wrote: Hi Maxim, I will add at. Please instruct me to proceed. @Andrey Can you give me some clues and help to implement the easy to-dos first! Thanks! On Fri, Aug 2, 2013 at 6:15 PM, Bogdanov Andrey ba...@mail.ru wrote: Most of requested features could be easily implemented, but some of them need discussion - I don't really inderstand what is needed. For example, I don't remeber what is Draw Underline in old whiteboard. I think we shouldn't litter dev-list with all these discussions - the better way is to create Jira Issues for all requested features and discuss there. Пятница, 2 августа 2013, 18:48 +07:00 от Maxim Solodovnik solomax...@gmail.com: Thanks! please also include What is currently missing is the ability to limit WB in size (currently you can scroll endlessly to any direction) I believe there are some more features from my previous email, this is to priority! On Fri, Aug 2, 2013 at 5:53 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, Here is the feature table you requested, *Feature* *Old Whiteboard* *New Whiteboard* Draw Straight Line Draw Line Draw Circle Draw Rectangle Draw Arrow Insert Text Draw Underline Undo Clear Put Pointer On Whiteboard Save Content of the Whiteboard Insert PDF, Doc , Image to Whiteboard Zoom Draw Connected Straight Lines Insert Clipart I think the Save Content part can be Easily Implemented. Also the Undo part. For other parts I have to get the help of Andrey. Thanks! On Fri, Jul 26, 2013 at 9:36 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, The evaluation will begin on 29th. I will fil the form on that day. Is there any comments or instructions to proceed forward? Thanks! On Mon, Jul 22, 2013 at 8:11 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Thanks Maxim! On Jul 22, 2013 7:51 AM, Maxim Solodovnik solomax...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com wrote: Hello Andun, I'll double check the docs, As I can see right now you should fill you evaluation form in Melange. I'll try to review your code today. And I guess we need to schedule meeting to discuss what should be done next On Mon, Jul 22, 2013 at 1:59 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, We have the mid evaluation dead line of GSOC on 29th. What should be the content which I prepare for the evaluation? Thanks1 On Fri, Jul 19, 2013 at 9:40 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, I have implemented the whiteboard cleaning logic. Thanks! On Tue, Jul 16, 2013 at 11:39 AM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: OK Maxim! @Andrey, Corrected. Sorry my bad! :) Thanks! On Tue, Jul 16, 2013 at 11:37 AM, Maxim Solodovnik solomax...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3asolomax...@gmail.com wrote: Hello Andun, Currently in OM Whiteboard need to be cleaned up (by selecting appropriate action) otherwise the drawings stays until OM is restarted I'll take a look at the code later :) On Tue, Jul 16, 2013 at 12:54 PM, Andun Sameera andun...@gmail.comhttps://e.mail.ru/sentmsg?mailto=mailto%3aandun...@gmail.com wrote: Hi Maxim, The editedElement looks like {id: 0, type: PointFree, x: -614, y: 57}. I tried to use a enum with values. But it got bit harder. Thus I have made the else if ladder a simple one with some changes. Also I have done all the changes which you have requested! I need another small clarification. Say one person come sand open the white board, then he draws. After that he goes by closing it. Then another ones comes after sometime and open the whiteboard. Should previous drawings have to be there? Basically if clientcount=0 did white board have to be cleaned? Thanks! On Tue, Jul 16, 2013 at 8:03 AM, Maxim Solodovnik