[GitHub] opennlp pull request #41: OPENNLP-920: Enforce TypeSafety in SequenceTrainer

[smarthi]

GitHub user smarthi opened a pull request:

https://github.com/apache/opennlp/pull/41

OPENNLP-920: Enforce TypeSafety in SequenceTrainer



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/smarthi/opennlp OPENNLP-920

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 0c2c167d1a7f3401687030ce2e57120955659416
Author: smarthi 
Date:   2017-01-10T04:02:40Z

OPENNLP-920: Enforce TypeSafety in SequenceTrainer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #40: OPENNLP:-83 Add equals to AbstractModels and refer...

[kottmann]

GitHub user kottmann opened a pull request:

https://github.com/apache/opennlp/pull/40

OPENNLP:-83 Add equals to AbstractModels and referenced classes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kottmann/opennlp OPENNLP-83

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 33e0721afd8e9c0e53b175160f0d012ca288786b
Author: Jörn Kottmann 
Date:   2017-01-09T20:16:21Z

OPENNLP-83: Add equals to AbstractModels and referenced classes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Commit message style

[William Colen]

+1 for the OPENNLP-xxx: commit message.
Fast to find a commit.


2017-01-09 21:24 GMT-02:00 Joern Kottmann :

> On Mon, 2017-01-09 at 17:02 -0500, Jeffrey Zemerick wrote:
> > I'm personally a fan of the issue number being the first thing on the
> > subject line, like "OPENNLP-xxx: commit message." For me it gives a
> > consistent place to look for the issue without having to read the
> > full
> > message. (That way you can also see the issue number in GitHub's
> > commit
> > list without having to expand the commit.)
>
>
> Yes, it is also faster to write like that, on the other hand if the
> subject line is then too short to write something meaningful it is
> probably better to write it in the body instead.
>
> +1 to write it first thing in the subject line in all cases where it is
> possible, for very rare cases where it doesn't work it can still be in
> the body
>
> Jörn
>

[GitHub] opennlp pull request #39: Remove deprecated IndexHashTable class

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/opennlp/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Commit message style

[Suneel Marthi]

On Mon, Jan 9, 2017 at 5:02 PM, Jeffrey Zemerick 
wrote:

> I'm personally a fan of the issue number being the first thing on the
> subject line, like "OPENNLP-xxx: commit message." For me it gives a
> consistent place to look for the issue without having to read the full
> message. (That way you can also see the issue number in GitHub's commit
> list without having to expand the commit.)
>

+1


>
> On Mon, Jan 9, 2017 at 1:48 PM, Joern Kottmann  wrote:
>
> > It doesn't matter where the jira# is placed, as long as it is there.
> >
> > Can be in the first line or occur somewhere later in the message,
> > for example see OPENNLP-914. There it was placed in the body.
> >
> > Jörn
> >
> > On Mon, 2017-01-09 at 13:20 -0500, Suneel Marthi wrote:
> > > I guess the reason to include the jira# at the beginning of the
> > > message is
> > > because the same would be reflected in the corresponding jira (i
> > > could be
> > > wrong here).
> > >
> > > I am not sure if omitting the issue# in the git subject line would
> > > still
> > > reflect the git convo in jira or not.
> > >
> > >
> > >
> > > On Mon, Jan 9, 2017 at 8:26 AM, Joern Kottmann 
> > > wrote:
> > >
> > > > Hello all,
> > > >
> > > > we are using different styles for commit messages. It would be good
> > > > to have
> > > > a short discussion on how we think they should be and agree all on
> > > > how to
> > > > write the subject line.
> > > >
> > > > Here are few points from me:
> > > > - Good commit messages are important to understand what happened in
> > > > the
> > > > project and motivate to produce well thought through commits
> > > > - In git we have a subject line, first line in the commit message,
> > > > should
> > > > be around 50 chars, GH cuts after 72 chars and knows this
> > > > convention
> > > > - Subject line is usually written in imperative (git convention)
> > > > - Capitalize the first word (like in a new sentence)
> > > > - Commit message should contain the issue symbol
> > > >
> > > > Open questions:
> > > > - Should the issue symbol be in the subject line? Or in the body?
> > > > - Everyone fine with writing subject line in imperative?
> > > >
> > > > Here is an interesting article about it:
> > > > http://chris.beams.io/posts/git-commit/
> > > >
> > > > Jörn
> > > >
> >
>

Re: Trunk vs. Master

[Joern Kottmann]

Sorry for the confusion, this should have been done differently when we
moved from svn to git. The other repositories opennlp-addons.git and
opennlp-sandbox.git only have the master branch.

Jörn

On Mon, 2017-01-09 at 13:21 -0500, Suneel Marthi wrote:
> ITs the 'master' going forward, we'll be filing an infra request to
> delete
> the 'trunk' branch.
> 
> On Mon, Jan 9, 2017 at 1:18 PM, Russ, Daniel (NIH/CIT) [E] <
> dr...@mail.nih.gov> wrote:
> 
> > Hello,
> >    I am a little confused by the fact we have both a trunk and a
> > master
> > branch.  Which branch should be the baseline?  Can we remove the
> > other?
> > Daniel
> > 
> > Daniel Russ, Ph.D.
> > Staff Scientist, Office of Intramural Research
> > Center for Information Technology
> > National Institutes of Health
> > U.S. Department of Health and Human Services
> > 12 South Drive
> > Bethesda, MD 20892-5624
> > 
> > 

Re: Commit message style

[Joern Kottmann]

It doesn't matter where the jira# is placed, as long as it is there.

Can be in the first line or occur somewhere later in the message,
for example see OPENNLP-914. There it was placed in the body.

Jörn

On Mon, 2017-01-09 at 13:20 -0500, Suneel Marthi wrote:
> I guess the reason to include the jira# at the beginning of the
> message is
> because the same would be reflected in the corresponding jira (i
> could be
> wrong here).
> 
> I am not sure if omitting the issue# in the git subject line would
> still
> reflect the git convo in jira or not.
> 
> 
> 
> On Mon, Jan 9, 2017 at 8:26 AM, Joern Kottmann 
> wrote:
> 
> > Hello all,
> > 
> > we are using different styles for commit messages. It would be good
> > to have
> > a short discussion on how we think they should be and agree all on
> > how to
> > write the subject line.
> > 
> > Here are few points from me:
> > - Good commit messages are important to understand what happened in
> > the
> > project and motivate to produce well thought through commits
> > - In git we have a subject line, first line in the commit message,
> > should
> > be around 50 chars, GH cuts after 72 chars and knows this
> > convention
> > - Subject line is usually written in imperative (git convention)
> > - Capitalize the first word (like in a new sentence)
> > - Commit message should contain the issue symbol
> > 
> > Open questions:
> > - Should the issue symbol be in the subject line? Or in the body?
> > - Everyone fine with writing subject line in imperative?
> > 
> > Here is an interesting article about it:
> > http://chris.beams.io/posts/git-commit/
> > 
> > Jörn
> > 

Re: Trunk vs. Master

[Suneel Marthi]

ITs the 'master' going forward, we'll be filing an infra request to delete
the 'trunk' branch.

On Mon, Jan 9, 2017 at 1:18 PM, Russ, Daniel (NIH/CIT) [E] <
dr...@mail.nih.gov> wrote:

> Hello,
>I am a little confused by the fact we have both a trunk and a master
> branch.  Which branch should be the baseline?  Can we remove the other?
> Daniel
>
> Daniel Russ, Ph.D.
> Staff Scientist, Office of Intramural Research
> Center for Information Technology
> National Institutes of Health
> U.S. Department of Health and Human Services
> 12 South Drive
> Bethesda, MD 20892-5624
>
>

Trunk vs. Master

[Russ, Daniel (NIH/CIT) [E]]

Hello,
   I am a little confused by the fact we have both a trunk and a master branch. 
 Which branch should be the baseline?  Can we remove the other?
Daniel

Daniel Russ, Ph.D.
Staff Scientist, Office of Intramural Research
Center for Information Technology
National Institutes of Health
U.S. Department of Health and Human Services
12 South Drive
Bethesda, MD 20892-5624

Commit message style

[Joern Kottmann]

Hello all,

we are using different styles for commit messages. It would be good to have
a short discussion on how we think they should be and agree all on how to
write the subject line.

Here are few points from me:
- Good commit messages are important to understand what happened in the
project and motivate to produce well thought through commits
- In git we have a subject line, first line in the commit message, should
be around 50 chars, GH cuts after 72 chars and knows this convention
- Subject line is usually written in imperative (git convention)
- Capitalize the first word (like in a new sentence)
- Commit message should contain the issue symbol

Open questions:
- Should the issue symbol be in the subject line? Or in the body?
- Everyone fine with writing subject line in imperative?

Here is an interesting article about it:
http://chris.beams.io/posts/git-commit/

Jörn

[GitHub] opennlp pull request #34: OPENNLP-719: Restore “type” argument in NameFi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/opennlp/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Release Process on wiki

[Rodrigo Agerri]

great!

R

On Thu, Jan 5, 2017 at 8:12 PM, Chris Mattmann  wrote:

> Hi,
>
> Thanks to the team, we now have a release process on the wiki.
>
> https://cwiki.apache.org/confluence/display/OPENNLP/Release+Process
>
> @Community
>
> Please check it out and you can follow on for future Release Managers.
> Glad to have this documented and to have my feedback responded to.
>
> Thanks,
> Chris
>
>
>
>
>
>