[GitHub] opennlp pull request #121: OPENNLP-983: Allows length for Prefix and Suffix ...

2017-02-09 Thread jzonthemtn 
GitHub user jzonthemtn opened a pull request:

https://github.com/apache/opennlp/pull/121

OPENNLP-983: Allows length for Prefix and Suffix feature generators to be 
set



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jzonthemtn/opennlp OPENNLP-983

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #121


commit aeb4ec9b12c451aeb286b2448f7939adac22
Author: jzonthemtn 
Date:   2017-02-09T21:31:00Z

OPENNLP-983: Makes prefix and suffix length customizable and prevents 
duplicate features when the length is larger than the token size.

commit 4dda5480f37f945e4b69877a92876e74f0c1c012
Author: jzonthemtn 
Date:   2017-02-09T21:54:03Z

OPENNLP-983: Fixes checkstyle problems.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Hardcoded length in prefix and suffix feature generators

2017-02-09 Thread William Colen 
Looks good! Thanks for the unit tests.
Please open a Jira, squash your commits and open the PR.

2017-02-09 19:55 GMT-02:00 Jeffrey Zemerick :

> Hi,
>
> I noticed that the length is hardcoded to 4 in the PrefixFeatureGenerator
> and the SuffixFeatureGenerator. I made this value configurable in the XML
> for each feature generator. I also add a check for the length to keep
> duplicate prefixes or suffixes being returned. (If the token is "yes" with
> a length of 4 there would be two "yes" features returned.) If a value is
> not provided in the XML it uses the default value of 4.
>
> You can preview the changes here:
> https://github.com/apache/opennlp/compare/master...
> jzonthemtn:prefixsuffix?expand=1
>
> If this is a change that's desired by the group I can make a JIRA and a
> pull request.
>
> Thanks,
> Jeff
>

Hardcoded length in prefix and suffix feature generators

2017-02-09 Thread Jeffrey Zemerick 
Hi,

I noticed that the length is hardcoded to 4 in the PrefixFeatureGenerator
and the SuffixFeatureGenerator. I made this value configurable in the XML
for each feature generator. I also add a check for the length to keep
duplicate prefixes or suffixes being returned. (If the token is "yes" with
a length of 4 there would be two "yes" features returned.) If a value is
not provided in the XML it uses the default value of 4.

You can preview the changes here:
https://github.com/apache/opennlp/compare/master...jzonthemtn:prefixsuffix?expand=1

If this is a change that's desired by the group I can make a JIRA and a
pull request.

Thanks,
Jeff

[GitHub] opennlp pull request #101: OPENNLP-855 Sentiment Analysis Parser

2017-02-09 Thread amensiko 
Github user amensiko closed the pull request at:

https://github.com/apache/opennlp/pull/101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #118: OpenNLP-981: Add training stream hash to Abstract...

2017-02-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/opennlp/pull/118


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #120: [WIP] OPENNLP-125: Make POS Tagger feature genera...

2017-02-09 Thread kottmann 
GitHub user kottmann opened a pull request:

https://github.com/apache/opennlp/pull/120

[WIP] OPENNLP-125: Make POS Tagger feature generation configurable



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kottmann/opennlp OPENNLP-125

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #120


commit d9fc86b3f8df64179d78499015a86fde9bc53c6c
Author: Jörn Kottmann 
Date:   2017-02-09T17:54:27Z

OPENNLP-125: Make POS Tagger feature generation configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #119: NoJira: Update pom and jira version to 1.8.0

2017-02-09 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/opennlp/pull/119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #119: NoJira: Update pom and jira version to 1.8.0

2017-02-09 Thread kottmann 
GitHub user kottmann opened a pull request:

https://github.com/apache/opennlp/pull/119

NoJira: Update pom and jira version to 1.8.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kottmann/opennlp 180_pom_update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #119


commit efb183135d33b68838615091c07c363b4c657d70
Author: Jörn Kottmann 
Date:   2017-02-09T17:41:20Z

NoJira: Update pom and jira version to 1.8.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #118: OpenNLP-981: Add training stream hash to Abstract...

2017-02-09 Thread danielruss 
GitHub user danielruss opened a pull request:

https://github.com/apache/opennlp/pull/118

OpenNLP-981: Add training stream hash to AbstractEventTrainer.

Added training stream hash back to the AbstractEventTrainer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielruss/opennlp OPENNLP-981

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/opennlp/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit c91382e3369d754ec869c83c497ea85a779f8a33
Author: Daniel Russ 
Date:   2017-02-09T14:56:12Z

OpenNLP-981: Add training stream hash to AbstractEventTrainer.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---