[GitHub] opennlp pull request #19: OPENNLP-870: ContextGenerator is now Generic
Github user asfgit closed the pull request at: https://github.com/apache/opennlp/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] opennlp pull request #19: OPENNLP-870: ContextGenerator is now Generic
GitHub user danielruss opened a pull request: https://github.com/apache/opennlp/pull/19 OPENNLP-870: ContextGenerator is now Generic Small change to make ContextGenerator a Generic Class You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielruss/opennlp OPENNLP-870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/opennlp/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit 4f8254516dfd3316bd5b3b49bb15fca489d28304 Author: Daniel Russ Date: 2016-12-23T19:35:12Z OPENNLP-870: ContextGenerator is now Generic --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: ContextGenerator
Hello, the ContextGenerator is not used much anymore and was replaced with context generators which are specific for a component. It think it we can safely make it generic, and the change wouldn't break backward compatibility anyway. Jörn On Fri, Oct 21, 2016 at 3:40 PM, Russ, Daniel (NIH/CIT) [E] < dr...@mail.nih.gov> wrote: > Hello, > Can we please make ContextGenerator a Generic type? I open a JIRA > issue (OPENNLP-870). It is a simple fix. I can try to send a git diff. > Daniel > > Daniel Russ, Ph.D. > Staff Scientist, Office of Intramural Research > Center for Information Technology > National Institutes of Health > U.S. Department of Health and Human Services > 12 South Drive > Bethesda, MD 20892-5624 > >
ContextGenerator
Hello, Can we please make ContextGenerator a Generic type? I open a JIRA issue (OPENNLP-870). It is a simple fix. I can try to send a git diff. Daniel Daniel Russ, Ph.D. Staff Scientist, Office of Intramural Research Center for Information Technology National Institutes of Health U.S. Department of Health and Human Services 12 South Drive Bethesda, MD 20892-5624
ContextGenerator
Hello, Is it possible to change the ContextGenerator interface to use generics? I would send in a JIRA request, but I am not sure how to do it. Create has a nice big red button, the red "create service desk desk request is clear”, but then something about kylin, Atlas, Ranger, and Apache Infrastructure. It is a small change, and I have a patch that I would be happy to share. Daniel Russ, Ph.D. Staff Scientist, Office of Intramural Research Center for Information Technology National Institutes of Health U.S. Department of Health and Human Services 12 South Drive Bethesda, MD 20892-5624
