New lines at end of source files

2017-02-13 Thread Jeffrey Zemerick
On a recent pull request there was a comment that some new source files did
not have new lines at the ends of the files. When I added a rule to
checkstyle for new lines at the ends of files there were a good number of
files in violation of that rule so I added the new lines to those files.
Before I submit it as a pull request and because it touches a lot of files
I wanted to discuss it here first.

The changes: 
*https://github.com/apache/opennlp/compare/master...jzonthemtn:checkstyle-nl?expand=1
*

Be happy to open it as a pull request if it's ok, or If not, no problem!

Thanks,
Jeff


Re: New lines at end of source files

2017-02-14 Thread Joern Kottmann
+1 to merge this

Jörn

On Mon, Feb 13, 2017 at 9:26 PM, Jeffrey Zemerick 
wrote:

> On a recent pull request there was a comment that some new source files did
> not have new lines at the ends of the files. When I added a rule to
> checkstyle for new lines at the ends of files there were a good number of
> files in violation of that rule so I added the new lines to those files.
> Before I submit it as a pull request and because it touches a lot of files
> I wanted to discuss it here first.
>
> The changes: *https://github.com/apache/opennlp/compare/master...
> jzonthemtn:checkstyle-nl?expand=1
>  jzonthemtn:checkstyle-nl?expand=1>*
>
> Be happy to open it as a pull request if it's ok, or If not, no problem!
>
> Thanks,
> Jeff
>