Re: gtest build error
Hi All,
As suspekted adding GTEST_ in front fixes my setup.
All the best
Am 29.04.23 um 09:26 schrieb Peter Kovacs:
Hi all.
Build fails with:
main/sal/qa/rtl/crc32/rtl_crc32.cxx:72:1:error: expected constructor,
destructor, or type conversion before '(' token
72 | TEST_F(test, rtl_crc32_002_1)
I have installed gtest using official ubuntu package
the readme says:
### Avoiding Macro Name Clashes
In C++, macros don't obey namespaces. Therefore two libraries that
both define a
macro of the same name will clash if you `#include` both definitions.
In case a
GoogleTest macro clashes with another library, you can force
GoogleTest to
rename its macro to avoid the conflict.
Specifically, if both GoogleTest and some other code define macro FOO,
you can
add
-DGTEST_DONT_DEFINE_FOO=1
to the compiler flags to tell GoogleTest to change the macro's name
from `FOO`
to `GTEST_FOO`. Currently `FOO` can be `FAIL`, `SUCCEED`, or `TEST`. For
example, with `-DGTEST_DONT_DEFINE_TEST=1`, you'll need to write
GTEST_TEST(SomeTest, DoesThis) { ... }
instead of
TEST(SomeTest, DoesThis) { ... }
in order to define a test.
--
can this cause my issue?
should we make a change if so?
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: gtest build error
Hi Peter,
Am 30.04.23 um 12:19 schrieb Peter Kovacs:
> Hi All,
>
> As suspekted adding GTEST_ in front fixes my setup.
What does that mean?
Do we need to change something in our code or is it just a configuration
issue?
Regards,
Matthias
>
> All the best
>
>
> Am 29.04.23 um 09:26 schrieb Peter Kovacs:
>> Hi all.
>>
>> Build fails with:
>>
>> main/sal/qa/rtl/crc32/rtl_crc32.cxx:72:1:error: expected constructor,
>> destructor, or type conversion before '(' token
>>
>> 72 | TEST_F(test, rtl_crc32_002_1)
>>
>> I have installed gtest using official ubuntu package
>>
>> the readme says:
>>
>> ### Avoiding Macro Name Clashes
>>
>> In C++, macros don't obey namespaces. Therefore two libraries that
>> both define a
>> macro of the same name will clash if you `#include` both definitions.
>> In case a
>> GoogleTest macro clashes with another library, you can force
>> GoogleTest to
>> rename its macro to avoid the conflict.
>>
>> Specifically, if both GoogleTest and some other code define macro
>> FOO, you can
>> add
>>
>> -DGTEST_DONT_DEFINE_FOO=1
>>
>> to the compiler flags to tell GoogleTest to change the macro's name
>> from `FOO`
>> to `GTEST_FOO`. Currently `FOO` can be `FAIL`, `SUCCEED`, or `TEST`. For
>> example, with `-DGTEST_DONT_DEFINE_TEST=1`, you'll need to write
>>
>> GTEST_TEST(SomeTest, DoesThis) { ... }
>>
>> instead of
>>
>> TEST(SomeTest, DoesThis) { ... }
>>
>> in order to define a test.
>>
>> --
>>
>> can this cause my issue?
>>
>> should we make a change if so?
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>
smime.p7s
Description: S/MIME Cryptographic Signature
[GitHub] [openoffice] ardovm commented on pull request #177: Remove unused(?) code
ardovm commented on PR #177: URL: https://github.com/apache/openoffice/pull/177#issuecomment-1529129687 Once we delete the implementation of method `SdrGluePoint::Draw`, it is IMHO a good idea to delete its declaration as well. In this way, if any other piece of code refers to that method, it should not compile any more. Let us now check that this branch is still compiling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] Pilot-Pirx commented on pull request #177: Remove unused(?) code
Pilot-Pirx commented on PR #177: URL: https://github.com/apache/openoffice/pull/177#issuecomment-1529130242 Thanks, I will check! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
