Re: [FEATURE][DISCUSS] The values of upper and lower spacing for default paragraph did the complete opposite

2014-06-23 Thread Steve Yin
Hi Juergen,

Sorry for the late reply.

I tested some cases and confirmed that the change does not affect existing
documents. The new default spacing value merely applies on new created
slides. Thanks.


On Mon, Jun 16, 2014 at 4:30 PM, Jürgen Schmidt jogischm...@gmail.com
wrote:

 On 13/06/14 11:43, Shenfeng Liu wrote:
  2014-06-13 15:16 GMT+08:00 Steve Yin steve.yin@gmail.com:
 
  Hi,
 
  The spacing size between lines is inconspicuous. But in some cases, it
  becomes a disturbing problem. This bug shows the problem:
  https://issues.apache.org/ooo/show_bug.cgi?id=125090. In the
 attachment, I
  put 2 screenshots to illustrate the issue.
 
  The patch is ready.
 
  Should we change it?
 
 
  +1 to change the default line space from bottom to top, which will make
 the
  layout align more to the content logic.
  Currently I spent a lot of time to change the default line space in my
  presentations.
 
  While currently we are working on 4.1.1. I think this change should
 belong
  to a big release, e.g. 4.2.

 yes definitely nothing for 4.1.1

 But I have a further question because changing default is always tricky.
 Have you tested to open existing documents with this new default. Do
 they still work and looking good or has the new default any impact on
 older documents? The question is often if such defaults are written to
 files or not.

 But in general the change sounds reasonable to me.

 Juergen

 
 
  - Shenfeng (Simon)
 
 
 
 
  --
  Best Regards,
 
  Steve Yin
 
 


 -
 To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
 For additional commands, e-mail: dev-h...@openoffice.apache.org




-- 
Best Regards,

Steve Yin


Re: [FEATURE][DISCUSS] The values of upper and lower spacing for default paragraph did the complete opposite

2014-06-16 Thread Jürgen Schmidt
On 13/06/14 11:43, Shenfeng Liu wrote:
 2014-06-13 15:16 GMT+08:00 Steve Yin steve.yin@gmail.com:
 
 Hi,

 The spacing size between lines is inconspicuous. But in some cases, it
 becomes a disturbing problem. This bug shows the problem:
 https://issues.apache.org/ooo/show_bug.cgi?id=125090. In the attachment, I
 put 2 screenshots to illustrate the issue.

 The patch is ready.

 Should we change it?

 
 +1 to change the default line space from bottom to top, which will make the
 layout align more to the content logic.
 Currently I spent a lot of time to change the default line space in my
 presentations.
 
 While currently we are working on 4.1.1. I think this change should belong
 to a big release, e.g. 4.2.

yes definitely nothing for 4.1.1

But I have a further question because changing default is always tricky.
Have you tested to open existing documents with this new default. Do
they still work and looking good or has the new default any impact on
older documents? The question is often if such defaults are written to
files or not.

But in general the change sounds reasonable to me.

Juergen

 
 
 - Shenfeng (Simon)
 
 
 

 --
 Best Regards,

 Steve Yin

 


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



[FEATURE][DISCUSS] The values of upper and lower spacing for default paragraph did the complete opposite

2014-06-13 Thread Steve Yin
Hi,

The spacing size between lines is inconspicuous. But in some cases, it
becomes a disturbing problem. This bug shows the problem:
https://issues.apache.org/ooo/show_bug.cgi?id=125090. In the attachment, I
put 2 screenshots to illustrate the issue.

The patch is ready.

Should we change it?

-- 
Best Regards,

Steve Yin


Re: [FEATURE][DISCUSS] The values of upper and lower spacing for default paragraph did the complete opposite

2014-06-13 Thread Shenfeng Liu
2014-06-13 15:16 GMT+08:00 Steve Yin steve.yin@gmail.com:

 Hi,

 The spacing size between lines is inconspicuous. But in some cases, it
 becomes a disturbing problem. This bug shows the problem:
 https://issues.apache.org/ooo/show_bug.cgi?id=125090. In the attachment, I
 put 2 screenshots to illustrate the issue.

 The patch is ready.

 Should we change it?


+1 to change the default line space from bottom to top, which will make the
layout align more to the content logic.
Currently I spent a lot of time to change the default line space in my
presentations.

While currently we are working on 4.1.1. I think this change should belong
to a big release, e.g. 4.2.


- Shenfeng (Simon)




 --
 Best Regards,

 Steve Yin