Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format

[chengjh]

Committed with 1414498.thanks for the code review.


On Thu, Nov 22, 2012 at 11:27 AM, chengjh  wrote:

> Thanks to Fan's effort.
>
>
> On Thu, Nov 22, 2012 at 11:02 AM, Fan Zheng wrote:
>
>> I will take a look at the patch. thx.
>>
>>
>>
>> 2012/11/21 Joost Andrae 
>>
>> > Hi,
>> >
>> > maybe it helps if someone documents the usage of issue ids within the
>> > source code for unexperienced developers.
>> >
>> > In this example the issue represented by i120928 ( := OOo Issue Tracker
>> ID
>> > 120928 ) is to be resolved to https://issues.apache.org/ooo/**
>> > show_bug.cgi?id=120928<
>> https://issues.apache.org/ooo/show_bug.cgi?id=120928>
>> >
>> > Am 21.11.2012 08:20, schrieb chengjh:
>> >
>> >  Updated the patch according to the comments...Please review
>> >> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
>> >> action=diff.Thanks<
>> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
>> >> .
>> >>
>> >> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr  wrote:
>> >>
>> >>  I agree with Pedro that the change history belongs into the RCS,
>> >>> especially in a code base as ours where some source files have had
>> many
>> >>> hundreds of changes over their history of about twenty years.
>> >>>
>> >>> Of course an issue reference is valuable when the comment helps to
>> >>> understand what the code does and why it does it. Anything else is
>> >>> distracting.
>> >>>
>> >>
>> > Kind regards, Joost
>> >
>> >
>> >
>>
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>
>


-- 

Best Regards,Jianhong Cheng

Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format

[chengjh]

Committed with 1414498.thanks for the code review.


On Thu, Nov 22, 2012 at 11:27 AM, chengjh  wrote:

> Thanks to Fan's effort.
>
>
> On Thu, Nov 22, 2012 at 11:02 AM, Fan Zheng wrote:
>
>> I will take a look at the patch. thx.
>>
>>
>>
>> 2012/11/21 Joost Andrae 
>>
>> > Hi,
>> >
>> > maybe it helps if someone documents the usage of issue ids within the
>> > source code for unexperienced developers.
>> >
>> > In this example the issue represented by i120928 ( := OOo Issue Tracker
>> ID
>> > 120928 ) is to be resolved to https://issues.apache.org/ooo/**
>> > show_bug.cgi?id=120928<
>> https://issues.apache.org/ooo/show_bug.cgi?id=120928>
>> >
>> > Am 21.11.2012 08:20, schrieb chengjh:
>> >
>> >  Updated the patch according to the comments...Please review
>> >> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
>> >> action=diff.Thanks<
>> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
>> >> .
>> >>
>> >> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr  wrote:
>> >>
>> >>  I agree with Pedro that the change history belongs into the RCS,
>> >>> especially in a code base as ours where some source files have had
>> many
>> >>> hundreds of changes over their history of about twenty years.
>> >>>
>> >>> Of course an issue reference is valuable when the comment helps to
>> >>> understand what the code does and why it does it. Anything else is
>> >>> distracting.
>> >>>
>> >>
>> > Kind regards, Joost
>> >
>> >
>> >
>>
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>
>


-- 

Best Regards,Jianhong Cheng

Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format

[chengjh]

Thanks to Fan's effort.

On Thu, Nov 22, 2012 at 11:02 AM, Fan Zheng  wrote:

> I will take a look at the patch. thx.
>
>
>
> 2012/11/21 Joost Andrae 
>
> > Hi,
> >
> > maybe it helps if someone documents the usage of issue ids within the
> > source code for unexperienced developers.
> >
> > In this example the issue represented by i120928 ( := OOo Issue Tracker
> ID
> > 120928 ) is to be resolved to https://issues.apache.org/ooo/**
> > show_bug.cgi?id=120928<
> https://issues.apache.org/ooo/show_bug.cgi?id=120928>
> >
> > Am 21.11.2012 08:20, schrieb chengjh:
> >
> >  Updated the patch according to the comments...Please review
> >> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
> >> action=diff.Thanks<
> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
> >> .
> >>
> >> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr  wrote:
> >>
> >>  I agree with Pedro that the change history belongs into the RCS,
> >>> especially in a code base as ours where some source files have had many
> >>> hundreds of changes over their history of about twenty years.
> >>>
> >>> Of course an issue reference is valuable when the comment helps to
> >>> understand what the code does and why it does it. Anything else is
> >>> distracting.
> >>>
> >>
> > Kind regards, Joost
> >
> >
> >
>



-- 

Best Regards,Jianhong Cheng

Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format

[Fan Zheng]

I will take a look at the patch. thx.



2012/11/21 Joost Andrae 

> Hi,
>
> maybe it helps if someone documents the usage of issue ids within the
> source code for unexperienced developers.
>
> In this example the issue represented by i120928 ( := OOo Issue Tracker ID
> 120928 ) is to be resolved to https://issues.apache.org/ooo/**
> show_bug.cgi?id=120928
>
> Am 21.11.2012 08:20, schrieb chengjh:
>
>  Updated the patch according to the comments...Please review
>> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
>> action=diff.Thanks
>> .
>>
>> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr  wrote:
>>
>>  I agree with Pedro that the change history belongs into the RCS,
>>> especially in a code base as ours where some source files have had many
>>> hundreds of changes over their history of about twenty years.
>>>
>>> Of course an issue reference is valuable when the comment helps to
>>> understand what the code does and why it does it. Anything else is
>>> distracting.
>>>
>>
> Kind regards, Joost
>
>
>

Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format

[Joost Andrae]

Hi,

maybe it helps if someone documents the usage of issue ids within the 
source code for unexperienced developers.


In this example the issue represented by i120928 ( := OOo Issue Tracker 
ID 120928 ) is to be resolved to 
https://issues.apache.org/ooo/show_bug.cgi?id=120928


Am 21.11.2012 08:20, schrieb chengjh:

Updated the patch according to the comments...Please review
https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks.

On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr  wrote:


I agree with Pedro that the change history belongs into the RCS,
especially in a code base as ours where some source files have had many
hundreds of changes over their history of about twenty years.

Of course an issue reference is valuable when the comment helps to
understand what the code does and why it does it. Anything else is
distracting.


Kind regards, Joost

Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format

[chengjh]

Updated the patch according to the comments...Please review
https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks.

On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr  wrote:

> I agree with Pedro that the change history belongs into the RCS,
> especially in a code base as ours where some source files have had many
> hundreds of changes over their history of about twenty years.
>
> Of course an issue reference is valuable when the comment helps to
> understand what the code does and why it does it. Anything else is
> distracting.
>
> Herbert
> (sorry for top-posting)
>
>
> On 2012/10/09 8:06 AM, chengjh wrote:
>
>> The comment format can provide another way to get the whole code change
>> set,except svn, which is valuable for someone who has only the code
>> base,is
>> not familiar with the tool svn, especially,meets regression issue related
>> to the code change.The comments will be quite helpful.
>>
>> On Tue, Oct 9, 2012 at 12:04 PM, Pedro Giffuni  wrote:
>>
>>  Hello;
>>>
>>> --- Lun 8/10/12, chengjh ha scritto:
>>>
>>>
>>>  Data: Lunedě 8 ottobre 2012, 20:21

 I have delivered the patch
 https://issues.apache.org/ooo/**attachment.cgi?id=79748&**action=diff
 to
 improve the graphic bullet interoperability with MS Word
 binary document.
 Can any expert help the code review before I commit
 it?Thanks in advance.

 [1]Call for Test::http://s.apache.org/YYk


>>>
>>> Please avoid comments like
>>> //begin fix for ixx
>>> ...
>>> //end of fix
>>>
>>> Such comments are useless and if someone does care that type of
>>> information is registered by the version control system (SVN) anyways.
>>>
>>> Pedro.
>>>
>>


-- 

Best Regards,Jianhong Cheng