review requested: [Bug 21280] when cut/copy rows/columns & paste-special, shift down/right options are disabled incorrectly : [Attachment 82276] fix patch

2014-01-14 Thread bugzilla 
Shenfeng Liu  has asked Shenfeng Liu 
for review:
Bug 21280: when cut/copy rows/columns & paste-special, shift down/right options
are disabled incorrectly
https://issues.apache.org/ooo/show_bug.cgi?id=21280

Attachment 82276: fix patch
https://issues.apache.org/ooo/attachment.cgi?id=82276&action=edit


--- Additional Comments from Shenfeng Liu 
A patch that corrected the logical to enable shift down and shift right radio
buttons when cut whole row or whole column.

-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Re: review requested: [Bug 21280] when cut/copy rows/columns & paste-special, shift down/right options are disabled incorrectly : [Attachment 82276] fix patch

2014-01-14 Thread Jürgen Schmidt 
On 1/14/14 9:44 AM, bugzi...@apache.org wrote:
> Shenfeng Liu  has asked Shenfeng Liu 
> for review:
> Bug 21280: when cut/copy rows/columns & paste-special, shift down/right 
> options
> are disabled incorrectly
> https://issues.apache.org/ooo/show_bug.cgi?id=21280
> 
> Attachment 82276: fix patch
> https://issues.apache.org/ooo/attachment.cgi?id=82276&action=edit

I will take a look in it ...

Juergen

> 
> 
> --- Additional Comments from Shenfeng Liu 
> A patch that corrected the logical to enable shift down and shift right radio
> buttons when cut whole row or whole column.
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org

Re: review requested: [Bug 21280] when cut/copy rows/columns & paste-special, shift down/right options are disabled incorrectly : [Attachment 82276] fix patch

2014-01-15 Thread Shenfeng Liu 
Juergen,
  I just updated with a new patch, which I did UT with multiple copy/cut
and shift down / shift right situation. Please help to review if you have
time.
  It is my first time to do patch, so please tell me if I did any thing
wrong.
  Thanks very much!


- Shenfeng (Simon)


2014/1/14 Jürgen Schmidt 

> On 1/14/14 9:44 AM, bugzi...@apache.org wrote:
> > Shenfeng Liu  has asked Shenfeng Liu <
> liush...@gmail.com>
> > for review:
> > Bug 21280: when cut/copy rows/columns & paste-special, shift down/right
> options
> > are disabled incorrectly
> > https://issues.apache.org/ooo/show_bug.cgi?id=21280
> >
> > Attachment 82276: fix patch
> > https://issues.apache.org/ooo/attachment.cgi?id=82276&action=edit
>
> I will take a look in it ...
>
> Juergen
>
> >
> >
> > --- Additional Comments from Shenfeng Liu 
> > A patch that corrected the logical to enable shift down and shift right
> radio
> > buttons when cut whole row or whole column.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> > For additional commands, e-mail: dev-h...@openoffice.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>
>