[dev] RE:Re: [dev] RE:Re: [dev] RE:[dev] question about use XStorage in filt
Thank you for your explaination! Now I get an idea of storing a file clearly.:-) - Original Message - From:Mathias Bauer To:dev@openoffice.org Subject:Re: [dev] RE:Re: [dev] RE:[dev] question about use XStorage in filter Date:07-06-25 14:55:37 Hi, first thanks for fixing the problem with the mail client. Now about the possible problem. [EMAIL PROTECTED] wrote: > ///create the target storage > > uno::Sequence aArgs( 2 ); > aArgs[0] aArgs[1] uno::Reference xTargetStorage( > xStorageFactory->createInstanceWithArguments( aArgs ), > uno::UNO_QUERY ); The problem is that you shouldn't use the URL, you must use the outputstream that is provided to you. The framework opens a temporary stream and finally copies it over the target file in the Commit() in SfxObjectShell that you have quoted. The reason is simple: if something goes wrong in the filter the original files isn't destroyed. So even if you already create your file at the target location the SfxObjectShell will overwrite it with all the content stored in the output stream. In your case the stream is empty, thus the zero byte length of the result. Here's what a filter creating a storage should do: - first create a temporary file - get the XStream interface from it - open a storage based on that stream - copy the document into it - add your substorage - commit this storage(!) - dispose of it - copy from this stream to the XOutputStream from the arguments - dispose of the TempFile The content of the output stream is handled by the framework code. It will close the stream and copy the bits if everything went fine. Seeing your code I wonder whether we should add a "Stream" argument so that you don't need to create the temporary copy. But for the time being you should proceed as recommended. Ciao, Mathias -- Mathias Bauer (mba) - Project Lead OpenOffice.org Writer OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't reply to "[EMAIL PROTECTED]". I use it for the OOo lists and only rarely read other mails sent to it. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --- MOTO新摄会 狂拍无极限 超多好礼等你来赢( http://d1.sina.com.cn/sina/limeng3/mail_zhuiyu/2007/mail_zhuiyu_20070625.html ) === 注册新浪2G免费邮箱( http://mail.sina.com.cn/chooseMode.html )
Re: [dev] 470 "versions" in issuezilla, can we drop a couple of hundred ?
On Tue, 2007-06-26 at 08:13 +0200, Frank Schönheit - Sun Microsystems Germany wrote: > To not end up with fruitless discussions here, I suggest somebody > (Caolan?) submits an issue to collab.net requesting the possibility to > limit the version list when submitting an issue. Then let's get Stefan > on board, and see what collab.net says about it. Well, logged as http://qa.openoffice.org/issues/show_bug.cgi?id=78883 Not sure that it is on collab's tracker as a simple against website bug. Feel free to reassign it if anyone has a better idea as to where it should go. C. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dev] Re: [mac] OpenOffice.org aqua build breaks on Mac OS X 10.4.10
Hi, all - On 6/25/07, eric.bachard <[EMAIL PROTECTED]> wrote: Just wondering : maybe the issue is caused by uncomplete sources, or something like that ? - building m214 + aquavcl01 (just before resync) => no problem My apologies -- it turns out that I had an old version of XCode on my system. The issue is now resolved as "worksforme." Thanks! - Omer.
Re: [dev] SRC680_m201 777 unused methods nagmail
Hi Caolan, Caolan McNamara wrote: > On Thu, 2007-04-05 at 16:37 +0200, Mathias Bauer wrote: >> Hi Caolan, >> >> Caolan McNamara wrote: >> >> > 116 methods: >> > http://people.redhat.com/caolanm/callcatcher/m201.sw.log >> > first entry is AddressMultiLineEdit::Modified >> > >> > 18 methods: >> > http://people.redhat.com/caolanm/callcatcher/m201.starmath.log >> > first entry is ConvertMathMLToMath(unsigned short) >> >> To avoid duplicate work: did you already commit some of the changes? > > We didn't commit anything directly, but jnavrati submitted a patch to > remove the majority of the sw ones as > http://www.openoffice.org/issues/show_bug.cgi?id=75235 > > And also two patches to remove the majority of the dbaccess ones. There > are still a handful of the more tricky ones outstanding for sw (some of > which are c-style symbols which might be dlopened by something, if so > let me know and I'll whitelist them in the tooling). So you'd really > need to regenerate a new list of the unused methods of sw post os94, and > for dbaccess post dba23a. os94 is integrated since roughly a month. Can you generate a new list for sw? Or should we do it (how)? Ciao, Mathias -- Mathias Bauer (mba) - Project Lead OpenOffice.org Writer OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't reply to "[EMAIL PROTECTED]". I use it for the OOo lists and only rarely read other mails sent to it. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [dev] SRC680_m201 777 unused methods nagmail
On Tue, 2007-06-26 at 16:12 +0200, Mathias Bauer wrote: > os94 is integrated since roughly a month. Can you generate a new list > for sw? Or should we do it (how)? To make a new list, on a linux box grab http://www.skynet.ie/~caolan/pub/callcatcher/callcatcher-1.0.4.tar.gz unpack ./setup.py install When in your linux OOo/SO build env, point CC/CXX etc as shown in http://www.skynet.ie/~caolan/Packages/callcatcher.html to "callcatcher gcc"/"callcatcher g++" etc and rebuild sw after the build do callanalyse --OpenOffice.org unxlngi*/pro/*so > /tmp/unused.symbols and that should be it. The --OpenOffice.org option suppresses printing unused symbols from the DECLARE_LIST and so on family of OOo macros. And by default "well formed" copy and assignment methods are suppressed as well unless you use --strict. C. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dev] how to cope with crash bugs
Hi, I saw the email talking about crash reporter, and I am going to do a little bit work in related to crash bugs and I am wondering if I can get some help from SUN. first I would like to know something about ooomapstack and Sun's crashdebug utility, and I will appreciate that. thanks Zhao sheng - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]