Re: [dev] Re: sal_IntPtr (was Re: [dev] Warning-Free Code)

[Jan Holesovsky]

Hi Herbert,

On Fri, 16 Sep 2005, Herbert Duerr wrote:


Now I would like to create one more CWS with fixes from ooo64bit02.  It
will fix occurances of long *pDXArray, which should be sal_Int32 *pDXArray
(according to the declaration in VCL).  Would you please volunteer to help
with review of this one as well? ;-)


I volunteer to review these changes...


Thank you very much!  I have created an issue for this, 
http://www.openoffice.org/issues/show_bug.cgi?id=54697


Bye,
Jan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [dev] Re: sal_IntPtr (was Re: [dev] Warning-Free Code)

[Herbert Duerr]

Hi Jan,

> Now I would like to create one more CWS with fixes from ooo64bit02.  It
> will fix occurances of long *pDXArray, which should be sal_Int32 *pDXArray
> (according to the declaration in VCL).  Would you please volunteer to help
> with review of this one as well? ;-)

I volunteer to review these changes...

--
Herbert

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [dev] Re: sal_IntPtr (was Re: [dev] Warning-Free Code)

[Stefan Taxhet]

Hi,

Jan Holesovsky wrote:


On Wed, 14 Sep 2005, Stephan Bergmann wrote:


[...]

Jörg Sievers (jsi) agreed to do QA on that CWS, and I would volunteer 
to do a code review.


Thank you for that!  All the patches are in the 'intptr' CWS now, so 
I've marked it as 'Ready for QA'.  I hope it's OK; please write me if 
there is anything more I should do now.


Joerg is eager to run automated tests on installation sets build from 
the CWS intptr.

Do you have one available for download?

Greetings
Stefan


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [dev] Re: sal_IntPtr (was Re: [dev] Warning-Free Code)

[Stephan Bergmann]

Stephan Bergmann wrote:

Jan Holesovsky wrote:


Hi,

On Mon, 29 Aug 2005, Stephan Bergmann wrote:

The team members should also have a look at the 64-bit CWS 
(ooo64bit02) to see what data sizes they already changed.




[...]

- Added SAL_INT_CAST (for C) and std::static_int_cast and 
std::reinterpret_int_cast (for C++) to sal/types.h and brought in 
sal_IntPtr and sal_uIntPtr to sal/types.h from CWS ooo64bit02.  See 
the documentation in sal/types.h for when this new functionality 
should be used.




So, I have extracted all the sal_IntPtr/sal_uIntPtr patches from the 
ooo64bit02 CWS, Martin Kretzschmar's and my diffs, see the 
intptr-*.diff's from http://www.go-oo.org/patches/64bit/ .


I would like to create a CWS for them, let's say 'intptr' to have them 
integrated soon, because this is really essential for the 64bit 
porting. OOo 3.0, the target of 'warnings01', is just too late, and 
nothing else from 'ooo64bit02' is needed to have this in.


Please, who to assign as the QA representative in EIS for this CWS?

At the moment I know that the 'intptr' patches build and work OK on 
x86-64 Linux, and I am in the middle of the x86 Linux build.  We'll 
also have them among the default ooo-build patches to give them proper 
testing by other people.


Thank you,
Jan



I see you have created an issue in the meantime, that is good.  Looking 
at some of the changes at , there 
is little overlap with the changes on CWS warnings01.


I do not know who would be a good QA person, maybe someone else can 
comment on that.


Jörg Sievers (jsi) agreed to do QA on that CWS, and I would volunteer to 
do a code review.



-Stephan


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]