Re: [OSM-dev] WHODIDIT
2012/11/11 Simon Legner simon.leg...@gmail.com: Hi all, I tweaked Zverik's WHODIDIT script to speed-up the queries. These performance improvements are mainly due to the usage of a spatial index in the database. I deployed minutely-synced version on the dev server: http://simon04.dev.openstreetmap.org/whodidit/ For details of the changes made see the repository: https://github.com/simon04/whodidit Feel free to report bugs, suggestions, … Great, it works like a charm. Thanks a lot. -- Cyrille. ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] WHODIDIT
Hi Pierre, The Age drop-down list as a strange behaviour. The html page seems to be updated properly to reflect the Age option selected. But the content of the Age box is not always updated properly. It is possible to select the seven Age options listed, but only the first three are showed properly in the Age box after the user confirms a choice. Up to the week option, the Age option selected appears in the box, thus confirming the user choice. For other options down in the list (ie. Month, Half a year or Eternity), there is a roll back to the beginning of the list. Then 6 hours is showed in the Age box. This same behavior is observed both with mouse or keyboard selection. if I click with the mouse on the down arrow beside the box and select an option, or after a first selection, if I use de down arrow key to go down in the list and press the enter key to confirm my choice. Pierre Thanks for your report. This issue should be fixed now. Cheers, Simon ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] WHODIDIT
Thanks Simon, It is effectively fixed. A second problem. There are areas whitout any report were I know that there are some edits up to recently. See for example http://simon04.dev.openstreetmap.org/whodidit/?zoom=14lat=45.647lon=-72.56572layers=BTTTage=6%20month http://www.openstreetmap.org/browse/way/43563217 http://www.openstreetmap.org/browse/way/132015616 Pierre De : Simon Legner simon.leg...@gmail.com À : dev@openstreetmap.org Envoyé le : Mardi 13 novembre 2012 4h58 Objet : Re: [OSM-dev] WHODIDIT Hi Pierre, The Age drop-down list as a strange behaviour. The html page seems to be updated properly to reflect the Age option selected. But the content of the Age box is not always updated properly. It is possible to select the seven Age options listed, but only the first three are showed properly in the Age box after the user confirms a choice. Up to the week option, the Age option selected appears in the box, thus confirming the user choice. For other options down in the list (ie. Month, Half a year or Eternity), there is a roll back to the beginning of the list. Then 6 hours is showed in the Age box. This same behavior is observed both with mouse or keyboard selection. if I click with the mouse on the down arrow beside the box and select an option, or after a first selection, if I use de down arrow key to go down in the list and press the enter key to confirm my choice. Pierre Thanks for your report. This issue should be fixed now. Cheers, Simon ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] WHODIDIT
Hi Pierre, On 13/11/12 14:38, Pierre Béland wrote: A second problem. There are areas whitout any report were I know that there are some edits up to recently. See for example http://simon04.dev.openstreetmap.org/whodidit/?zoom=14lat=45.647lon=-72.56572layers=BTTTage=6%20month http://www.openstreetmap.org/browse/way/43563217 http://www.openstreetmap.org/browse/way/132015616 In the current implementation, coordinates to colour the tiles are taken from the minutely/hourly diffs. Coordinates are only listed for modified nodes. This means that any change without changing nodes isn't shown in whodidit. It might be worth considering to use augmented diffs https://wiki.openstreetmap.org/wiki/Overpass_API/Augmented_Diffs However, it is not immediately clear which tiles to colour when changing the tags of a very long way and/or modifying a relation … Cheers, Simon ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] WHODIDIT
Yes, to do efficient monitoring of an area, It is of interest to show edits other then nodes. But I understand the technical challenge. There were nodes edited in the area but they are not reported. The last ones are in december 2011. for example : node id='1452468075' timestamp='2011-12-03T19:15:34Z' node id='550058835' timestamp='2011-10-03T20:39:08Z' Pierre De : Simon Legner simon.leg...@gmail.com À : dev@openstreetmap.org dev@openstreetmap.org Cc : Pierre Béland infosbelas-...@yahoo.fr Envoyé le : Mardi 13 novembre 2012 8h53 Objet : Re: [OSM-dev] WHODIDIT Hi Pierre, On 13/11/12 14:38, Pierre Béland wrote: A second problem. There are areas whitout any report were I know that there are some edits up to recently. See for example http://simon04.dev.openstreetmap.org/whodidit/?zoom=14lat=45.647lon=-72.56572layers=BTTTage=6%20month http://www.openstreetmap.org/browse/way/43563217 http://www.openstreetmap.org/browse/way/132015616 In the current implementation, coordinates to colour the tiles are taken from the minutely/hourly diffs. Coordinates are only listed for modified nodes. This means that any change without changing nodes isn't shown in whodidit. It might be worth considering to use augmented diffs https://wiki.openstreetmap.org/wiki/Overpass_API/Augmented_Diffs However, it is not immediately clear which tiles to colour when changing the tags of a very long way and/or modifying a relation … Cheers, Simon ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
[OSM-dev] WHODIDIT
I tweaked Zverik's WHODIDIT script to speed-up the queries. These performance improvements are mainly due to the usage of a spatial index in the database. Did you benchmark it against old version? Is the performance worth doubling the index size and using spatial extensions? To my shame, I didn't ever assume there were spatial functions in MySQL, and wrote around them. To me it looks the speed of queries remained the same (considering your server a bit faster than the one it's currently deployed on). IZ ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] WHODIDIT
Hi! Did you benchmark it against old version? Is the performance worth doubling the index size and using spatial extensions? To my shame, I didn't ever assume there were spatial functions in MySQL, and wrote around them. To me it looks the speed of queries remained the same (considering your server a bit faster than the one it's currently deployed on). I did not perform statistical benchmarks since they are tricky to do due to database caching. However, the »new« script feels to be (much) faster in my area. After panning, the whodidit-tiles appear almost immediately: http://simon04.dev.openstreetmap.org/whodidit/?zoom=12lat=47.25lon=11.4 A very basic benchmark done right now; time was taken after the 5th identical query. I don't know the load of your server right now. Load average on dev.osm.org is 1.81 (15 minutes): $ time curl 'http://simon04.dev.openstreetmap.org/whodidit/scripts/tiles.php?age=7bbox=11.13,47.06,11.66,47.43' /dev/null real0m0.201s $ time curl 'http://zverik.osm.rambler.ru/whodidit/scripts/tiles.php?age=7bbox=11.13,47.06,11.66,47.43' /dev/null real1m0.149s Index size: I think the database size isn't so much an issue right now. If it was, I'd tend to restrict the database to say 1/3/6 months and keeping the (apparently) fast queries instead of dropping the spatial index. Cheers, Simon ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
Re: [OSM-dev] WHODIDIT
Simon, The Age drop-down list as a strange behaviour. The html page seems to be updated properly to reflect the Age option selected. But the content of the Age box is not always updated properly. It is possible to select the seven Age options listed, but only the first three are showed properly in the Age box after the user confirms a choice. Up to the week option, the Age option selected appears in the box, thus confirming the user choice. For other options down in the list (ie. Month, Half a year or Eternity), there is a roll back to the beginning of the list. Then 6 hours is showed in the Age box. This same behavior is observed both with mouse or keyboard selection. if I click with the mouse on the down arrow beside the box and select an option, or after a first selection, if I use de down arrow key to go down in the list and press the enter key to confirm my choice. Pierre Simon Legner simon.legner at gmail.com Sun Nov 11 12:49:26 GMT 2012 Feel free to report bugs, suggestions, Cheers, Simon ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
[OSM-dev] WHODIDIT
Hi all, I tweaked Zverik's WHODIDIT script to speed-up the queries. These performance improvements are mainly due to the usage of a spatial index in the database. I deployed minutely-synced version on the dev server: http://simon04.dev.openstreetmap.org/whodidit/ For details of the changes made see the repository: https://github.com/simon04/whodidit Feel free to report bugs, suggestions, Cheers, Simon ___ dev mailing list dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/dev
