Re: [josm-dev] Unclosed ways
Dirk Stöcker [EMAIL PROTECTED] writes: On Tue, 15 Jul 2008, Matthias Julius wrote: But I also believe to improve the usefulness of the maplint layer it would be good to have a mechanism to ignore certain warnings. That assumes the ignore information can be used by different validation tools. I don't think this is possible without lots of work. I can not comment on that as I don't have any clue about the internals of the validators. But I would have thought that checking for the presence of a certain tag like validator:ignore=no_name should be straight forward since this is what validators do all the time. Of course the spelling and meaning of those tags needs to be coordinated, probably on a wiki page like Map_Features which then could look like: | no_name| Don't warn if element doesn't have a name. | | not_closed | Don't warn if way is not closed. | Validator authors can then decide whether they want to implement that or not. Matthias ___ josm-dev mailing list [EMAIL PROTECTED] http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Unclosed ways
Dirk Stöcker [EMAIL PROTECTED] writes: Well, for sure the checks will produce false positives. That is always a balance between false positives and false negatives (i.e. not reported problems). However, having a number of false positives can clutter up the list of problems and make the whole process ineffective. How about having a tag like note=IGNORE test to tell the validator to ignore a specific false positive? Matthias ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Unclosed ways
On Mon, Jul 14, 2008 at 2:33 PM, Frederik Ramm [EMAIL PROTECTED] wrote: Hi, Well, I was thinking you could mark it as a false positive using the validator_ignore key, which could be used by maplint or other validators to suppress warnings there, too. That key would only apply to a particular OSM entity, not for disabling a test globally. I'm sort of leaning in the direction of having a per-user local list of stuff to ignore, instead of a global list (read: a tag in the database) saying for this object, ignore test so-and-so). Even if this makes *every* user who validates an area look at the problem once - it's preferable to having one user creating a very innovative mapping and then showering it with ignore tags so nobody else will notice... Bye Frederik Frederik, I'm shocked! I thought you were the ultimate advocate of whatever's in the database rules. :-) Anyway, if this is implemented, it would be easy to allow a user to ignore the ignore rules (hee) so you can see all the raw warnings. I was thinking that this would be useful on the maplint layer, not just in the JOSM validator, in order to highlight real problems more easily. There could even be two maplint layers--one with the ignore rules and another raw (i.e., current) version. And you know many eyes make bugs shallow so even if a crazy person went around tagging driveways as motorways (hee) or whatever weirdness would be caught by the validators (multiple overlapping ways, etc.), it wouldn't last long. Karl ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Unclosed ways
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dirk Stöcker wrote: On Thu, 10 Jul 2008, Frederik Ramm wrote: I try to build my unclosed ways tester. Now it seems to run fairly good, but I'm not sure I catched all area types. Currently I have: If I were you I'd write a simple script to parse a planet file and dump the tags of every way where the last node equals the first. Straighforward to write, doesn't even require memory (node id equality is sufficient, node position not required), just a few hours of cpu time. That will give you a very good idea of how people tag areas; of yourse you'll have some circular roads, roundabouts etc. as well but it should be obvious to the human being which are meant so be areas. Well. Actually roundabouts are correct. I made an unclosed way checker and no area checker. And an roundabout should be closed too :-) I will see if I find time for that at weekend. Ciao Quite a few roundabouts aren't closed. Reason being, if it goes over one road then under another, you need different way sections to get layering bridge correct. An example: http://www.openstreetmap.org/?lat=51.49664lon=0.27121zoom=16layers=0B0FFF I don't think they need checking, I just don't like that assumption! Mark -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIePYDJfMmcSPNh94RApfTAJ9XFpkEE4y3gwKu2sQKYw8HePlZYACePNII dtEAYPtV264bM2Yp8Oc5mU4= =+i2Y -END PGP SIGNATURE- ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Unclosed ways
On Sat, 12 Jul 2008, Mark Williams wrote: Quite a few roundabouts aren't closed. Reason being, if it goes over one road then under another, you need different way sections to get layering bridge correct. An example: http://www.openstreetmap.org/?lat=51.49664lon=0.27121zoom=16layers=0B0FFF I don't think they need checking, I just don't like that assumption! Well, for sure the checks will produce false positives. That is always a balance between false positives and false negatives (i.e. not reported problems). The check already helped me to find a non-closed roundabout and lots of natural/build/landuse problems, so I consider it useful. Also different types are reported with different texts, so ignoring certain types is easy. Test it and report problems, when they are really disturbing. But keep in mind, that avoiding false positives always means an increase of false negatives. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list josm-dev@openstreetmap.org http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
Re: [josm-dev] Unclosed ways
On Thu, 10 Jul 2008, Frederik Ramm wrote: I try to build my unclosed ways tester. Now it seems to run fairly good, but I'm not sure I catched all area types. Currently I have: If I were you I'd write a simple script to parse a planet file and dump the tags of every way where the last node equals the first. Straighforward to write, doesn't even require memory (node id equality is sufficient, node position not required), just a few hours of cpu time. That will give you a very good idea of how people tag areas; of yourse you'll have some circular roads, roundabouts etc. as well but it should be obvious to the human being which are meant so be areas. Well. Actually roundabouts are correct. I made an unclosed way checker and no area checker. And an roundabout should be closed too :-) I will see if I find time for that at weekend. Ciao -- http://www.dstoecker.eu/ (PGP key available) ___ josm-dev mailing list [EMAIL PROTECTED] http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/josm-dev
