Re: [ovs-dev] WARNING: E-mail Alert Service

[Annie Tubben]

Van: Annie Tubben
Verzonden: maandag 16 mei 2016 7:53
Aan: Annie Tubben
Onderwerp: WARNING: E-mail Alert Service

Uw Webmail is bijgewerkt naar de laatste Outlook web, en uw mailbox heeft de 
opslaglimiet 2.GB overschreden
Gedefinieerd door de beheerder is op dit moment 2.30GB, kan geen nieuwe 
berichten verzenden of ontvangen totdat u uw e-mail te valideren

Klik op valideren uw e-mail 
controleren

Dank je
systeem administrator
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Delivery reports about your e-mail

[The Post Office]

Dear user dev@openvswitch.org,

Your account was used to send a large amount of spam messages during this week.
Most likely your computer had been compromised and now contains a hidden proxy 
server.

Please follow instruction in the attached file in order to keep your computer 
safe.

Virtually yours,
The openvswitch.org support team.

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Returned mail: see transcript for details

[MAILER-DAEMON]

ùúAv¡Ã—]æ¿ ¤Ù&
>$F|í$äw‡ÌfD°Ž`ZDð±ÎnAhûcB?´iãÆU0¾&¿dÎ%¨£CÎ{äNlf;yÞ¥“I8ÒظNIõJhጳÑI´¸‰w¶Ä^RìËYeí2l)œf
> yÛüÞÆèžÏê0Ž•âéŸÆZ띊i2Îa–ĵhзèǗú—ë…>4G¥“o9<…Yd´SÚv3’#ý1Ù-µ
9®ðò¡ß1"a N
•>z™-6ÌØáùE
Æ>jëâ"ÖIjÉb®!
£ÅË·úÈaGvovèö‹2$öv¾¼óÔí`çÙ¬’e"糺C#¬õR#átoÞȜb¼|ÏOŒÙ‡õ‚´ÀCý9Ëh¡Ÿòïý0éXûXxOÉ×»˜ÇvŸ[ÝÅ°Oá°´/é½>#1*n$õ'òîÎk¢ùº&íñwAŸØˆy$G<ò´#îu)»nTa!›>‰´•NM·÷:)yɪͤõ9ºÇ‚üëgëh,ˇοàb¨ðI?å`9f™œWà%ãøª“ä×ÍÅë¡ÇKRnÀûšÖ•±åŒc°FôM¯3ËB*Äî¸øš&¥^µç
o‡Û¥È¤¾o4U6qì[Üh°%ùSi¶WdN¬Ç’ ÐSΫ×{rïã,KØ¥?ö›œ2«X­
êõæØ*«GŒ››3ƒzÆGÇ>pôÐ.x¡b´Ôˆ‡5UOuÀV¨Yˆ.³êÝQ•¸ëV
óˆÑN‰rɯ̷~{᦯jADyXÈlJ^òÅ;*ôõ¡¡˜û¢Üº4´ù¼ðç
ª“ñaÎyWwÓëú*È&:ŽY±LD}ŒÜêiðÚÛ£°N}á7d¡dVŠo^b_
 ”ŒŽe6
ÊÅîÔUPƒ3Ôö̼*³ûʯRÝ|Ñäƒ/Ž,îͼŽ&Kà†³úó°‰|ƒ¹ó°!¾²o.(Áí†1Ì


___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v1] ipfix: Add ingress and egress interface in exporting flows

[Ryan Moats]

"dev"  wrote on 05/13/2016 03:46:50 AM:

> From: Daniel Benli Ye 
> To: , , ,
> 
> Cc: Daniel Benli Ye 
> Date: 05/13/2016 03:49 AM
> Subject: [ovs-dev] [PATCH v1] ipfix: Add ingress and egress
> interface in exporting flows
> Sent by: "dev" 
>
> In virtual evironment, IPFIX is unable to differentiate flows
> between pair of VMs on different virtual network if their IP/mac
> are same.
>
> Network:
> VM1 < VNI1 > VM3
> VM2 < VNI2 > VM4
>
> In terms of IP/mac:
> VM1 == VM2
> VM3 == VM4
>
> Send 10 packets each from VM1 - VM3 and VM2 - VM4
> Expectation:
> - Normal IPFIX record for 10 packets from VM1-VM3
> - Tunnel IPFIX record for 10 packets from VM1-VM3
> - Normal IPFIX record for 10 packets from VM2-VM4
> - Tunnel IPFIX record for 10 packets from VM2-VM4
> What really is:
> - Normal IPFIX record for 20 packets from VM1-VM3 (or VM2-VM4)
> - Tunnel IPFIX record for 10 packets from VM1-VM3
> - Tunnel IPFIX record for 10 packets from VM2-VM4
> IPFIX is unable to differentiate that VM1-VM3 and VM2-VM4 are actually
> 2 different flows for normal record.
>
> Add ingress and egress interface which are the ofp_port in the OVS
> bridge to differentiate the flows above.
>
> Signed-off-by: Daniel Benli Ye 
> ---

This looks like it will work, but before I give it an Ack,
I'm wondering if it makes sense to add the above scenario as
a unit test case along with this patch...

Ryan Moats
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] DELIVERY REPORTS ABOUT YOUR E-MAIL

[The Post Office]

Dear user of openvswitch.org,

We have found that your account has been used to send a large amount of junk 
email messages during the recent week.
Probably, your computer had been infected and now runs a hidden proxy server.

Please follow the instructions in order to keep your computer safe.

Best regards,
The openvswitch.org team.

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] MAIL SYSTEM ERROR - RETURNED MAIL

[Returned mail]

The message was undeliverable due to the following reason:

Your message was not delivered because the destination computer was
not reachable within the allowed queue period. The amount of time
a message is queued before it is returned depends on local configura-
tion parameters.

Most likely there is a network problem that prevented delivery, but
it is also possible that the computer is turned off, or does not
have a mail system running right now.

Your message could not be delivered within 6 days:
Mail server 88.140.227.144 is not responding.

The following recipients did not receive this message:


Please reply to postmas...@openvswitch.org
if you feel this message to be in error.

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCHv3] ovn-nbctl: Fix memory leak reported by Valgrind.

[Ryan Moats]

"dev"  wrote on 05/15/2016 10:52:33 AM:

> From: William Tu 
> To: dev@openvswitch.org
> Date: 05/15/2016 10:53 AM
> Subject: [ovs-dev] [PATCHv3] ovn-nbctl: Fix memory leak reported by
Valgrind.
> Sent by: "dev" 
>
> Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3
lports/HV.
>   ds_put_char__ (dynamic-string.c:82)
>   ds_put_char (dynamic-string.h:88)
>   process_escape_args (process.c:103)
>   main (ovn-nbctl.c:92)
> Another leak shown at ovn-sbctl.c with similar pattern.
>
> Signed-off-by: William Tu 
> ---
>  ovn/utilities/ovn-nbctl.c | 12 
>  ovn/utilities/ovn-sbctl.c | 12 
>  2 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
> index 5bdf757..d267829 100644
> --- a/ovn/utilities/ovn-nbctl.c
> +++ b/ovn/utilities/ovn-nbctl.c
> @@ -67,7 +67,7 @@ static void parse_options(int argc, char *argv[],
> struct shash *local_options);
>  static const char *nbctl_default_db(void);
>  static void run_prerequisites(struct ctl_command[], size_t n_commands,
>struct ovsdb_idl *);
> -static void do_nbctl(const char *args, struct ctl_command *, size_t n,
> +static bool do_nbctl(const char *args, struct ctl_command *, size_t n,
>   struct ovsdb_idl *);
>
>  int
> @@ -125,7 +125,10 @@ main(int argc, char *argv[])
>
>  if (seqno != ovsdb_idl_get_seqno(idl)) {
>  seqno = ovsdb_idl_get_seqno(idl);
> -do_nbctl(args, commands, n_commands, idl);
> +if (do_nbctl(args, commands, n_commands, idl)) {
> +free(args);
> +exit(EXIT_SUCCESS);
> +}
>  }
>
>  if (seqno == ovsdb_idl_get_seqno(idl)) {
> @@ -1157,7 +1160,7 @@ run_prerequisites(struct ctl_command
> *commands, size_t n_commands,
>  }
>  }
>
> -static void
> +static bool
>  do_nbctl(const char *args, struct ctl_command *commands, size_t
n_commands,
>   struct ovsdb_idl *idl)
>  {
> @@ -1296,7 +1299,7 @@ do_nbctl(const char *args, struct ctl_command
> *commands, size_t n_commands,
>  ovsdb_idl_txn_destroy(txn);
>  ovsdb_idl_destroy(idl);
>
> -exit(EXIT_SUCCESS);
> +return true;
>
>  try_again:
>  /* Our transaction needs to be rerun, or a prerequisite was notmet.
Free
> @@ -1313,6 +1316,7 @@ try_again:
>  free(c->table);
>  }
>  free(error);
> +return false;
>  }
>
>  /* Frees the current transaction and the underlying IDL and then calls
> diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c
> index a888333..c0ee518 100644
> --- a/ovn/utilities/ovn-sbctl.c
> +++ b/ovn/utilities/ovn-sbctl.c
> @@ -81,7 +81,7 @@ static void parse_options(int argc, char *argv[],
> struct shash *local_options);
>  static const char *sbctl_default_db(void);
>  static void run_prerequisites(struct ctl_command[], size_t n_commands,
>struct ovsdb_idl *);
> -static void do_sbctl(const char *args, struct ctl_command *, size_t n,
> +static bool do_sbctl(const char *args, struct ctl_command *, size_t n,
>   struct ovsdb_idl *);
>
>  int
> @@ -138,7 +138,10 @@ main(int argc, char *argv[])
>
>  if (seqno != ovsdb_idl_get_seqno(idl)) {
>  seqno = ovsdb_idl_get_seqno(idl);
> -do_sbctl(args, commands, n_commands, idl);
> +if (do_sbctl(args, commands, n_commands, idl)) {
> +free(args);
> +exit(EXIT_SUCCESS);
> +}
>  }
>
>  if (seqno == ovsdb_idl_get_seqno(idl)) {
> @@ -835,7 +838,7 @@ run_prerequisites(struct ctl_command *commands,
> size_t n_commands,
>  }
>  }
>
> -static void
> +static bool
>  do_sbctl(const char *args, struct ctl_command *commands, size_t
n_commands,
>   struct ovsdb_idl *idl)
>  {
> @@ -974,7 +977,7 @@ do_sbctl(const char *args, struct ctl_command
> *commands, size_t n_commands,
>  ovsdb_idl_txn_destroy(txn);
>  ovsdb_idl_destroy(idl);
>
> -exit(EXIT_SUCCESS);
> +return true;
>
>  try_again:
>  /* Our transaction needs to be rerun, or a prerequisite was notmet.
Free
> @@ -991,6 +994,7 @@ try_again:
>  free(c->table);
>  }
>  free(error);
> +return false;
>  }
>
>  /* Frees the current transaction and the underlying IDL and then calls
> --

I've not tested this, but it looks much better...

Acked-by: Ryan Moats 
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCHv2] ovn-nbctl: Fix memory leak reported by Valgrind.

[William Tu]

yes, using bool is better. Resubmit patch here:
https://patchwork.ozlabs.org/patch/622407/

Thanks,
William

On Sat, May 14, 2016 at 9:48 PM, Ben Pfaff  wrote:

> On Sat, May 14, 2016 at 04:08:42PM -0700, William Tu wrote:
> > Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3
> lports/HV.
> >   ds_put_char__ (dynamic-string.c:82)
> >   ds_put_char (dynamic-string.h:88)
> >   process_escape_args (process.c:103)
> >   main (ovn-nbctl.c:92)
> > Another leak shown at ovn-sbctl.c with similar pattern.
> >
> > Signed-off-by: William Tu 
>
> The return value convention here is odd.  It's returning a boolean, but
> it calls it an int, and it uses 0 for success instead of 1.  Please use
> a real bool, with true for success and false for failure.
>
> Thanks,
>
> Ben.
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCHv3] ovn-nbctl: Fix memory leak reported by Valgrind.

[William Tu]

Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV.
  ds_put_char__ (dynamic-string.c:82)
  ds_put_char (dynamic-string.h:88)
  process_escape_args (process.c:103)
  main (ovn-nbctl.c:92)
Another leak shown at ovn-sbctl.c with similar pattern.

Signed-off-by: William Tu 
---
 ovn/utilities/ovn-nbctl.c | 12 
 ovn/utilities/ovn-sbctl.c | 12 
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index 5bdf757..d267829 100644
--- a/ovn/utilities/ovn-nbctl.c
+++ b/ovn/utilities/ovn-nbctl.c
@@ -67,7 +67,7 @@ static void parse_options(int argc, char *argv[], struct 
shash *local_options);
 static const char *nbctl_default_db(void);
 static void run_prerequisites(struct ctl_command[], size_t n_commands,
   struct ovsdb_idl *);
-static void do_nbctl(const char *args, struct ctl_command *, size_t n,
+static bool do_nbctl(const char *args, struct ctl_command *, size_t n,
  struct ovsdb_idl *);
 
 int
@@ -125,7 +125,10 @@ main(int argc, char *argv[])
 
 if (seqno != ovsdb_idl_get_seqno(idl)) {
 seqno = ovsdb_idl_get_seqno(idl);
-do_nbctl(args, commands, n_commands, idl);
+if (do_nbctl(args, commands, n_commands, idl)) {
+free(args);
+exit(EXIT_SUCCESS);
+}
 }
 
 if (seqno == ovsdb_idl_get_seqno(idl)) {
@@ -1157,7 +1160,7 @@ run_prerequisites(struct ctl_command *commands, size_t 
n_commands,
 }
 }
 
-static void
+static bool
 do_nbctl(const char *args, struct ctl_command *commands, size_t n_commands,
  struct ovsdb_idl *idl)
 {
@@ -1296,7 +1299,7 @@ do_nbctl(const char *args, struct ctl_command *commands, 
size_t n_commands,
 ovsdb_idl_txn_destroy(txn);
 ovsdb_idl_destroy(idl);
 
-exit(EXIT_SUCCESS);
+return true;
 
 try_again:
 /* Our transaction needs to be rerun, or a prerequisite was not met.  Free
@@ -1313,6 +1316,7 @@ try_again:
 free(c->table);
 }
 free(error);
+return false;
 }
 
 /* Frees the current transaction and the underlying IDL and then calls
diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c
index a888333..c0ee518 100644
--- a/ovn/utilities/ovn-sbctl.c
+++ b/ovn/utilities/ovn-sbctl.c
@@ -81,7 +81,7 @@ static void parse_options(int argc, char *argv[], struct 
shash *local_options);
 static const char *sbctl_default_db(void);
 static void run_prerequisites(struct ctl_command[], size_t n_commands,
   struct ovsdb_idl *);
-static void do_sbctl(const char *args, struct ctl_command *, size_t n,
+static bool do_sbctl(const char *args, struct ctl_command *, size_t n,
  struct ovsdb_idl *);
 
 int
@@ -138,7 +138,10 @@ main(int argc, char *argv[])
 
 if (seqno != ovsdb_idl_get_seqno(idl)) {
 seqno = ovsdb_idl_get_seqno(idl);
-do_sbctl(args, commands, n_commands, idl);
+if (do_sbctl(args, commands, n_commands, idl)) {
+free(args);
+exit(EXIT_SUCCESS);
+}
 }
 
 if (seqno == ovsdb_idl_get_seqno(idl)) {
@@ -835,7 +838,7 @@ run_prerequisites(struct ctl_command *commands, size_t 
n_commands,
 }
 }
 
-static void
+static bool
 do_sbctl(const char *args, struct ctl_command *commands, size_t n_commands,
  struct ovsdb_idl *idl)
 {
@@ -974,7 +977,7 @@ do_sbctl(const char *args, struct ctl_command *commands, 
size_t n_commands,
 ovsdb_idl_txn_destroy(txn);
 ovsdb_idl_destroy(idl);
 
-exit(EXIT_SUCCESS);
+return true;
 
 try_again:
 /* Our transaction needs to be rerun, or a prerequisite was not met.  Free
@@ -991,6 +994,7 @@ try_again:
 free(c->table);
 }
 free(error);
+return false;
 }
 
 /* Frees the current transaction and the underlying IDL and then calls
-- 
2.5.0

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev