Re: [ovs-dev] [PATCH] datapath: skip checksum of gro packet

[马啸]

Hi, 


Have the patch been sent?

Thanks.





At 2015-08-21 04:08:06, "Pravin Shelar"  wrote:
>I sent patch attached to the mail. Only direct recipients got the
>patch. I am planning on sending formal patch to netdev mailing list
>soon.
>
>On Wed, Aug 19, 2015 at 9:05 PM, Ben Pfaff  wrote:
>> I don't think you attached the patch.
>>
>> On Mon, Aug 10, 2015 at 10:37:04AM -0700, Pravin Shelar wrote:
>>> On Mon, Aug 10, 2015 at 2:05 AM, Zang MingJie  wrote:
>>> > Any progress? Or direction, maybe I can help.
>>> >
>>> Sorry for late reply. Attached is patch I was working on. Can you try it?
>>>
>>> Thanks,
>>> Pravin.
>>>
>>> > On Mon, Jul 27, 2015 at 1:54 PM Jesse Gross  wrote:
>>> >>
>>> >> On Fri, Jul 24, 2015 at 2:28 AM, Zang MingJie 
>>> >> wrote:
>>> >> > Newer kernel will do gro on vxlan packet, after gro the tcp checksum
>>> >> > encapsulated in the packet is wrong but the origin checksum is already
>>> >> > verified.
>>> >> >
>>> >> > The patch skips verifying checksum of all gro packets.
>>> >>
>>> >> I think this solution is too narrowly tailored to VXLAN and GRO and
>>> >> won't catch all cases.. I believe that Pravin is currently working on
>>> >> a more general solution.
>>> ___
>>> dev mailing list
>>> dev@openvswitch.org
>>> http://openvswitch.org/mailman/listinfo/dev
>>
>___
>dev mailing list
>dev@openvswitch.org
>http://openvswitch.org/mailman/listinfo/dev
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: skip checksum of gro packet

[Pravin Shelar]

I sent patch attached to the mail. Only direct recipients got the
patch. I am planning on sending formal patch to netdev mailing list
soon.

On Wed, Aug 19, 2015 at 9:05 PM, Ben Pfaff b...@nicira.com wrote:
 I don't think you attached the patch.

 On Mon, Aug 10, 2015 at 10:37:04AM -0700, Pravin Shelar wrote:
 On Mon, Aug 10, 2015 at 2:05 AM, Zang MingJie zealot0...@gmail.com wrote:
  Any progress? Or direction, maybe I can help.
 
 Sorry for late reply. Attached is patch I was working on. Can you try it?

 Thanks,
 Pravin.

  On Mon, Jul 27, 2015 at 1:54 PM Jesse Gross je...@nicira.com wrote:
 
  On Fri, Jul 24, 2015 at 2:28 AM, Zang MingJie zealot0...@gmail.com
  wrote:
   Newer kernel will do gro on vxlan packet, after gro the tcp checksum
   encapsulated in the packet is wrong but the origin checksum is already
   verified.
  
   The patch skips verifying checksum of all gro packets.
 
  I think this solution is too narrowly tailored to VXLAN and GRO and
  won't catch all cases.. I believe that Pravin is currently working on
  a more general solution.
 ___
 dev mailing list
 dev@openvswitch.org
 http://openvswitch.org/mailman/listinfo/dev

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: skip checksum of gro packet

[Ben Pfaff]

I don't think you attached the patch.

On Mon, Aug 10, 2015 at 10:37:04AM -0700, Pravin Shelar wrote:
 On Mon, Aug 10, 2015 at 2:05 AM, Zang MingJie zealot0...@gmail.com wrote:
  Any progress? Or direction, maybe I can help.
 
 Sorry for late reply. Attached is patch I was working on. Can you try it?
 
 Thanks,
 Pravin.
 
  On Mon, Jul 27, 2015 at 1:54 PM Jesse Gross je...@nicira.com wrote:
 
  On Fri, Jul 24, 2015 at 2:28 AM, Zang MingJie zealot0...@gmail.com
  wrote:
   Newer kernel will do gro on vxlan packet, after gro the tcp checksum
   encapsulated in the packet is wrong but the origin checksum is already
   verified.
  
   The patch skips verifying checksum of all gro packets.
 
  I think this solution is too narrowly tailored to VXLAN and GRO and
  won't catch all cases.. I believe that Pravin is currently working on
  a more general solution.
 ___
 dev mailing list
 dev@openvswitch.org
 http://openvswitch.org/mailman/listinfo/dev

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: skip checksum of gro packet

[Pravin Shelar]

On Mon, Aug 10, 2015 at 2:05 AM, Zang MingJie zealot0...@gmail.com wrote:
 Any progress? Or direction, maybe I can help.

Sorry for late reply. Attached is patch I was working on. Can you try it?

Thanks,
Pravin.

 On Mon, Jul 27, 2015 at 1:54 PM Jesse Gross je...@nicira.com wrote:

 On Fri, Jul 24, 2015 at 2:28 AM, Zang MingJie zealot0...@gmail.com
 wrote:
  Newer kernel will do gro on vxlan packet, after gro the tcp checksum
  encapsulated in the packet is wrong but the origin checksum is already
  verified.
 
  The patch skips verifying checksum of all gro packets.

 I think this solution is too narrowly tailored to VXLAN and GRO and
 won't catch all cases.. I believe that Pravin is currently working on
 a more general solution.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: skip checksum of gro packet

[Zang MingJie]

Any progress? Or direction, maybe I can help.

On Mon, Jul 27, 2015 at 1:54 PM Jesse Gross je...@nicira.com wrote:

 On Fri, Jul 24, 2015 at 2:28 AM, Zang MingJie zealot0...@gmail.com
 wrote:
  Newer kernel will do gro on vxlan packet, after gro the tcp checksum
  encapsulated in the packet is wrong but the origin checksum is already
  verified.
 
  The patch skips verifying checksum of all gro packets.

 I think this solution is too narrowly tailored to VXLAN and GRO and
 won't catch all cases.. I believe that Pravin is currently working on
 a more general solution.

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: skip checksum of gro packet

[Jesse Gross]

On Fri, Jul 24, 2015 at 2:28 AM, Zang MingJie zealot0...@gmail.com wrote:
 Newer kernel will do gro on vxlan packet, after gro the tcp checksum
 encapsulated in the packet is wrong but the origin checksum is already
 verified.

 The patch skips verifying checksum of all gro packets.

I think this solution is too narrowly tailored to VXLAN and GRO and
won't catch all cases.. I believe that Pravin is currently working on
a more general solution.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] datapath: skip checksum of gro packet

[Zang MingJie]

Newer kernel will do gro on vxlan packet, after gro the tcp checksum
encapsulated in the packet is wrong but the origin checksum is already
verified.

The patch skips verifying checksum of all gro packets.
---
 datapath/vport-vxlan.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/datapath/vport-vxlan.c b/datapath/vport-vxlan.c
index eff7ca2..ba74ab2 100644
--- a/datapath/vport-vxlan.c
+++ b/datapath/vport-vxlan.c
@@ -87,6 +87,10 @@ static void vxlan_rcv(struct vxlan_sock *vs, struct sk_buff 
*skb,
   udp_hdr(skb)-source, udp_hdr(skb)-dest,
   key, flags, opts, sizeof(opts));
 
+   /* skip verifying checksum of gro packets */
+   if (skb_shinfo(skb)-gso_segs)
+   skb-ip_summed = CHECKSUM_UNNECESSARY;
+
ovs_vport_receive(vport, skb, tun_info);
 }
 
-- 
2.1.4

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev