Re: [ovs-dev] [PATCH] dpif-netdev: Fix xps revalidation.

[Daniele Di Proietto]

Thanks for the fix, applied to master!




On 29/07/2016 01:07, "Ilya Maximets"  wrote:

>Revalidation should work in case of 'dynamic_txqs == true'.
>
>Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) 
>implementation.")
>Signed-off-by: Ilya Maximets 
>---
> lib/dpif-netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
>index 828171e..c446ae8 100644
>--- a/lib/dpif-netdev.c
>+++ b/lib/dpif-netdev.c
>@@ -4193,7 +4193,7 @@ dpif_netdev_xps_revalidate_pmd(const struct 
>dp_netdev_pmd_thread *pmd,
> long long interval;
> 
> HMAP_FOR_EACH (tx, node, >port_cache) {
>-if (tx->port->dynamic_txqs) {
>+if (!tx->port->dynamic_txqs) {
> continue;
> }
> interval = now - tx->last_used;
>-- 
>2.7.4
>
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] dpif-netdev: Fix xps revalidation.

[Ilya Maximets]

Revalidation should work in case of 'dynamic_txqs == true'.

Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) 
implementation.")
Signed-off-by: Ilya Maximets 
---
 lib/dpif-netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 828171e..c446ae8 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -4193,7 +4193,7 @@ dpif_netdev_xps_revalidate_pmd(const struct 
dp_netdev_pmd_thread *pmd,
 long long interval;
 
 HMAP_FOR_EACH (tx, node, >port_cache) {
-if (tx->port->dynamic_txqs) {
+if (!tx->port->dynamic_txqs) {
 continue;
 }
 interval = now - tx->last_used;
-- 
2.7.4

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev