Re: [ovs-dev] [PATCH] test-netlink-conntrack: Fix sparse warning.

2016-08-03 Thread Daniele Di Proietto 





On 03/08/2016 10:54, "Joe Stringer"  wrote:

>On 3 August 2016 at 10:50, Daniele Di Proietto  wrote:
>> On some systems I get a sparse warning when compiling
>> tests/test-netlink-conntrack.c
>>
>> /usr/include/x86_64-linux-gnu/sys/cdefs.h:307:10: warning: preprocessor
>> token __always_inline redefined
>> /usr/include/linux/stddef.h:4:9: this was the original definition
>>
>> The problem seems to be that Linux upstream commit
>> 283d75737837("uapi/linux/stddef.h: Provide __always_inline to userspace
>> headers") introduced __always_inline in stddef.h, but glibc headers
>> didn't like that until e0835a5354ab("Bug 20215: Always undefine
>> __always_inline before defining it.").
>>
>> This commit works around the issue by including a glibc header before a
>> kernel header.
>>
>> Fixes: 2c06d9a927c5("ovstest: Add test-netlink-conntrack command.")
>> Reported-by: Joe Stringer 
>> Signed-off-by: Daniele Di Proietto 
>
>Thanks.
>
>Acked-by: Joe Stringer 

Thanks, applied to master and branch-2.5
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] test-netlink-conntrack: Fix sparse warning.

2016-08-03 Thread Joe Stringer 
On 3 August 2016 at 10:50, Daniele Di Proietto  wrote:
> On some systems I get a sparse warning when compiling
> tests/test-netlink-conntrack.c
>
> /usr/include/x86_64-linux-gnu/sys/cdefs.h:307:10: warning: preprocessor
> token __always_inline redefined
> /usr/include/linux/stddef.h:4:9: this was the original definition
>
> The problem seems to be that Linux upstream commit
> 283d75737837("uapi/linux/stddef.h: Provide __always_inline to userspace
> headers") introduced __always_inline in stddef.h, but glibc headers
> didn't like that until e0835a5354ab("Bug 20215: Always undefine
> __always_inline before defining it.").
>
> This commit works around the issue by including a glibc header before a
> kernel header.
>
> Fixes: 2c06d9a927c5("ovstest: Add test-netlink-conntrack command.")
> Reported-by: Joe Stringer 
> Signed-off-by: Daniele Di Proietto 

Thanks.

Acked-by: Joe Stringer 
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] test-netlink-conntrack: Fix sparse warning.

2016-08-03 Thread Daniele Di Proietto 
On some systems I get a sparse warning when compiling
tests/test-netlink-conntrack.c

/usr/include/x86_64-linux-gnu/sys/cdefs.h:307:10: warning: preprocessor
token __always_inline redefined
/usr/include/linux/stddef.h:4:9: this was the original definition

The problem seems to be that Linux upstream commit
283d75737837("uapi/linux/stddef.h: Provide __always_inline to userspace
headers") introduced __always_inline in stddef.h, but glibc headers
didn't like that until e0835a5354ab("Bug 20215: Always undefine
__always_inline before defining it.").

This commit works around the issue by including a glibc header before a
kernel header.

Fixes: 2c06d9a927c5("ovstest: Add test-netlink-conntrack command.")
Reported-by: Joe Stringer 
Signed-off-by: Daniele Di Proietto 
---
 tests/test-netlink-conntrack.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/test-netlink-conntrack.c b/tests/test-netlink-conntrack.c
index 62bef13..f0d48f7 100644
--- a/tests/test-netlink-conntrack.c
+++ b/tests/test-netlink-conntrack.c
@@ -16,6 +16,7 @@
 
 #include 
 
+#include 
 #include 
 
 #include "ct-dpif.h"
-- 
2.8.1

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev