Re: [ovs-dev] [PATCH 3/3] check-kernel: Remove '-d' from TESTSUITEFLAGS.

2016-08-05 Thread Daniele Di Proietto 





On 05/08/2016 10:18, "Andy Zhou"  wrote:

>
>
>On Thu, Aug 4, 2016 at 6:43 PM, Daniele Di Proietto 
> wrote:
>
>The '-d' flag tells autotest to always keep the testcase output, but
>prevents '--recheck' from working.  If a user wants to always keep the
>output from the tests, the '-d' flag can be passed explicitly.  This is
>more in line with other test make target ('check',
>'check-system-userspace').
>
>CC: Andy Zhou 
>Signed-off-by: Daniele Di Proietto 
>---
> tests/automake.mk  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/automake.mk  b/tests/automake.mk 
>
>index a9ebf91..5d12ae5 100644
>--- a/tests/automake.mk 
>+++ b/tests/automake.mk 
>@@ -243,7 +243,7 @@ EXTRA_DIST += tests/run-ryu
>
> # Run kmod tests. Assume kernel modules has been installed or linked into the 
> kernel
> check-kernel: all tests/atconfig tests/atlocal $(SYSTEM_KMOD_TESTSUITE)
>-   $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests  
>AUTOTEST_PATH='$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS) -j1
>+   $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests  
>AUTOTEST_PATH='$(AUTOTEST_PATH)' $(TESTSUITEFLAGS) -j1
>
> # Testing the out of tree Kernel module
> check-kmod: all tests/atconfig tests/atlocal $(SYSTEM_KMOD_TESTSUITE)
>
>
>
>
>LGTM
>Acked-by: Andy Zhou 

Thanks, pushed to master
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] check-kernel: Remove '-d' from TESTSUITEFLAGS.

2016-08-05 Thread Andy Zhou 
On Thu, Aug 4, 2016 at 6:43 PM, Daniele Di Proietto 
wrote:

> The '-d' flag tells autotest to always keep the testcase output, but
> prevents '--recheck' from working.  If a user wants to always keep the
> output from the tests, the '-d' flag can be passed explicitly.  This is
> more in line with other test make target ('check',
> 'check-system-userspace').
>
> CC: Andy Zhou 
> Signed-off-by: Daniele Di Proietto 
> ---
>  tests/automake.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/automake.mk b/tests/automake.mk
> index a9ebf91..5d12ae5 100644
> --- a/tests/automake.mk
> +++ b/tests/automake.mk
> @@ -243,7 +243,7 @@ EXTRA_DIST += tests/run-ryu
>
>  # Run kmod tests. Assume kernel modules has been installed or linked into
> the kernel
>  check-kernel: all tests/atconfig tests/atlocal $(SYSTEM_KMOD_TESTSUITE)
> -   $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests
> AUTOTEST_PATH='$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS) -j1
> +   $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests
> AUTOTEST_PATH='$(AUTOTEST_PATH)' $(TESTSUITEFLAGS) -j1
>
>  # Testing the out of tree Kernel module
>  check-kmod: all tests/atconfig tests/atlocal $(SYSTEM_KMOD_TESTSUITE)
>

LGTM
Acked-by: Andy Zhou 
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 3/3] check-kernel: Remove '-d' from TESTSUITEFLAGS.

2016-08-04 Thread Daniele Di Proietto 
The '-d' flag tells autotest to always keep the testcase output, but
prevents '--recheck' from working.  If a user wants to always keep the
output from the tests, the '-d' flag can be passed explicitly.  This is
more in line with other test make target ('check',
'check-system-userspace').

CC: Andy Zhou 
Signed-off-by: Daniele Di Proietto 
---
 tests/automake.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/automake.mk b/tests/automake.mk
index a9ebf91..5d12ae5 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -243,7 +243,7 @@ EXTRA_DIST += tests/run-ryu
 
 # Run kmod tests. Assume kernel modules has been installed or linked into the 
kernel
 check-kernel: all tests/atconfig tests/atlocal $(SYSTEM_KMOD_TESTSUITE)
-   $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests  
AUTOTEST_PATH='$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS) -j1
+   $(SHELL) '$(SYSTEM_KMOD_TESTSUITE)' -C tests  
AUTOTEST_PATH='$(AUTOTEST_PATH)' $(TESTSUITEFLAGS) -j1
 
 # Testing the out of tree Kernel module
 check-kmod: all tests/atconfig tests/atlocal $(SYSTEM_KMOD_TESTSUITE)
-- 
2.8.1

___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev