Re: [ovs-dev] [PATCH] unixctl: Log commands received and their replies (at debug level).

[Ben Pfaff]

On Mon, Mar 07, 2016 at 01:00:28PM -0800, Justin Pettit wrote:
> 
> > On Mar 7, 2016, at 11:19 AM, Ben Pfaff  wrote:
> > 
> > +if (VLOG_IS_DBG_ENABLED()) {
> > +char *params = json_to_string(request->params, 0);
> > +char *id = json_to_string(request->id, 0);
> > +VLOG_DBG("received request %s%s, id=%s", request->method, params, 
> > id);
> > +free(params);
> > +free(id);
> > +}
> 
> Not a big deal, but the containing function has a variable called "params" of 
> a different type.

Thank you for pointing that out.

I added an _s suffix to params and id here.

> Acked-by: Justin Pettit 

Thanks, I applied this to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] unixctl: Log commands received and their replies (at debug level).

[Justin Pettit]

> On Mar 7, 2016, at 11:19 AM, Ben Pfaff  wrote:
> 
> +if (VLOG_IS_DBG_ENABLED()) {
> +char *params = json_to_string(request->params, 0);
> +char *id = json_to_string(request->id, 0);
> +VLOG_DBG("received request %s%s, id=%s", request->method, params, 
> id);
> +free(params);
> +free(id);
> +}

Not a big deal, but the containing function has a variable called "params" of a 
different type.

Acked-by: Justin Pettit 

--Justin



___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev