Re: Code Conventions
Hi Gurkan, I think somewhere in Apache is a wiki page which has some good information on this topic as well -Matthias On Wed, Feb 10, 2010 at 6:44 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Hello folks; While committing code into our code base, it is good idea to have following and obey our formatter rules 1* Remove unused imports 2* Try to get rid of generic warnings 3* Use correct line bracing and tab space 4* Use SVN properties Thanks; --Gurkan ___ Yahoo! Türkiye açıldı! http://yahoo.com.tr İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: Code Conventions
Hello, Matthias, if you can get the link, i'd like to read the page. Jean-Louis 2010/2/10 Matthias Wessendorf mat...@apache.org: Hi Gurkan, I think somewhere in Apache is a wiki page which has some good information on this topic as well -Matthias On Wed, Feb 10, 2010 at 6:44 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Hello folks; While committing code into our code base, it is good idea to have following and obey our formatter rules 1* Remove unused imports 2* Try to get rid of generic warnings 3* Use correct line bracing and tab space 4* Use SVN properties Thanks; --Gurkan ___ Yahoo! Türkiye açıldı! http://yahoo.com.tr İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
[jira] Created: (OWB-275) remove unused imports and cleanup code
remove unused imports and cleanup code -- Key: OWB-275 URL: https://issues.apache.org/jira/browse/OWB-275 Project: OpenWebBeans Issue Type: Bug Affects Versions: M3 Reporter: Mark Struberg Assignee: Mark Struberg Fix For: M4 general code cleanup task for M4 release. * remove unused imports * use standars ASL headers in our sources * check maven reports and cleanup as much as possible -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Code Conventions
Along these lines, what is the general feeling about committing changes without an associated JIRA issue? I've been opening sometimes trivial JIRA issues in order to associate them with any commit I do, but I'm not sure if this is required or not. Also I've found the Eclipse formatter you sent a while back to be very useful for auto-formatting new files. Perhaps we should add a link to this from the website for any new developers. Sincerely, Joe On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu gurkanerdo...@yahoo.comwrote: Hello folks; While committing code into our code base, it is good idea to have following and obey our formatter rules 1* Remove unused imports 2* Try to get rid of generic warnings 3* Use correct line bracing and tab space 4* Use SVN properties Thanks; --Gurkan ___ Yahoo! Türkiye açıldı! http://yahoo.com.tr İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
Re: Code Conventions
Hi Joe, Along these lines, what is the general feeling about committing changes without an associated JIRA issue? We must not do :) Actually we have to always include JIRA-Id for committing but we are sometimes lazy. From now on, as a general rule; before committing some codes, always attach JIRA id if it exists, and if there is no JIRA create a new one. WDYT? Also I've found the Eclipse formatter you sent a while back to be very useful for auto-formatting new files. Perhaps we should add a link to this from the website for any new developers. Yes, it is very useful. Otherwise every committer use run its own formatter rules :) Thanks; --Gurkan 10 Şubat 2010 16:56 tarihinde Joseph Bergmark bergm...@gmail.com yazdı: Along these lines, what is the general feeling about committing changes without an associated JIRA issue? I've been opening sometimes trivial JIRA issues in order to associate them with any commit I do, but I'm not sure if this is required or not. Also I've found the Eclipse formatter you sent a while back to be very useful for auto-formatting new files. Perhaps we should add a link to this from the website for any new developers. Sincerely, Joe On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Hello folks; While committing code into our code base, it is good idea to have following and obey our formatter rules 1* Remove unused imports 2* Try to get rid of generic warnings 3* Use correct line bracing and tab space 4* Use SVN properties Thanks; --Gurkan ___ Yahoo! Türkiye açıldı! http://yahoo.com.tr İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! -- Gurkan Erdogdu http://gurkanerdogdu.blogspot.com
[jira] Updated: (OWB-273) Given class is not annotated with @Alternative Exception when try to enable alternative producer/producer field beans
[
https://issues.apache.org/jira/browse/OWB-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YING WANG updated OWB-273:
--
Attachment: alternative2.jar
test cases around alternative/producer/disposes.
Given class is not annotated with @Alternative Exception when try to enable
alternative producer/producer field beans
-
Key: OWB-273
URL: https://issues.apache.org/jira/browse/OWB-273
Project: OpenWebBeans
Issue Type: Bug
Components: Injection and Lookup
Affects Versions: M3
Reporter: YING WANG
Assignee: Gurkan Erdogdu
Priority: Minor
Attachments: alternative2.jar
I have an alternative producer bean as follow. It seems that the
AlternativesManager.addClazzAlternative( ) requires @Alternative to be
annotated at the class level even if it is an alternative producer and throws
the following exception.
It is not necessary to add @Alternative at both class level and method level
for a producer/producer field beans, right?
=EXCEPTION===
org.apache.webbeans.exception.WebBeansConfigurationException: Given class :
com.jcdi.test.alternative.producerbased.AlternativeBeanProducer2 is not
annotated with @Alternative
at
org.apache.webbeans.inject.AlternativesManager.addClazzAlternative(AlternativesManager.java:89)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.addAlternative(WebBeansXMLConfigurator.java:622)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureAlternativesElement(WebBeansXMLConfigurator.java:587)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:323)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:221)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configure(WebBeansXMLConfigurator.java:157)
at
org.apache.webbeans.config.BeansDeployer.deployFromXML(BeansDeployer.java:384)
at
org.apache.webbeans.config.BeansDeployer.deploy(BeansDeployer.java:139)
at
org.apache.webbeans.lifecycle.WebApplicationLifeCycle.applicationStarted(WebApplicationLifeCycle.java:196)
at
org.apache.webbeans.servlet.WebBeansConfigurationListener.contextInitialized(WebBeansConfigurationListener.java:60)
===THE ALTERNATIVE PRODUCER
BEAN===
public class AlternativeBeanProducer2 {
public @Produces @Alternative @QualifierProducerBased IProducedBean
generateBean2(@New AlternativeBeanClass1 beanClass) {
return new AbstractProducedBean(beanClass, this);
}
/*
public void dumpBean2(
@Disposes @QualifierProducer IProducedBean bean, ILog
log) {
log.log(bean + is dumped by
AlternativeBeanProducer2);
}
*/
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-273) Given class is not annotated with @Alternative Exception when try to enable alternative producer/producer field beans
[ https://issues.apache.org/jira/browse/OWB-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12832062#action_12832062 ] YING WANG commented on OWB-273: --- Thanks a lot, Gurkan. So the only way to enable an alternative producer bean is to annotate both its class and producer method and enble the class in beans.xml? I also create a few test cases around alternative/producer/diposes and found some test cases throws exceptions. Could you please help review and see if they are bugs or valid exceptions? 1. AlternativeTest1, includes DefaultBeanProducer and AlternativeBeanProducer1 and I have moved @Alternative from the producer method to the class level. And AlternativeBeanProducer1 is NOT selected. Result: AmbiguousResolutionException. Ying's comments: Shouldn't the producer bean in AlternativeBeanProducer1 be disabled? According to 5.1.2, a bean is enabled if it is not a producer method of a disabled bean. 2. AlternativeTest2, includes DefaultBeanProducer and AlternativeBeanProducer2 and have @Alternative annotated at class and producer method. And AlternativeBeanProducer2 is NOT selected. Result: DefaultBeanProducer is used(expected). However the disposes method is not invoked. Ying's comments: Not sure why disposes of DefaultBeanProducer is not invoked. 3. AlternativeTest3, includes DefaultBeanProducer and AlternativeBeanProducer3 and has disposes method defined in both. AlternativeBeanProducer3 is NOT selected. Result: Producer method component of the disposal method : dumpBean3 in class : org.apache.webbeans.newtests.alternatives2.AlternativeBeanProducer3 must be in the same class! Ying's comments: Shouldn't both producer and dispose methods in AlternativeBeanProducer3 be ignored since the AlternativeBeanProducer3 is disabled? the spec did not mention much about how disposes method works in a alternative bean. 4. AlternativeTest4, includes DefaultBeanProducerWithoutDisposes, AlternativeBeanProducer3 and AlternativeBeanProducer4 . Have disposes method defined in 2 alternative classes. AlternativeBeanProducer3 and AlternativeBeanProducer4 are NOT selected. Result: UnsatisfiedResolutionException: Producer method component of the disposal method : dumpBean3 in class : org.apache.webbeans.newtests.alternatives2.AlternativeBeanProducer3. annot find bean interface org.apache.webbeans.newtests.alternatives2.IProducedBean with qualifier [...@org.apache.webbeans.newtests.alternatives2.qualifierproducerbased()] Ying's comments: same as 3. 5. AlternativeTest5, same as above except AlternativeBeanProducer4 is enabled. Result: same as 4. Given class is not annotated with @Alternative Exception when try to enable alternative producer/producer field beans - Key: OWB-273 URL: https://issues.apache.org/jira/browse/OWB-273 Project: OpenWebBeans Issue Type: Bug Components: Injection and Lookup Affects Versions: M3 Reporter: YING WANG Assignee: Gurkan Erdogdu Priority: Minor Attachments: alternative2.jar I have an alternative producer bean as follow. It seems that the AlternativesManager.addClazzAlternative( ) requires @Alternative to be annotated at the class level even if it is an alternative producer and throws the following exception. It is not necessary to add @Alternative at both class level and method level for a producer/producer field beans, right? =EXCEPTION=== org.apache.webbeans.exception.WebBeansConfigurationException: Given class : com.jcdi.test.alternative.producerbased.AlternativeBeanProducer2 is not annotated with @Alternative at org.apache.webbeans.inject.AlternativesManager.addClazzAlternative(AlternativesManager.java:89) at org.apache.webbeans.xml.WebBeansXMLConfigurator.addAlternative(WebBeansXMLConfigurator.java:622) at org.apache.webbeans.xml.WebBeansXMLConfigurator.configureAlternativesElement(WebBeansXMLConfigurator.java:587) at org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:323) at org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:221) at org.apache.webbeans.xml.WebBeansXMLConfigurator.configure(WebBeansXMLConfigurator.java:157) at org.apache.webbeans.config.BeansDeployer.deployFromXML(BeansDeployer.java:384) at
Re: Code Conventions
Hi folks! For _small_ cleanup stuff, you can use OWB-275 which I created today in the morning extra for that purpose :) LieGrue, strub --- Gurkan Erdogdu cgurkanerdo...@gmail.com schrieb am Mi, 10.2.2010: Von: Gurkan Erdogdu cgurkanerdo...@gmail.com Betreff: Re: Code Conventions An: dev@openwebbeans.apache.org Datum: Mittwoch, 10. Februar 2010, 16:19 Hi Joe, Along these lines, what is the general feeling about committing changes without an associated JIRA issue? We must not do :) Actually we have to always include JIRA-Id for committing but we are sometimes lazy. From now on, as a general rule; before committing some codes, always attach JIRA id if it exists, and if there is no JIRA create a new one. WDYT? Also I've found the Eclipse formatter you sent a while back to be very useful for auto-formatting new files. Perhaps we should add a link to this from the website for any new developers. Yes, it is very useful. Otherwise every committer use run its own formatter rules :) Thanks; --Gurkan 10 Şubat 2010 16:56 tarihinde Joseph Bergmark bergm...@gmail.com yazdı: Along these lines, what is the general feeling about committing changes without an associated JIRA issue? I've been opening sometimes trivial JIRA issues in order to associate them with any commit I do, but I'm not sure if this is required or not. Also I've found the Eclipse formatter you sent a while back to be very useful for auto-formatting new files. Perhaps we should add a link to this from the website for any new developers. Sincerely, Joe On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Hello folks; While committing code into our code base, it is good idea to have following and obey our formatter rules 1* Remove unused imports 2* Try to get rid of generic warnings 3* Use correct line bracing and tab space 4* Use SVN properties Thanks; --Gurkan ___ Yahoo! Türkiye açıldı! http://yahoo.com.tr İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor! -- Gurkan Erdogdu http://gurkanerdogdu.blogspot.com __ Do You Yahoo!? Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. http://mail.yahoo.com
[jira] Commented: (OWB-273) Given class is not annotated with @Alternative Exception when try to enable alternative producer/producer field beans
[
https://issues.apache.org/jira/browse/OWB-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12832170#action_12832170
]
Gurkan Erdogdu commented on OWB-273:
As you said disposal methods are not cleared when @Alternative on. Currently it
throws Exception because of not finding producers. I have applied your tests
and did small correction. Thanks; I try to commit but SVN is off :(
Given class is not annotated with @Alternative Exception when try to enable
alternative producer/producer field beans
-
Key: OWB-273
URL: https://issues.apache.org/jira/browse/OWB-273
Project: OpenWebBeans
Issue Type: Bug
Components: Injection and Lookup
Affects Versions: M3
Reporter: YING WANG
Assignee: Gurkan Erdogdu
Priority: Minor
Attachments: alternative2.jar
I have an alternative producer bean as follow. It seems that the
AlternativesManager.addClazzAlternative( ) requires @Alternative to be
annotated at the class level even if it is an alternative producer and throws
the following exception.
It is not necessary to add @Alternative at both class level and method level
for a producer/producer field beans, right?
=EXCEPTION===
org.apache.webbeans.exception.WebBeansConfigurationException: Given class :
com.jcdi.test.alternative.producerbased.AlternativeBeanProducer2 is not
annotated with @Alternative
at
org.apache.webbeans.inject.AlternativesManager.addClazzAlternative(AlternativesManager.java:89)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.addAlternative(WebBeansXMLConfigurator.java:622)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureAlternativesElement(WebBeansXMLConfigurator.java:587)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:323)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:221)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configure(WebBeansXMLConfigurator.java:157)
at
org.apache.webbeans.config.BeansDeployer.deployFromXML(BeansDeployer.java:384)
at
org.apache.webbeans.config.BeansDeployer.deploy(BeansDeployer.java:139)
at
org.apache.webbeans.lifecycle.WebApplicationLifeCycle.applicationStarted(WebApplicationLifeCycle.java:196)
at
org.apache.webbeans.servlet.WebBeansConfigurationListener.contextInitialized(WebBeansConfigurationListener.java:60)
===THE ALTERNATIVE PRODUCER
BEAN===
public class AlternativeBeanProducer2 {
public @Produces @Alternative @QualifierProducerBased IProducedBean
generateBean2(@New AlternativeBeanClass1 beanClass) {
return new AbstractProducedBean(beanClass, this);
}
/*
public void dumpBean2(
@Disposes @QualifierProducer IProducedBean bean, ILog
log) {
log.log(bean + is dumped by
AlternativeBeanProducer2);
}
*/
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OWB-273) Given class is not annotated with @Alternative Exception when try to enable alternative producer/producer field beans
[
https://issues.apache.org/jira/browse/OWB-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gurkan Erdogdu closed OWB-273.
--
Resolution: Fixed
Fix Version/s: M4
YING, thanks for comments and test cases. I have committed it with removing
disposal methods. One point, yor xml uses old style of OWB, I changed it as
follows beans/beans instead of WebBeans/WebBeans
Given class is not annotated with @Alternative Exception when try to enable
alternative producer/producer field beans
-
Key: OWB-273
URL: https://issues.apache.org/jira/browse/OWB-273
Project: OpenWebBeans
Issue Type: Bug
Components: Injection and Lookup
Affects Versions: M3
Reporter: YING WANG
Assignee: Gurkan Erdogdu
Priority: Minor
Fix For: M4
Attachments: alternative2.jar
I have an alternative producer bean as follow. It seems that the
AlternativesManager.addClazzAlternative( ) requires @Alternative to be
annotated at the class level even if it is an alternative producer and throws
the following exception.
It is not necessary to add @Alternative at both class level and method level
for a producer/producer field beans, right?
=EXCEPTION===
org.apache.webbeans.exception.WebBeansConfigurationException: Given class :
com.jcdi.test.alternative.producerbased.AlternativeBeanProducer2 is not
annotated with @Alternative
at
org.apache.webbeans.inject.AlternativesManager.addClazzAlternative(AlternativesManager.java:89)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.addAlternative(WebBeansXMLConfigurator.java:622)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureAlternativesElement(WebBeansXMLConfigurator.java:587)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:323)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configureSpecSpecific(WebBeansXMLConfigurator.java:221)
at
org.apache.webbeans.xml.WebBeansXMLConfigurator.configure(WebBeansXMLConfigurator.java:157)
at
org.apache.webbeans.config.BeansDeployer.deployFromXML(BeansDeployer.java:384)
at
org.apache.webbeans.config.BeansDeployer.deploy(BeansDeployer.java:139)
at
org.apache.webbeans.lifecycle.WebApplicationLifeCycle.applicationStarted(WebApplicationLifeCycle.java:196)
at
org.apache.webbeans.servlet.WebBeansConfigurationListener.contextInitialized(WebBeansConfigurationListener.java:60)
===THE ALTERNATIVE PRODUCER
BEAN===
public class AlternativeBeanProducer2 {
public @Produces @Alternative @QualifierProducerBased IProducedBean
generateBean2(@New AlternativeBeanClass1 beanClass) {
return new AbstractProducedBean(beanClass, this);
}
/*
public void dumpBean2(
@Disposes @QualifierProducer IProducedBean bean, ILog
log) {
log.log(bean + is dumped by
AlternativeBeanProducer2);
}
*/
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-277) Owb on Google App Engine
[ https://issues.apache.org/jira/browse/OWB-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12832410#action_12832410 ] Mark Struberg commented on OWB-277: --- hi Ali! Txs for working on that area, that's a really cool thing! The issue you see is a known problem in jetty-6.0. Please see jira.codehaus.org/browse/JETTY-910 for further information. Owb on Google App Engine Key: OWB-277 URL: https://issues.apache.org/jira/browse/OWB-277 Project: OpenWebBeans Issue Type: New Feature Components: New Features Affects Versions: 1.0.0 Environment: Google App Engine 1.3.0 Reporter: Ali Ok Assignee: Gurkan Erdogdu Priority: Minor Attachments: patches.zip Implement support for Google App Engine -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
