Re: OWB integration with OpenEJB Tomcat Integration Code

2010-04-15 Thread Gurkan Erdogdu
Hello;

Think is that I bundle OWB jars into openejb.war, therefore those jars are
added to deployed web application  or cataliane classpath.

There is no need to add OWB jars into deployed web applications, because
they are added by integration at runtime.

One more thing, Currently there is a problem with interceptors ordering, I
will attach a new code.

Thanks;

--Gurkan

2010/4/15 Jean-Louis MONTEIRO 

>
> Gurkan,
>
> i finally got OpenEJB and OpenWebBeans compilation working.
> I do have some questions regarding the packaging.
>
> With OWB integration, the tomcat openejb webapp now depends on OWB modules.
> After assembly, we get a 30 Mo jar file instead of 20 Mo before. Yet, dunno
> if it's relevant or not to leave the standard OpenEJB webapp and create a
> new one for the web profile.
>
> Moreover, after generating the assembly i noticed some changes preventing
> OpenEJB startup (WEB-INF/lib contains to many openejb jar files).
>
> Again, dunno if it's related or not to the OWB integration.
>
> I'd like to get your opinion regarding the packaging.
> Should we package an all in one webapp for web profile ?
> Should OWB jar files be deployed with a deployed webapp ?
>
> Thanks in advance.
> Jean-Louis
> --
> View this message in context:
> http://n4.nabble.com/OWB-integration-with-OpenEJB-Tomcat-Integration-Code-tp1835872p1887364.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>



-- 
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com


Re: [INFO] Blog About OpenWebBeans+OpenEJB+Tomcat Integration

2010-04-15 Thread Reza Rahman

Gurkan,

Great work! I suggest posting on JavaLobby and TSS. If I wasn't actively 
working on Resin, I would have done it for you...


Thanks,
Reza


Gurkan Erdogdu wrote:

Hello folks;

I have written a small aritcle about how to integrate OpenWebBeans with
OpenEJB+Tomcat integration with patch that I was created.

Link is :
http://gurkanerdogdu.blogspot.com/2010/04/openwebbeans-integration-with-openejb.html


Thanks;

  




[jira] Created: (OWB-355) OpenEjbBean should look for @Remove methods

2010-04-15 Thread Jean-Louis MONTEIRO (JIRA)
OpenEjbBean should look for @Remove methods
---

 Key: OWB-355
 URL: https://issues.apache.org/jira/browse/OWB-355
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Java EE Integration
 Environment: OpenWebBeans in OpenEJB
Reporter: Jean-Louis MONTEIRO
Assignee: Gurkan Erdogdu
 Fix For: 1.0.0


OpenEjbBean doesn't take care of @Remove methods so when deploying a stateful 
EJB we get a NullPointerException.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (OWB-355) OpenEjbBean should look for @Remove methods

2010-04-15 Thread Jean-Louis MONTEIRO (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Louis MONTEIRO updated OWB-355:


Attachment: OWB-355.patch

Here is the proposed patch.
IMHO, we should deal with the retainIfException parameter of the @Remove 
annotation.
For that, we have different solutions:
* only add a method to the list when the retainIfException is false (or omitted)
* change the 
org.apache.webbeans.ejb.common.proxy.EjbBeanProxyHandler.checkEjbRemoveMethod(Method)
 method and check the retainIfException attribute too.

> OpenEjbBean should look for @Remove methods
> ---
>
> Key: OWB-355
> URL: https://issues.apache.org/jira/browse/OWB-355
> Project: OpenWebBeans
>  Issue Type: Improvement
>  Components: Java EE Integration
> Environment: OpenWebBeans in OpenEJB
>Reporter: Jean-Louis MONTEIRO
>Assignee: Gurkan Erdogdu
> Fix For: 1.0.0
>
> Attachments: OWB-355.patch
>
>
> OpenEjbBean doesn't take care of @Remove methods so when deploying a stateful 
> EJB we get a NullPointerException.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (OWB-356) EjbPlugin only looks for DeployementInfo once, so new deployed application won't be discovered

2010-04-15 Thread Jean-Louis MONTEIRO (JIRA)
EjbPlugin only looks for DeployementInfo once, so new deployed application 
won't be discovered
--

 Key: OWB-356
 URL: https://issues.apache.org/jira/browse/OWB-356
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Java EE Integration
 Environment: OWB + OEJB
Reporter: Jean-Louis MONTEIRO
Assignee: Gurkan Erdogdu
 Fix For: 1.0.0




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (OWB-356) EjbPlugin only looks for DeployementInfo once, so new deployed application won't be discovered

2010-04-15 Thread Jean-Louis MONTEIRO (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Louis MONTEIRO updated OWB-356:


Attachment: OWB-356.patch

Here is a first proposal

> EjbPlugin only looks for DeployementInfo once, so new deployed application 
> won't be discovered
> --
>
> Key: OWB-356
> URL: https://issues.apache.org/jira/browse/OWB-356
> Project: OpenWebBeans
>  Issue Type: Improvement
>  Components: Java EE Integration
> Environment: OWB + OEJB
>Reporter: Jean-Louis MONTEIRO
>Assignee: Gurkan Erdogdu
> Fix For: 1.0.0
>
> Attachments: OWB-356.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Closed: (OWB-356) EjbPlugin only looks for DeployementInfo once, so new deployed application won't be discovered

2010-04-15 Thread Gurkan Erdogdu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gurkan Erdogdu closed OWB-356.
--

Resolution: Fixed

> EjbPlugin only looks for DeployementInfo once, so new deployed application 
> won't be discovered
> --
>
> Key: OWB-356
> URL: https://issues.apache.org/jira/browse/OWB-356
> Project: OpenWebBeans
>  Issue Type: Improvement
>  Components: Java EE Integration
> Environment: OWB + OEJB
>Reporter: Jean-Louis MONTEIRO
>Assignee: Gurkan Erdogdu
> Fix For: 1.0.0
>
> Attachments: OWB-356.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Closed: (OWB-355) OpenEjbBean should look for @Remove methods

2010-04-15 Thread Gurkan Erdogdu (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gurkan Erdogdu closed OWB-355.
--

Resolution: Fixed

> OpenEjbBean should look for @Remove methods
> ---
>
> Key: OWB-355
> URL: https://issues.apache.org/jira/browse/OWB-355
> Project: OpenWebBeans
>  Issue Type: Improvement
>  Components: Java EE Integration
> Environment: OpenWebBeans in OpenEJB
>Reporter: Jean-Louis MONTEIRO
>Assignee: Gurkan Erdogdu
> Fix For: 1.0.0
>
> Attachments: OWB-355.patch
>
>
> OpenEjbBean doesn't take care of @Remove methods so when deploying a stateful 
> EJB we get a NullPointerException.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (OWB-357) WebbeansFinder should index first on ClassLoader, not singleton type

2010-04-15 Thread Eric Covener (JIRA)
WebbeansFinder should index first on ClassLoader, not singleton type


 Key: OWB-357
 URL: https://issues.apache.org/jira/browse/OWB-357
 Project: OpenWebBeans
  Issue Type: Bug
Affects Versions: M4
 Environment: tiered classloader
Reporter: Eric Covener
Assignee: Eric Covener
Priority: Minor
 Fix For: M4


I'm finding WebbeansFinder a little difficult  to work with since it is unable 
to easily clear all instances a / the current classloader.

I would like to change the map to have the primary index on the classloader 
from:

private static Map> singletonMap = new 
HashMap>();
to
private static Map> singletonMap = new 
HashMap>();

Currently, this only really breaks removeInstance(String name) which AFAICT has 
no callers.  This would be replaced by e.g.

clearInstance(ClassLoader cl)

And most current callers of clearInstances() would I think prefer to just clear 
an individual classloader.

Opinions welcome, and curious if anyone wants to preserve a 
removeInstance(String name) method.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira