[jira] Created: (OWB-418) EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB

2010-07-22 Thread Eric Covener (JIRA)
EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB
---

 Key: OWB-418
 URL: https://issues.apache.org/jira/browse/OWB-418
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Java EE Integration
Affects Versions: 1.0.0-alpha-1
 Environment: tomcat+owb integration
Reporter: Eric Covener
Assignee: Eric Covener


EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB, so the 
handler can maintain the required state.  In other words, this should look more 
like the dependent interceptor handler.

In the future, it might be nice to re-use handlers on other types of EJBs, but 
dependent SFSB is the most interesting with respect to 299 and has functional 
impact

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



ELContextStore Question

2010-07-22 Thread Mark Struberg
Hi!

I don't really understand the ELContextStore which is used in the 
WebBeansELResolver.

It seems to cache all beans which are invoked via EL. So far so good (but the 
algorithm needs improvement).
But what I absolutely not understand is why it releases all those beans at the 
end of each request. This leads to invoking @PreDestroy to those beans after 
every EL encapsulation 


My first bet is that this was an attempt to resolve 6.4.3. Dependent 
pseudo-scope and Unified EL, isn't?

This defines that in a complex EL statement, multiple references to the same 
@Dependent scoped bean must always get the same Contextual instance of this 
very 
bean. And for those @Dependent scoped beans it is also ok to destroy them, 
because they don't 'hang' on some NormalScoped bean. 

But we must not treat @NormalScoped beans this very way!

wdyt?

LieGrue,
strub



  


[jira] Created: (OWB-419) fix @Dependent handling in ELResolver

2010-07-22 Thread Mark Struberg (JIRA)
fix @Dependent handling in ELResolver
-

 Key: OWB-419
 URL: https://issues.apache.org/jira/browse/OWB-419
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Injection and Lookup
Affects Versions: 1.0.0-alpha-1
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: 1.0.0-alpha-2


We currently store all beans which get evaluated in a EL in the dependent list. 
This must only happen for Beans with @Dependent scope, but _not_ for 
@NormalScoped beans!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-419) fix @Dependent handling in ELResolver

2010-07-22 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg resolved OWB-419.
---

Resolution: Fixed

 fix @Dependent handling in ELResolver
 -

 Key: OWB-419
 URL: https://issues.apache.org/jira/browse/OWB-419
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Injection and Lookup
Affects Versions: 1.0.0-alpha-1
Reporter: Mark Struberg
Assignee: Mark Struberg
 Fix For: 1.0.0-alpha-2


 We currently store all beans which get evaluated in a EL in the dependent 
 list. This must only happen for Beans with @Dependent scope, but _not_ for 
 @NormalScoped beans!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener closed OWB-406.


Resolution: Fixed

 BaseEjbBean.removedStatefulInstance used by multiple 
 instances/EjbBeanProxyHandlers
 ---

 Key: OWB-406
 URL: https://issues.apache.org/jira/browse/OWB-406
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-1
 Environment: OWB + tomcat EJB integration
Reporter: Eric Covener
Assignee: Eric Covener
   Original Estimate: 4h
  Remaining Estimate: 4h

 BaseEjbBean.removedStatefulInstance is used by MethodHandlers to track when a 
 remove method on a session bean has been called, but there is only one one of 
 these Contextuals per bean class not per instance.
 BaseEjbBean needs to manitain a map or the tracking needs to move into the 
 Method Handler (EjbBeanProxyHandler)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OWB-415) EjbBeanProxyHandler for dependent ejb must save ejb instance

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener closed OWB-415.


Fix Version/s: 1.0.0-alpha-2
   Resolution: Fixed

 EjbBeanProxyHandler for dependent ejb must save ejb instance 
 -

 Key: OWB-415
 URL: https://issues.apache.org/jira/browse/OWB-415
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-1
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-2

   Original Estimate: 4h
  Remaining Estimate: 4h

 If we use a depenent EJB, the EjbBeanProxyHandler will try to acquire an EJB 
 instance from the context each pass through the method handler.  Multiple 
 methods calls on the same injected proxy should be getting the same 
 underlying EJB.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OWB-416) BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener closed OWB-416.


Fix Version/s: 1.0.0-alpha-2
   Resolution: Fixed

 BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods
 

 Key: OWB-416
 URL: https://issues.apache.org/jira/browse/OWB-416
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Java EE Integration
Affects Versions: 1.0.0-alpha-1
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-2

   Original Estimate: 1h
  Remaining Estimate: 1h

 BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods 
 if they're available, but of course only the first remove method called can 
 succeed -- after that the EJB container must have run the PreDestroy and 
 invalidated the underlying EJB reference.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OWB-418) EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener closed OWB-418.


Fix Version/s: 1.0.0-alpha-2
   Resolution: Fixed

 EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB
 ---

 Key: OWB-418
 URL: https://issues.apache.org/jira/browse/OWB-418
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Java EE Integration
Affects Versions: 1.0.0-alpha-1
 Environment: tomcat+owb integration
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-2

   Original Estimate: 4h
  Remaining Estimate: 4h

 EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB, so 
 the handler can maintain the required state.  In other words, this should 
 look more like the dependent interceptor handler.
 In the future, it might be nice to re-use handlers on other types of EJBs, 
 but dependent SFSB is the most interesting with respect to 299 and has 
 functional impact

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener reopened OWB-406:
--


 BaseEjbBean.removedStatefulInstance used by multiple 
 instances/EjbBeanProxyHandlers
 ---

 Key: OWB-406
 URL: https://issues.apache.org/jira/browse/OWB-406
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-1
 Environment: OWB + tomcat EJB integration
Reporter: Eric Covener
Assignee: Eric Covener
   Original Estimate: 4h
  Remaining Estimate: 4h

 BaseEjbBean.removedStatefulInstance is used by MethodHandlers to track when a 
 remove method on a session bean has been called, but there is only one one of 
 these Contextuals per bean class not per instance.
 BaseEjbBean needs to manitain a map or the tracking needs to move into the 
 Method Handler (EjbBeanProxyHandler)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-406) BaseEjbBean.removedStatefulInstance used by multiple instances/EjbBeanProxyHandlers

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener resolved OWB-406.
--

Resolution: Fixed

 BaseEjbBean.removedStatefulInstance used by multiple 
 instances/EjbBeanProxyHandlers
 ---

 Key: OWB-406
 URL: https://issues.apache.org/jira/browse/OWB-406
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-1
 Environment: OWB + tomcat EJB integration
Reporter: Eric Covener
Assignee: Eric Covener
   Original Estimate: 4h
  Remaining Estimate: 4h

 BaseEjbBean.removedStatefulInstance is used by MethodHandlers to track when a 
 remove method on a session bean has been called, but there is only one one of 
 these Contextuals per bean class not per instance.
 BaseEjbBean needs to manitain a map or the tracking needs to move into the 
 Method Handler (EjbBeanProxyHandler)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (OWB-415) EjbBeanProxyHandler for dependent ejb must save ejb instance

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener reopened OWB-415:
--


 EjbBeanProxyHandler for dependent ejb must save ejb instance 
 -

 Key: OWB-415
 URL: https://issues.apache.org/jira/browse/OWB-415
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-1
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-2

   Original Estimate: 4h
  Remaining Estimate: 4h

 If we use a depenent EJB, the EjbBeanProxyHandler will try to acquire an EJB 
 instance from the context each pass through the method handler.  Multiple 
 methods calls on the same injected proxy should be getting the same 
 underlying EJB.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (OWB-418) EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener reopened OWB-418:
--


 EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB
 ---

 Key: OWB-418
 URL: https://issues.apache.org/jira/browse/OWB-418
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Java EE Integration
Affects Versions: 1.0.0-alpha-1
 Environment: tomcat+owb integration
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-2

   Original Estimate: 4h
  Remaining Estimate: 4h

 EjbBeanProxyHandler must be 1:1 with proxy instances for dependent SFSB, so 
 the handler can maintain the required state.  In other words, this should 
 look more like the dependent interceptor handler.
 In the future, it might be nice to re-use handlers on other types of EJBs, 
 but dependent SFSB is the most interesting with respect to 299 and has 
 functional impact

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (OWB-416) BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener reopened OWB-416:
--


 BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods
 

 Key: OWB-416
 URL: https://issues.apache.org/jira/browse/OWB-416
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Java EE Integration
Affects Versions: 1.0.0-alpha-1
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-2

   Original Estimate: 1h
  Remaining Estimate: 1h

 BaseEJBBean.destroyComponentInstance() tries to call multiple remove methods 
 if they're available, but of course only the first remove method called can 
 succeed -- after that the EJB container must have run the PreDestroy and 
 invalidated the underlying EJB reference.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-415) EjbBeanProxyHandler for dependent ejb must save ejb instance

2010-07-22 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener resolved OWB-415.
--

Resolution: Fixed

 EjbBeanProxyHandler for dependent ejb must save ejb instance 
 -

 Key: OWB-415
 URL: https://issues.apache.org/jira/browse/OWB-415
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-1
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-2

   Original Estimate: 4h
  Remaining Estimate: 4h

 If we use a depenent EJB, the EjbBeanProxyHandler will try to acquire an EJB 
 instance from the context each pass through the method handler.  Multiple 
 methods calls on the same injected proxy should be getting the same 
 underlying EJB.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.