[jira] Updated: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
[ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gurkan Erdogdu updated OWB-422: --- Fix Version/s: 1.0.0-alpha-2 (was: 1.0.0-alpha-1) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor. Key: OWB-422 URL: https://issues.apache.org/jira/browse/OWB-422 Project: OpenWebBeans Issue Type: Bug Components: Core Affects Versions: 1.0.0-alpha-1 Environment: All Reporter: Paul J. Reder Assignee: Eric Covener Fix For: 1.0.0-alpha-2 Attachments: PrePassivate_PostActivate_AroundTimeout.patch Original Estimate: 1h Remaining Estimate: 1h Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OWB-426) Tweak EJBPlugin to work with Standalone Tests
Tweak EJBPlugin to work with Standalone Tests - Key: OWB-426 URL: https://issues.apache.org/jira/browse/OWB-426 Project: OpenWebBeans Issue Type: Bug Components: TCK Affects Versions: 1.0.0-alpha-1 Reporter: Gurkan Erdogdu Assignee: Gurkan Erdogdu Fix For: 1.0.0-alpha-2 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [IMPORTANT] About Big Commits
I have committed changes. Now, all 574 tests have passed. From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Mon, July 26, 2010 11:16:44 AM Subject: Re: [IMPORTANT] About Big Commits Hi Eric; Needs some tweaking on EJB plugin to allow standalone test's EJB classes are correctly deployed. Iwill tinker it. Regards; --Gurkan From: Eric Covener cove...@gmail.com To: dev@openwebbeans.apache.org Sent: Sun, July 25, 2010 7:39:13 PM Subject: Re: [IMPORTANT] About Big Commits On Sat, Jul 24, 2010 at 3:15 PM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: http://svn.apache.org/repos/asf/openwebbeans/trunk/readme/TCK_RUNNING.txt Thanks Gurkan -- I ran standalone and got these results (twice) : Tests run: 574, Failures: 10, Errors: 0, Skipped: 0, Time elapsed: 42.527 sec FAILURE! Results : Failed tests: testBindingTypesAppliedToDisposalMethodParameters(org.jboss.jsr299.tck.tests.implementation.disposal.method.definition.DisposalMethodDefinitionTest) testRemoteInterfacesAreNotInAPITypes(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testBeanTypesAreLocalInterfacesWithoutWildcardTypesOrTypeVariablesWithSuperInterfaces(org.jboss.jsr299.tck.tests.implementation.enterprise.definition.EnterpriseBeanDefinitionTest) testNewBeanHasNoBeanELName(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoStereotypes(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanHasNoObservers(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testForEachEnterpriseBeanANewBeanExists(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsHasOnlyNewBinding(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testNewBeanIsDependentScoped(org.jboss.jsr299.tck.tests.implementation.enterprise.newBean.NewEnterpriseBeanTest) testContextCreatesNewInstanceForInjection(org.jboss.jsr299.tck.tests.implementation.simple.lifecycle.SimpleBeanLifecycleTest) Is the current expectation that both web and standalone run 100% clean, with perhaps some timing issues that cause transient failures? I was surprised to see EJB definition tests in the standalone suite -- do you test against a tomcat+openejb that has the integration applied? I don't think we could figure out local interfaces only without that (looking at testcase name only of one of the above) -- Eric Covener cove...@gmail.com
[jira] Assigned: (OWB-425) improve performance of owb-el-resolver
[ https://issues.apache.org/jira/browse/OWB-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg reassigned OWB-425: - Assignee: Mark Struberg (was: Gurkan Erdogdu) improve performance of owb-el-resolver -- Key: OWB-425 URL: https://issues.apache.org/jira/browse/OWB-425 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0-alpha-1 Reporter: Gerhard Petracek Assignee: Mark Struberg Attachments: OWB-425.patch, OWB-425_v2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r979198 - /openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
this doesn't compile due to 5 checkstyle violations.
fix is otw.
LieGrue,
strub
- Original Message
From: gerdo...@apache.org gerdo...@apache.org
To: comm...@openwebbeans.apache.org
Sent: Mon, July 26, 2010 10:37:24 AM
Subject: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Author: gerdogdu
Date: Mon Jul 26 08:37:23 2010
New Revision: 979198
URL: http://svn.apache.org/viewvc?rev=979198view=rev
Log:
[OWB-426] Tweak EJBPlugin to work with Standalone Tests
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
URL: :
http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java?rev=979198r1=979197r2=979198view=diff
==
---
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a (original)
+++
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Mon Jul 26 08:37:23 2010
@@ -101,6 +101,10 @@ public class EjbPlugin extends AbstractO
private static final SecurityService SECURITY_SERVICE = new
OpenEJBSecurityService();
private final MapString, JndiNameStrategy nameStrategies = new
TreeMapString, JndiNameStrategy();
+
+ //This is here for standalone tests are correctly run
+//Not used in anywhere
+public static boolean CONFIGURED_FOR_USED_IN_TEST = false;
public EjbPlugin()
{
@@ -296,8 +300,12 @@ public class EjbPlugin extends AbstractO
public boolean isSessionBean(Class? clazz)
{
- if (this.containerSystem == null)
+ //This is used in tests, because in reality containerSystem is not
null
+if (this.containerSystem == null || CONFIGURED_FOR_USED_IN_TEST)
{
+ //Used for tests
+ CONFIGURED_FOR_USED_IN_TEST = false;
+
this.containerSystem =
SystemInstance.get().getComponent(ContainerSystem.class);
Container[] containers = this.containerSystem.containers();
for (Container container : containers)
[jira] Reopened: (OWB-426) Tweak EJBPlugin to work with Standalone Tests
[ https://issues.apache.org/jira/browse/OWB-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg reopened OWB-426: --- reopened since I had to rollback the CONFIGURED_FOR_USED_IN_TEST public boolean flag. Tweak EJBPlugin to work with Standalone Tests - Key: OWB-426 URL: https://issues.apache.org/jira/browse/OWB-426 Project: OpenWebBeans Issue Type: Bug Components: TCK Affects Versions: 1.0.0-alpha-1 Reporter: Gurkan Erdogdu Assignee: Gurkan Erdogdu Fix For: 1.0.0-alpha-2 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r979198 - /openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Not understand concerns except checkstyle. Lots of project uses some public
method/fields solely for testing.
From: Mark Struberg strub...@yahoo.de
To: dev@openwebbeans.apache.org
Sent: Mon, July 26, 2010 3:45:39 PM
Subject: Re: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
sorry, but this commit was done with a very hot needle!
a) it doesn't compile
b) it contains PUBLIC boolean flags! (an absolute no-go)
c) it contains code which is a hack for the TCK only. Sorry if I have to say
this, but then all the TCK testing is absolutely worth nothing.
I'll drop this flag for now to be able to compile OWB again.
LieGrue,
strub
- Original Message
From: gerdo...@apache.org gerdo...@apache.org
To: comm...@openwebbeans.apache.org
Sent: Mon, July 26, 2010 10:37:24 AM
Subject: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Author: gerdogdu
Date: Mon Jul 26 08:37:23 2010
New Revision: 979198
URL: http://svn.apache.org/viewvc?rev=979198view=rev
Log:
[OWB-426] Tweak EJBPlugin to work with Standalone Tests
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
URL: :
http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java?rev=979198r1=979197r2=979198view=diff
==
---
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a (original)
+++
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Mon Jul 26 08:37:23 2010
@@ -101,6 +101,10 @@ public class EjbPlugin extends AbstractO
private static final SecurityService SECURITY_SERVICE = new
OpenEJBSecurityService();
private final MapString, JndiNameStrategy nameStrategies = new
TreeMapString, JndiNameStrategy();
+
+ //This is here for standalone tests are correctly run
+//Not used in anywhere
+public static boolean CONFIGURED_FOR_USED_IN_TEST = false;
public EjbPlugin()
{
@@ -296,8 +300,12 @@ public class EjbPlugin extends AbstractO
public boolean isSessionBean(Class? clazz)
{
- if (this.containerSystem == null)
+ //This is used in tests, because in reality containerSystem is not
null
+if (this.containerSystem == null || CONFIGURED_FOR_USED_IN_TEST)
{
+ //Used for tests
+ CONFIGURED_FOR_USED_IN_TEST = false;
+
this.containerSystem =
SystemInstance.get().getComponent(ContainerSystem.class);
Container[] containers = this.containerSystem.containers();
for (Container container : containers)
Re: svn commit: r979198 - /openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
c) it contains code which is a hack for the TCK only. Sorry if I have to
say
this, but then all the TCK testing is absolutely worth nothing.
What? This flag is just used for deploying EJB classes while running
standalone
case correctly.
No related with TCK testings. It is not that we add some flag and passing TCK
tests, lol!
From: Gurkan Erdogdu gurkanerdo...@yahoo.com
To: dev@openwebbeans.apache.org
Sent: Mon, July 26, 2010 3:55:37 PM
Subject: Re: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Not understand concerns except checkstyle. Lots of project uses some public
method/fields solely for testing.
From: Mark Struberg strub...@yahoo.de
To: dev@openwebbeans.apache.org
Sent: Mon, July 26, 2010 3:45:39 PM
Subject: Re: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
sorry, but this commit was done with a very hot needle!
a) it doesn't compile
b) it contains PUBLIC boolean flags! (an absolute no-go)
c) it contains code which is a hack for the TCK only. Sorry if I have to say
this, but then all the TCK testing is absolutely worth nothing.
I'll drop this flag for now to be able to compile OWB again.
LieGrue,
strub
- Original Message
From: gerdo...@apache.org gerdo...@apache.org
To: comm...@openwebbeans.apache.org
Sent: Mon, July 26, 2010 10:37:24 AM
Subject: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Author: gerdogdu
Date: Mon Jul 26 08:37:23 2010
New Revision: 979198
URL: http://svn.apache.org/viewvc?rev=979198view=rev
Log:
[OWB-426] Tweak EJBPlugin to work with Standalone Tests
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
URL: :
http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java?rev=979198r1=979197r2=979198view=diff
==
---
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a (original)
+++
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Mon Jul 26 08:37:23 2010
@@ -101,6 +101,10 @@ public class EjbPlugin extends AbstractO
private static final SecurityService SECURITY_SERVICE = new
OpenEJBSecurityService();
private final MapString, JndiNameStrategy nameStrategies = new
TreeMapString, JndiNameStrategy();
+
+ //This is here for standalone tests are correctly run
+//Not used in anywhere
+public static boolean CONFIGURED_FOR_USED_IN_TEST = false;
public EjbPlugin()
{
@@ -296,8 +300,12 @@ public class EjbPlugin extends AbstractO
public boolean isSessionBean(Class? clazz)
{
- if (this.containerSystem == null)
+ //This is used in tests, because in reality containerSystem is not
null
+if (this.containerSystem == null || CONFIGURED_FOR_USED_IN_TEST)
{
+ //Used for tests
+ CONFIGURED_FOR_USED_IN_TEST = false;
+
this.containerSystem =
SystemInstance.get().getComponent(ContainerSystem.class);
Container[] containers = this.containerSystem.containers();
for (Container container : containers)
Re: svn commit: r979198 - /openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Hoi Gurkan!
Fields should generally not be public. That's just pretty horrible to maintain.
I understand that we sometimes need to provide some kind of 'Mock'
functionality
for passing the TCK, because we won't have a 'real' scenario available. But in
this case the flag should either be configurable, or even better - we introduce
a subclass of the EJBPlugin and use this instead for the TCK.
LieGrue,
strub
- Original Message
From: Gurkan Erdogdu gurkanerdo...@yahoo.com
To: dev@openwebbeans.apache.org
Sent: Mon, July 26, 2010 2:55:37 PM
Subject: Re: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
Not understand concerns except checkstyle. Lots of project uses some public
method/fields solely for testing.
From: Mark Struberg strub...@yahoo.de
To: dev@openwebbeans.apache.org
Sent: Mon, July 26, 2010 3:45:39 PM
Subject: Re: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a
sorry, but this commit was done with a very hot needle!
a) it doesn't compile
b) it contains PUBLIC boolean flags! (an absolute no-go)
c) it contains code which is a hack for the TCK only. Sorry if I have to say
this, but then all the TCK testing is absolutely worth nothing.
I'll drop this flag for now to be able to compile OWB again.
LieGrue,
strub
- Original Message
From: gerdo...@apache.org gerdo...@apache.org
To: comm...@openwebbeans.apache.org
Sent: Mon, July 26, 2010 10:37:24 AM
Subject: svn commit: r979198 -
/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a
Author: gerdogdu
Date: Mon Jul 26 08:37:23 2010
New Revision: 979198
URL: http://svn.apache.org/viewvc?rev=979198view=rev
Log:
[OWB-426] Tweak EJBPlugin to work with Standalone Tests
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a
Modified:
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a
URL: :
http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java?rev=979198r1=979197r2=979198view=diff
f
==
; ---
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a
a (original)
+++
openwebbeans/trunk/webbeans-openejb/src/main/java/org/apache/webbeans/ejb/EjbPlugin.java
a
Mon Jul 26 08:37:23 2010
@@ -101,6 +101,10 @@ public class EjbPlugin extends AbstractO
private static final SecurityService SECURITY_SERVICE = new
OpenEJBSecurityService();
private final MapString, JndiNameStrategy nameStrategies = new
TreeMapString, JndiNameStrategy();
+
+ //This is here for standalone tests are correctly run
+//Not used in anywhere
+public static boolean CONFIGURED_FOR_USED_IN_TEST = false;
public EjbPlugin()
{
@@ -296,8 +300,12 @@ public class EjbPlugin extends AbstractO
public boolean isSessionBean(Class? clazz)
{
- if (this.containerSystem == null)
+ //This is used in tests, because in reality containerSystem is
not
null
+ if (this.containerSystem == null || CONFIGURED_FOR_USED_IN_TEST)
{
+ //Used for tests
+ CONFIGURED_FOR_USED_IN_TEST = false;
+
this.containerSystem =
SystemInstance.get().getComponent(ContainerSystem.class);
Container[] containers = this.containerSystem.containers();
for (Container container : containers)
[jira] Resolved: (OWB-425) improve performance of owb-el-resolver
[ https://issues.apache.org/jira/browse/OWB-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg resolved OWB-425. --- Fix Version/s: 1.0.0-alpha-2 Resolution: Fixed patch applied, txs gerhard! improve performance of owb-el-resolver -- Key: OWB-425 URL: https://issues.apache.org/jira/browse/OWB-425 Project: OpenWebBeans Issue Type: Improvement Components: Injection and Lookup Affects Versions: 1.0.0-alpha-1 Reporter: Gerhard Petracek Assignee: Mark Struberg Fix For: 1.0.0-alpha-2 Attachments: OWB-425.patch, OWB-425_v2.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OWB-422) Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor.
[ https://issues.apache.org/jira/browse/OWB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892306#action_12892306 ] Mark Struberg commented on OWB-422: --- The current solution pulls in a EJB spec dependencies to webbeans-impl. But all EJB dependencies should only get pulled in via the webbeans-ejb plugin and webbeans-impl shall remain Java-SE only! Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor. Key: OWB-422 URL: https://issues.apache.org/jira/browse/OWB-422 Project: OpenWebBeans Issue Type: Bug Components: Core Affects Versions: 1.0.0-alpha-1 Environment: All Reporter: Paul J. Reder Assignee: Eric Covener Fix For: 1.0.0-alpha-2 Attachments: PrePassivate_PostActivate_AroundTimeout.patch Original Estimate: 1h Remaining Estimate: 1h Support needed for PrePassivate, PostActivate, and AroundTimeout via EJBInterceptor. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OWB-426) Tweak EJBPlugin to work with Standalone Tests
[ https://issues.apache.org/jira/browse/OWB-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gurkan Erdogdu closed OWB-426. -- Resolution: Fixed Passing checkstyle, remove public static to instance field Tweak EJBPlugin to work with Standalone Tests - Key: OWB-426 URL: https://issues.apache.org/jira/browse/OWB-426 Project: OpenWebBeans Issue Type: Bug Components: TCK Affects Versions: 1.0.0-alpha-1 Reporter: Gurkan Erdogdu Assignee: Gurkan Erdogdu Fix For: 1.0.0-alpha-2 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r979071 - in /openwebbeans/trunk: webbeans-ejb/ webbeans-ejb/src/main/java/org/apache/webbeans/ejb/common/interceptor/ webbeans-impl/ webbeans-impl/src/main/java/org/apache/webbeans/
On Mon, Jul 26, 2010 at 10:10 AM, Gurkan Erdogdu gurkanerdo...@yahoo.com wrote: Hello, This commit breaks following TCK tests, 1- DecoratorAndInterceptorTest # testInterceptorCalledBeforeDecorator 2- InterceptorCalledBeforeDecoratorTest # testInterceptorCalledBeforeDecorator I may be reverting this due to the EJB dependency leaking into -impl, will take a look this afternoon. I ran standalone with no regression, but must have done something wrong. -- Eric Covener cove...@gmail.com
Re: CIA bot on #openwebbeans?
On Sun, Jul 25, 2010 at 4:45 PM, Rohit Kelapure kelap...@gmail.com wrote: +1 On Sun, Jul 25, 2010 at 1:28 PM, Eric Covener cove...@gmail.com wrote: How do people feel / who do we ask to turn on a CIA bot for commit messages in #openwebbeans? I am personally +1 any +/-0? it's third-party (cia.vc) but it's all public info anyway. I know HTTPD and APR both use them on freenode. -- Eric Covener cove...@gmail.com
