[jira] Created: (OWB-427) improve read-performance of AbstractOwbBean
improve read-performance of AbstractOwbBean --- Key: OWB-427 URL: https://issues.apache.org/jira/browse/OWB-427 Project: OpenWebBeans Issue Type: Improvement Components: Core Reporter: Gerhard Petracek Assignee: Gurkan Erdogdu Fix For: 1.0.0-alpha-1 Attachments: OWB-427.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-428) implementation of equals and hashCode for AbstractOwbBean
[ https://issues.apache.org/jira/browse/OWB-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated OWB-428: - Attachment: OWB-428.patch implementation of equals and hashCode for AbstractOwbBean - Key: OWB-428 URL: https://issues.apache.org/jira/browse/OWB-428 Project: OpenWebBeans Issue Type: Task Components: Core Reporter: Gerhard Petracek Assignee: Gurkan Erdogdu Fix For: 1.0.0-alpha-1 Attachments: OWB-428.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-428) implementation of equals and hashCode for AbstractOwbBean
[ https://issues.apache.org/jira/browse/OWB-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated OWB-428: - Affects Version/s: 1.0.0-alpha-1 Fix Version/s: 1.0.0-alpha-2 (was: 1.0.0-alpha-1) implementation of equals and hashCode for AbstractOwbBean - Key: OWB-428 URL: https://issues.apache.org/jira/browse/OWB-428 Project: OpenWebBeans Issue Type: Task Components: Core Affects Versions: 1.0.0-alpha-1 Reporter: Gerhard Petracek Assignee: Gurkan Erdogdu Fix For: 1.0.0-alpha-2 Attachments: OWB-428.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r979269 - in /openwebbeans/trunk: webbeans-el10/src/main/java/org/apache/webbeans/el10/ webbeans-impl/src/main/java/org/apache/webbeans/el/
yes, you are right. Thanks for catching this, I'll fix it asap.
LieGrue,
strub
- Original Message
From: Eric Covener cove...@gmail.com
To: dev@openwebbeans.apache.org
Sent: Tue, July 27, 2010 9:38:19 PM
Subject: Re: svn commit: r979269 - in /openwebbeans/trunk:
webbeans-el10/src/main/java/org/apache/webbeans/el10/
webbeans-impl/src/main/java/org/apache/webbeans/el/
On Mon, Jul 26, 2010 at 9:10 AM, strub...@apache.org wrote:
Author: struberg
Date: Mon Jul 26 13:10:33 2010
New Revision: 979269
URL: http://svn.apache.org/viewvc?rev=979269view=rev
Log:
OWB-425 OWB EL performance improvement
txs 2 gpetracek for the patch!
+public Object findBeanByName(String name)
+{
+Object cachedBean = normalScopedObjects.get(name);
+
+if(cachedBean != null)
+{
+return cachedBean;
+ }
+
+Bean? dependentBean = beanNameToDependentBeanMapping.get(name);
+
+ if(dependentBean == null)
+{
+return null;
+}
+return dependentObjects.get(dependentBean);
+}
+
Rohit and I were looking at this offline, and it seems like this
should have a .getObject() on this final line -- otherwise the Object
returned here is a CreationalStore.
private MapBean?, CreationalStore dependentObjects = new
HashMapBean?, CreationalStore();
The similar names and dissimilar values of the dependent and normal
scoped hash maps is probably confusing here.
is usage of BaseEjbBean.iface safe?
If we have 1 EJB bean class, we only have 1 ENTERPRISE managed bean and one BaseEjbBean.iface. But if this EJB has two or more local interfaces, it can be injected as under multiple interfaces. It seems like the interface should only be passsed around on the stack not actually associated with the enterprise bean itself. Does this sound right? -- Eric Covener cove...@gmail.com
[jira] Assigned: (OWB-385) implement passivation of managed beans in ServletContextListener
[
https://issues.apache.org/jira/browse/OWB-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
YING WANG reassigned OWB-385:
-
Assignee: YING WANG (was: Gurkan Erdogdu)
implement passivation of managed beans in ServletContextListener
Key: OWB-385
URL: https://issues.apache.org/jira/browse/OWB-385
Project: OpenWebBeans
Issue Type: Bug
Components: Context and Scopes
Affects Versions: 1.0.0-alpha-1
Reporter: Eric Covener
Assignee: YING WANG
Fix For: 1.0.0-alpha-2
Original Estimate: 60h
Remaining Estimate: 60h
Message-ID: 267326.60362...@web38203.mail.mud.yahoo.com
Currently we have no support for those callbacks for managed beans. Also
includes AroundTimeout method.
Motivation
--
Actually we have 2 methods in WebBeansConfigurationListener. Currently our
session and conversation context does not provided actiovation/passivation.
What we have to do is that we update below lifecycle callbacks to put all
session and conversation context instances into the session in the
sessionWillPassivate and call passivate callback, and reverse it on
sessionDidActivate.
Those areas needs some contributions :)
/**
* {...@inheritdoc}
*/
@Override
public void sessionDidActivate(HttpSessionEvent event)
{
//TODO activation
//Gets all passivated instances from passivated session and restore our
session and conversation context.
}
/**
* {...@inheritdoc}
*/
@Override
public void sessionWillPassivate(HttpSessionEvent event)
{
//TODO Passivation
//Gets all instances from the Session and ConversationContexts
and add those into the session that is under passivation therefore our
bean instances
are correctly passivated
}
Thanks;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: is usage of BaseEjbBean.iface safe?
Good catch Eric! Actually we save all of local interfaces in EJB bean and bean is requested with one of those interfaces we supply proxy instance. --Gurkan From: Eric Covener cove...@gmail.com To: dev@openwebbeans.apache.org Sent: Wed, July 28, 2010 2:05:29 AM Subject: is usage of BaseEjbBean.iface safe? If we have 1 EJB bean class, we only have 1 ENTERPRISE managed bean and one BaseEjbBean.iface. But if this EJB has two or more local interfaces, it can be injected as under multiple interfaces. It seems like the interface should only be passsed around on the stack not actually associated with the enterprise bean itself. Does this sound right? -- Eric Covener cove...@gmail.com
Re: is usage of BaseEjbBean.iface safe?
Good catch Eric! Not mean that current logic is wrong. Bean API types are local interfaces of the EJB bean . We check all injection fields at deployment time for validation. If there is no validation error, using of EJB local interfaces are correct. What is the problem that you think about? --Gurkan From: Gurkan Erdogdu gurkanerdo...@yahoo.com To: dev@openwebbeans.apache.org Sent: Wed, July 28, 2010 8:27:42 AM Subject: Re: is usage of BaseEjbBean.iface safe? Good catch Eric! Actually we save all of local interfaces in EJB bean and bean is requested with one of those interfaces we supply proxy instance. --Gurkan From: Eric Covener cove...@gmail.com To: dev@openwebbeans.apache.org Sent: Wed, July 28, 2010 2:05:29 AM Subject: is usage of BaseEjbBean.iface safe? If we have 1 EJB bean class, we only have 1 ENTERPRISE managed bean and one BaseEjbBean.iface. But if this EJB has two or more local interfaces, it can be injected as under multiple interfaces. It seems like the interface should only be passsed around on the stack not actually associated with the enterprise bean itself. Does this sound right? -- Eric Covener cove...@gmail.com
