[jira] Assigned: (OWB-445) we must not use javassist ProxyFactory#setHandler(MethodHandler)

2010-09-06 Thread Mark Struberg (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Struberg reassigned OWB-445:
-

Assignee: Joe Bergmark  (was: Mark Struberg)

Joe, could you please take a look at the two ProxyFactory invocations marked 
with //X TODO?
They are both in code you touched lately, so I guess you are faster than I with 
fixing them.
txs!

 we must not use javassist ProxyFactory#setHandler(MethodHandler)
 

 Key: OWB-445
 URL: https://issues.apache.org/jira/browse/OWB-445
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: 1.0.0-alpha-2
Reporter: Mark Struberg
Assignee: Joe Bergmark

 ProxyFactory.setHandler is deprecated and if used creates memory leaks!
 We must create the ProxyClass  without a default method handler and set it 
 after we create a proxy instance of that very class:
 Object proxyInstance = proxyClass.newInstance();
 ((ProxyObject) proxyInstance ).setHandler( ... ) 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (OWB-446) EJB lifecycle callbacks not stacked correctly

2010-09-06 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener resolved OWB-446.
--

Fix Version/s: 1.0.0-alpha-3
   Resolution: Fixed

 EJB lifecycle callbacks not stacked correctly
 -

 Key: OWB-446
 URL: https://issues.apache.org/jira/browse/OWB-446
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-2
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-3

   Original Estimate: 1h
  Remaining Estimate: 1h

 * We call proceed() on the EJB invocation context even when some 299 
 interceptor may not have proceeded.  
 * The defined-in-class lifecycle callback does not happen in the same stack 
 as the 299 interceptors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-06 Thread Eric Covener (JIRA)
unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor
---

 Key: OWB-447
 URL: https://issues.apache.org/jira/browse/OWB-447
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-2
Reporter: Eric Covener
Assignee: Eric Covener


The separation between contextual and non-contextual is wrong/harmful and 
unnecessary.  

* We should be managing a CreationalContext for the lifetime of the interceptor 
instance and using that for dependent instanes
* We should not rely on the thread-locals beyond @PostConstruct 
* Method invocations on non-contextual EJB's must be decoratable


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OWB-447) unnecessary contextual/non-contextual distinction in OpenWebBeansEJBIntercpetor

2010-09-06 Thread Eric Covener (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906602#action_12906602
 ] 

Eric Covener commented on OWB-447:
--

we also need to avoid adding the underlying ejb instance 
(ejbcontext.getTarget()) as keys into dependent creational contexts.

 unnecessary contextual/non-contextual distinction in 
 OpenWebBeansEJBIntercpetor
 ---

 Key: OWB-447
 URL: https://issues.apache.org/jira/browse/OWB-447
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Enterprise Web Beans
Affects Versions: 1.0.0-alpha-2
Reporter: Eric Covener
Assignee: Eric Covener
   Original Estimate: 16h
  Remaining Estimate: 16h

 The separation between contextual and non-contextual is wrong/harmful and 
 unnecessary.  
 * We should be managing a CreationalContext for the lifetime of the 
 interceptor instance and using that for dependent instanes
 * We should not rely on the thread-locals beyond @PostConstruct 
 * Method invocations on non-contextual EJB's must be decoratable

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.