Please reopen OWB-318, patch attached

2010-09-09 Thread Rohit Kelapure
Dear Apache Open WebBeans Committers,

We need to reopen JIRA issue
OWB-318https://issues.apache.org/jira/browse/OWB-318
opened for multiple methods with same EJB @interceptors(foo.class) in same
bean class get multiple interceptor instances.
When I run this TCK test
(org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest)
on a very recent OWB code revision 995059 from the trunk I see that the
testInterceptorCanBeAppliedToMoreThanOneMethod is  failing like so...
java.lang.AssertionError at
org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testInterceptorCanBeAppliedToMoreThanOneMethod(MethodLevelInterceptorTest.java:45)


After applying the attached patch (owb-318-patch.diff) this TCK test passes
successfully.
[Invoker 1452037772] Invoking @AfterClass
org.jboss.testharness.AbstractTest.afterClass()
*** INVOKED METHODS
org.jboss.testharness.AbstractTest.beforeClass() 1015168130
org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testExcludeClassInterceptors()
1015168130
org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testInterceptorCanBeAppliedToMoreThanOneMethod()
1015168130
org.jboss.testharness.AbstractTest.afterClass() 1015168130
***
Creating
C:\eclipse3.5\owb-cdi\openwebbeans\webbeans-tck\test-output\openwebbeans-tck\org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.html
Creating
C:\eclipse3.5\owb-cdi\openwebbeans\webbeans-tck\test-output\openwebbeans-tck\org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.xml
PASSED: testExcludeClassInterceptors
PASSED: testInterceptorCanBeAppliedToMoreThanOneMethod

If you are agree to the changes, can you please commit the patch to the svn
trunk.

*Can someone tell me why this TCK test does not get run with our standalone
and web suite,*

--Thank You,
Rohit Kelapure


[jira] Reopened: (OWB-318) multiple methods with same EJB @interceptors(foo.class) in same bean class get multiple interceptor instances

2010-09-09 Thread Eric Covener (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Covener reopened OWB-318:
--


reopening per Rohit

 multiple methods with same EJB @interceptors(foo.class) in same bean class 
 get multiple interceptor instances
 -

 Key: OWB-318
 URL: https://issues.apache.org/jira/browse/OWB-318
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Interceptor and Decorators
Affects Versions: M4
Reporter: Eric Covener
Assignee: Eric Covener
 Fix For: 1.0.0-alpha-1

   Original Estimate: 6h
  Remaining Estimate: 6h

 One managed bean with multiple methods with the same EJB 
 @interceptors(foo.class) get multiple interceptor instances, but we should 
 only create 1 instance.
 See TCK method 
 org.jboss.jsr299.tck.interceptors.tests.method.MethodLevelInterceptorTest.testInterceptorCanBeAppliedToMoreThanOneMethod().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Please reopen OWB-318, patch attached

2010-09-09 Thread Rohit Kelapure
Done. Attached to JIRA. Attaching here as well.

--Thanks,
Rohit


On Thu, Sep 9, 2010 at 4:40 PM, Eric Covener cove...@gmail.com wrote:

  After applying the attached patch (owb-318-patch.diff) this TCK test
 passes
  successfully.

 reopened, but didn't see an email attachment. Can you attach it to OWB-318?

 https://issues.apache.org/jira/browse/OWB-318


 --
 Eric Covener
 cove...@gmail.com