[jira] Created: (OWB-479) detect loops in producer beans vs. producer method parameters at deployment time

2010-10-21 Thread Eric Covener (JIRA)
detect loops in producer beans vs. producer method parameters at deployment time


 Key: OWB-479
 URL: https://issues.apache.org/jira/browse/OWB-479
 Project: OpenWebBeans
  Issue Type: Improvement
  Components: Injection and Lookup
Affects Versions: 1.0.0
Reporter: Eric Covener
Assignee: Gurkan Erdogdu
Priority: Minor


Currently OWB can cause a stack overflow if a parameter on a producer method is 
satisfied by the same bean as the producer method itself, it would be nice if 
we could trap such a thing in producer beans at deployment time and minimally 
warn about the offending method/parameter.

at 
org.apache.webbeans.container.BeanManagerImpl.getInjectableReference(BeanManagerImpl.java:723)
at 
org.apache.webbeans.inject.AbstractInjectable.inject(AbstractInjectable.java:134)
at 
org.apache.webbeans.inject.InjectableMethods.doInjection(InjectableMethods.java:117)
at 
org.apache.webbeans.component.ProducerMethodBean.createDefaultInstance(ProducerMethodBean.java:193)
at 
org.apache.webbeans.component.ProducerMethodBean.createInstance(ProducerMethodBean.java:155)
at 
org.apache.webbeans.component.AbstractOwbBean.createNewInstance(AbstractOwbBean.java:208)
at 
org.apache.webbeans.portable.creation.AbstractProducer.produce(AbstractProducer.java:82)
at 
org.apache.webbeans.component.InjectionTargetWrapper.produce(InjectionTargetWrapper.java:142)
at 
org.apache.webbeans.component.AbstractOwbBean.create(AbstractOwbBean.java:166)
at 
org.apache.webbeans.context.DependentContext.getInstance(DependentContext.java:69)
at 
org.apache.webbeans.context.AbstractContext.get(AbstractContext.java:191)
at 
org.apache.webbeans.container.BeanManagerImpl.getReference(BeanManagerImpl.java:839)
at 
org.apache.webbeans.container.BeanManagerImpl.getInjectableReference(BeanManagerImpl.java:723)


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-480) Avoid a couple NPEs

2010-10-21 Thread David Jencks (JIRA)
Avoid a couple NPEs
---

 Key: OWB-480
 URL: https://issues.apache.org/jira/browse/OWB-480
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: 1.1.0
Reporter: David Jencks
Assignee: Gurkan Erdogdu


I've found 2 possible NPE;s:

1. in an OSGI environment, its quite possible that no openwebbeans.properties 
files will be located, so you get a null properties object and 
OpenWebBeansConfiguration will have a null Properties leading to big problems.

2. in WebContainerLifecycle, the claim that it's a jsp app by configuration 
might be wrong.  If there's no jsp factory, no need to throw an NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OWB-480) Avoid a couple NPEs

2010-10-21 Thread David Jencks (JIRA)

 [ 
https://issues.apache.org/jira/browse/OWB-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Jencks updated OWB-480:
-

Attachment: OWB-480.patch

fix for the 2 NPEs

 Avoid a couple NPEs
 ---

 Key: OWB-480
 URL: https://issues.apache.org/jira/browse/OWB-480
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: 1.1.0
Reporter: David Jencks
Assignee: Gurkan Erdogdu
 Attachments: OWB-480.patch


 I've found 2 possible NPE;s:
 1. in an OSGI environment, its quite possible that no openwebbeans.properties 
 files will be located, so you get a null properties object and 
 OpenWebBeansConfiguration will have a null Properties leading to big problems.
 2. in WebContainerLifecycle, the claim that it's a jsp app by configuration 
 might be wrong.  If there's no jsp factory, no need to throw an NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OWB-481) WebBeansConfigurationListener implementing ServletContextListener is not likely to work

2010-10-21 Thread David Jencks (JIRA)
WebBeansConfigurationListener implementing ServletContextListener is not likely 
to work
---

 Key: OWB-481
 URL: https://issues.apache.org/jira/browse/OWB-481
 Project: OpenWebBeans
  Issue Type: Bug
Reporter: David Jencks
Assignee: Gurkan Erdogdu


Currently WebBeansConfigurationListener implements ServletContextListener and 
uses the contextInitialized method to initialize OWB for the web app.  Given an 
application containing a ServletContextListener that is a web bean, this 
requires that

1. the OWB  WebBeansConfigurationListener ServletContextListener get installed 
before the app's ServletContextListeners

2. the OWB WebBeansConfigurationListener have it's contextInitialized called 
before the servlet container instantiates the apps ServletContextListeners that 
are web beans.

There's no way to guarantee this will happen in a compliant servlet container.  
(Neither happens in the geronimo tomcat integration; we could force the first 
to happen, but not the second).

It might be possible to do the initialization in a ServletContainerInitializer 
since I think these get called before any application classes start getting 
instantiated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.