[jira] [Commented] (OWB-669) Bean fail over is not in sync with specs
[ https://issues.apache.org/jira/browse/OWB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280799#comment-13280799 ] Mark Struberg commented on OWB-669: --- yes, no worries. I see what you mean. It's just that I consider the original code as quite a mess :) I'm currently working on this stuff again and I'm available on IRC. Bean fail over is not in sync with specs Key: OWB-669 URL: https://issues.apache.org/jira/browse/OWB-669 Project: OpenWebBeans Issue Type: Bug Components: Context and Scopes, Simple Web Beans Affects Versions: 1.1.3, 1.1.4 Environment: Tomcat 7.0.22+, Memcached Session Manager, OWB 1.1.3/4 Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: OWB-669.patch The current fail over logic is not in sync with the servlet specs as discussed with mark: http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201204.mbox/%3c1335357714.89803.yahoomail...@web171502.mail.ir2.yahoo.com%3E The fail over logic should be moved from the ServletRequestListener to an Filter/Valve. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OWB-669) Bean fail over is not in sync with specs
[ https://issues.apache.org/jira/browse/OWB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13280885#comment-13280885 ] Mark Struberg commented on OWB-669: --- Mea culpa, Thomas! Your change was indeed needed. I confused the eviction part (which I now cleaned up) with the restore logic. I've now applied your patch with some minor cleanup - again thanks a lot for helping! Btw, Activating that stuff is still a big of a mess. What do you folks think about adding a JNDI configuration for enabling the FailOver. That way people would not need to have any openwebbeans.properties with org.apache.webbeans.web.failover.issupportfailover=true anymore, but could enable this via JNDI on the production tomcat. The filter could automatically be installed in the openwebbeans-tomcat6 and 7 ContextLifecycleListener via context.addFilterDef and context.addFilterMap. Bean fail over is not in sync with specs Key: OWB-669 URL: https://issues.apache.org/jira/browse/OWB-669 Project: OpenWebBeans Issue Type: Bug Components: Context and Scopes, Simple Web Beans Affects Versions: 1.1.3, 1.1.4 Environment: Tomcat 7.0.22+, Memcached Session Manager, OWB 1.1.3/4 Reporter: Thomas Andraschko Assignee: Mark Struberg Attachments: OWB-669.patch The current fail over logic is not in sync with the servlet specs as discussed with mark: http://mail-archives.apache.org/mod_mbox/openwebbeans-dev/201204.mbox/%3c1335357714.89803.yahoomail...@web171502.mail.ir2.yahoo.com%3E The fail over logic should be moved from the ServletRequestListener to an Filter/Valve. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OWB-671) Automatically register FailOverFilter if failover is activated
Mark Struberg created OWB-671:
-
Summary: Automatically register FailOverFilter if failover is
activated
Key: OWB-671
URL: https://issues.apache.org/jira/browse/OWB-671
Project: OpenWebBeans
Issue Type: New Feature
Components: Java EE Integration
Affects Versions: 1.1.4
Reporter: Mark Struberg
Assignee: Mark Struberg
Fix For: 1.1.5
Currently a user needs to activate OWB failover in an
META-INF/openwebbeans/openwebbeans.properties file with the following content:
{code}
org.apache.webbeans.web.failover.issupportfailover=true
{code}
This is suboptimal as the decision to use failover is usually a deployment
question. Thus we should switch to enabling this feature in the container via a
JNDI property.
The openwebbeans-tomcat6 and openwebbeans-tomcat7 (and also TomEE)
ContextLifecycleListener could then add the required FailOverFilter
automatically.
This can be done via context.addFilterDef and context.addFilterMap. The Filter
should get added on the first position, probably by getting the existing
filters with context.findFilterDefs() and do a context.addFilterMapBefore();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [DISCUSS] Roadmap for 1.1.5 and beyond
+1 - Romain 2012/5/22 Mark Struberg strub...@yahoo.de Hi folks! We currently are working on getting the FailOver stuff fixed + I like to change the getBeans() behaviour as defined on the cdi-spec list (doing the alternative filtering only later in BeanManager#resolve ). Are there other plans and stuff you like to get into 1.1.5? Wdyt about switching OWB-1.x into maintenance mode and start working on OWB-1.2 after that? I'd say we still _not_ switch the API to CDI-1.1 as it is by far too early, but we should do some bigger work like * HierarchicBeanManager * switch to AnnotatedType handling (MetaDataProvider.THIRD_PARTY) and ditch all our MetaDataProvider.DEFAULT stuff. * Change the ScannerService to natively return AnnotatedTypes * incorporate (or write a new) openwebbeans-arquillian. I'll ask Dan for contributing the stuff he wrote. We need this at OWB as the new TCK is based on Arquillian, and otherwise we would have cyclic build dependencies. Any other stuff for either 1.1.5 or 1.2.x planing? Maybe merging back the stuff David did in TomEE and is now effectively duplicated? LieGrue, strub
Re: [DISCUSS] Roadmap for 1.1.5 and beyond
+1 regards, gerhard 2012/5/22 Romain Manni-Bucau rmannibu...@gmail.com +1 - Romain 2012/5/22 Mark Struberg strub...@yahoo.de Hi folks! We currently are working on getting the FailOver stuff fixed + I like to change the getBeans() behaviour as defined on the cdi-spec list (doing the alternative filtering only later in BeanManager#resolve ). Are there other plans and stuff you like to get into 1.1.5? Wdyt about switching OWB-1.x into maintenance mode and start working on OWB-1.2 after that? I'd say we still _not_ switch the API to CDI-1.1 as it is by far too early, but we should do some bigger work like * HierarchicBeanManager * switch to AnnotatedType handling (MetaDataProvider.THIRD_PARTY) and ditch all our MetaDataProvider.DEFAULT stuff. * Change the ScannerService to natively return AnnotatedTypes * incorporate (or write a new) openwebbeans-arquillian. I'll ask Dan for contributing the stuff he wrote. We need this at OWB as the new TCK is based on Arquillian, and otherwise we would have cyclic build dependencies. Any other stuff for either 1.1.5 or 1.2.x planing? Maybe merging back the stuff David did in TomEE and is now effectively duplicated? LieGrue, strub
