[jira] [Updated] (OWB-1199) CDISeScannerService.autoScanning should be true by default

[John D. Ament (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OWB-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John D. Ament updated OWB-1199:
---
Attachment: OWB_1199.patch

Attached is a more complete patch with tests.

> CDISeScannerService.autoScanning should be true by default
> --
>
> Key: OWB-1199
> URL: https://issues.apache.org/jira/browse/OWB-1199
> Project: OpenWebBeans
>  Issue Type: Bug
>  Components: Core
>Reporter: John D. Ament
> Attachments: OWB_1199.patch
>
>
> The value of CDISeScannerService.autoScanning should be true by default.  
> There's no setter for this property, and the default value is false in java 
> so... this means this never does scanning.
> Here's a very simple patch to fix
> {code}
> Index: 
> webbeans-se/src/main/java/org/apache/openwebbeans/se/CDISeScannerService.java
> ===
> --- 
> webbeans-se/src/main/java/org/apache/openwebbeans/se/CDISeScannerService.java 
> (revision 1801946)
> +++ 
> webbeans-se/src/main/java/org/apache/openwebbeans/se/CDISeScannerService.java 
> (working copy)
> @@ -44,7 +44,7 @@
>  
>  public class CDISeScannerService extends AbstractMetaDataDiscovery
>  {
> -private boolean autoScanning;
> +private boolean autoScanning = true;
>  private final Collection classes = new ArrayList<>();
>  
>  public OwbAnnotationFinder getFinder()
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (OWB-1199) CDISeScannerService.autoScanning should be true by default

[John D. Ament (JIRA)]

John D. Ament created OWB-1199:
--

 Summary: CDISeScannerService.autoScanning should be true by default
 Key: OWB-1199
 URL: https://issues.apache.org/jira/browse/OWB-1199
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Reporter: John D. Ament


The value of CDISeScannerService.autoScanning should be true by default.  
There's no setter for this property, and the default value is false in java 
so... this means this never does scanning.

Here's a very simple patch to fix

{code}
Index: 
webbeans-se/src/main/java/org/apache/openwebbeans/se/CDISeScannerService.java
===
--- 
webbeans-se/src/main/java/org/apache/openwebbeans/se/CDISeScannerService.java   
(revision 1801946)
+++ 
webbeans-se/src/main/java/org/apache/openwebbeans/se/CDISeScannerService.java   
(working copy)
@@ -44,7 +44,7 @@
 
 public class CDISeScannerService extends AbstractMetaDataDiscovery
 {
-private boolean autoScanning;
+private boolean autoScanning = true;
 private final Collection classes = new ArrayList<>();
 
 public OwbAnnotationFinder getFinder()
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: AutoScanning off by default in SE?

[John D. Ament]

Created https://issues.apache.org/jira/browse/OWB-1199 and added a patch.

John

On Fri, Jul 14, 2017 at 8:15 AM Romain Manni-Bucau 
wrote:

> Hi John,
>
> should be at true by default yes
>
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | JavaEE Factory
> 
>
> 2017-07-14 13:14 GMT+02:00 John D. Ament :
>
> > Hi,
> >
> > I was trying to wire in Hammock w/ OWB 2.  I noticed that
> > in CDISeScannerService autoScanning isn't set.  I can't find a way to set
> > it to true.  The behavior in Weld is that this is on by default, hence
> why
> > in SeContainerInitializer there's only a disableDiscovery method.
> >
> > John
> >
>

Re: AutoScanning off by default in SE?

[Romain Manni-Bucau]

Hi John,

should be at true by default yes


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-07-14 13:14 GMT+02:00 John D. Ament :

> Hi,
>
> I was trying to wire in Hammock w/ OWB 2.  I noticed that
> in CDISeScannerService autoScanning isn't set.  I can't find a way to set
> it to true.  The behavior in Weld is that this is on by default, hence why
> in SeContainerInitializer there's only a disableDiscovery method.
>
> John
>

AutoScanning off by default in SE?

[John D. Ament]

Hi,

I was trying to wire in Hammock w/ OWB 2.  I noticed that
in CDISeScannerService autoScanning isn't set.  I can't find a way to set
it to true.  The behavior in Weld is that this is on by default, hence why
in SeContainerInitializer there's only a disableDiscovery method.

John