Re: configureProducerMethodSpecialization looks pretty much overcomplicated
+1 regards, gerhard 2017-12-19 9:01 GMT+01:00 Mark Struberg : > Hi folks! > > Currently refactoring the WebBeansUtil#configureProducerMethodSpecial > izations. > > This method is not easy to follow and could be seriously simplified. > > I already moved all the condition checks to a common place, unifying the > checks from ProducerMethodBuilder and the ondes in WebBeansUtil. > > The next step is to simplify the condition checks itself. > It looks that the original approach have been a red/black tree like > algorithm to avoid n^2. > But by always creating a fresh sorted list of all producer method beans > inside this loop, we got the issue anyway. > > My current try is to sort all the beans just once and then disable all the > producer methods who got overwritten. > This means that the sorting has to be reversed, with the subclasses first, > then the parent classes later. > > It's quite some change, but it gladly only affects specialized producer > methods. > Still we should critically review the refactoring. > > txs and LieGrue, > strub > >
Re: [VOTE] Release Apache OpenWebBeans-2.0.3
+1 regards, gerhard 2017-12-20 16:01 GMT+01:00 Mark Struberg : > Hi folks! > > I did run all steps to release OWB-2.0.3. > > We fixed the following bugs and improvements > > Bug > > [OWB-1171] - @Priority and @Alternative as sterotype > [OWB-1219] - Prioritized custom Bean gets ignored if ManagedBean with > @Priority exists > [OWB-1220] - URL-encoding issue in AbstractMetaDataDiscovery > [OWB-1222] - subclass proxy fails with Java9 > > Improvement > > [OWB-1218] - improve toString of producer beans to also log owner class > > Task > > [OWB-1221] - Upgrade to asm 6 > > With ASM6 we are now fully able to run on Java9. We do not yet support all > Java9 features like jmods and jigsaw though. > > > Here is the staging repo > https://repository.apache.org/content/repositories/ > orgapacheopenwebbeans-1034/ > > And the source zip > https://repository.apache.org/content/repositories/ > orgapacheopenwebbeans-1034/org/apache/openwebbeans/openwebbeans/2.0.3/ > The sha1 is c59ed556a30405ca6f6484456fd9b6d264ca7533 > > > Please VOTE > > [+1] yea, ship it > [+0] meh, don't care > [-1] nope stop, because ${showstopper} > > The VOTE is open for 72h. > > txs and LieGrue, > strub > >