Re: Release?
Great, Udo :) +1 on committing the patch! Regards, Jakob 2011/8/2 Gerhard Petracek gerhard.petra...@gmail.com: @udo: thx for testing it. if there are no objections, i'll commit the patch for OWB-582 tomorrow. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/8/2 Udo Schnurpfeil u...@schnurpfeil.de Hi, I've now tested the patch and it works good with: - Tomcat 5.5.33 + Java 1.5 - WebSphere 6.1 + Java 1.5 I've also applied the patch for OWB-583 to get it running with Servlet API 2.4. With this 2 patches applied I'm looking forward to the release of version 1.1.1. Regards, Udo Am 01.08.11 21:03, schrieb Gerhard Petracek: @mark: +1 furthermore, udo will test OWB-582. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/8/1 Mark Struberg strub...@yahoo.de Hi David! I'd like to do some performance/memory tests I propsoed in OWB-600 before kicking a release. LieGrue, strub --- On Mon, 8/1/11, David Blevins david.blev...@gmail.com wrote: From: David Blevins david.blev...@gmail.com Subject: Release? To: dev@openwebbeans.apache.org Date: Monday, August 1, 2011, 6:13 PM We'll probably be doing releases of Geronimo in the next couple weeks. Wondering what we thought about the timing for our 1.1.1 code. Anything in particular we want to get in it or are we pretty much good to go? -David -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [vote] project logo
+1 for #1 Regards, Jakob 2011/5/7 Mark Struberg strub...@yahoo.de: +1 for #1 +1 for #3 for dark background or as transparent background (ideally it would be #1 inverted - #3 or #2 with the colors from #1) txs and LieGrue, strub - Original Message - From: Gerhard Petracek gerhard.petra...@gmail.com To: dev@openwebbeans.apache.org Cc: Sent: Saturday, May 7, 2011 7:35 AM Subject: Re: [vote] project logo +1 for #1 (and +1 for #2 for dark backgrounds) regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/7 Gerhard Petracek gpetra...@apache.org hi @ all, please have a look at [1] and vote for your preferred logo. regards, gerhard [1] http://people.apache.org/~gpetracek/owb/logo_drafts/ -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: owb logo
Yes, great idea! +1 Regards, Jakob 2011/5/2 Gerhard Petracek gerhard.petra...@gmail.com: +1 regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/2 Mark Struberg strub...@yahoo.de yup, gimme 3 days plz, will get this going after returning from JAX on friday :) And once again thanks Irian and Adonis! Btw, imo we should mention Adonis as creator in our documentation and site and maybe add contact information? Or at least add him to the contributors section with his email. Might be a good promotion. wdyt? LieGrue, strub --- On Mon, 5/2/11, Gerhard Petracek gerhard.petra...@gmail.com wrote: From: Gerhard Petracek gerhard.petra...@gmail.com Subject: Re: owb logo To: dev@openwebbeans.apache.org Date: Monday, May 2, 2011, 6:38 PM hi @ all, if we don't need changes, we should vote! regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/5/2 Adonis Raduca adonis.rad...@codebeat.ro Hi, I'm glad you like my logo approach for the OWB ;) If you need the logo in any format (eg. PNG) or for different purposes (tshirt printing) please let me know and I will provide the needed stuff for you. Adonis On Fri, Apr 29, 2011 at 7:07 PM, Rohit Kelapure kelap...@gmail.com wrote: Very Nice. Thank you Adonis! On Fri, Apr 29, 2011 at 10:31 AM, Jakob Korherr jakob.korh...@gmail.com wrote: Really nice work, Adonis! Regards, Jakob 2011/4/29 Joseph Bergmark bergm...@apache.org: Agreed, they are excellent! Joe On Fri, Apr 29, 2011 at 9:31 AM, Mark Struberg strub...@yahoo.de wrote: wow, they all look great! LieGrue, strub --- On Fri, 4/29/11, Gerhard Petracek gpetra...@apache.org wrote: From: Gerhard Petracek gpetra...@apache.org Subject: Re: owb logo To: dev@openwebbeans.apache.org Cc: Adonis Raduca adonis.rad...@codebeat.ro Date: Friday, April 29, 2011, 1:26 PM hi @ all, adonis sent me some nice drafts! i uploaded them to: http://people.apache.org/~gpetracek/owb/logo_drafts/ regards, gerhard 2011/4/18 Rohit Kelapure kelap...@gmail.com Very nice. Thank you Gerhard and Adonis! On Mon, Apr 18, 2011 at 2:59 AM, Gerhard Petracek gerhard.petra...@gmail.com wrote: i've great news! adonis will create a logo for us. he designed the whole style of apache myfaces. usually he comes up with an awesome draft. so we just have to wait some time until we can talk about the first draft. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/4/9 Mark Struberg strub...@yahoo.de +1 This is on our list for too long ;) But who is going to do it? LieGrue, strub --- On Sat, 4/9/11, Gerhard Petracek gerhard.petra...@gmail.com wrote: From: Gerhard Petracek gerhard.petra...@gmail.com Subject: owb logo To: dev@openwebbeans.apache.org Date: Saturday, April 9, 2011, 6:31 PM hi @ all, what do you think about creating a new owb logo? regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: owb logo
Really nice work, Adonis! Regards, Jakob 2011/4/29 Joseph Bergmark bergm...@apache.org: Agreed, they are excellent! Joe On Fri, Apr 29, 2011 at 9:31 AM, Mark Struberg strub...@yahoo.de wrote: wow, they all look great! LieGrue, strub --- On Fri, 4/29/11, Gerhard Petracek gpetra...@apache.org wrote: From: Gerhard Petracek gpetra...@apache.org Subject: Re: owb logo To: dev@openwebbeans.apache.org Cc: Adonis Raduca adonis.rad...@codebeat.ro Date: Friday, April 29, 2011, 1:26 PM hi @ all, adonis sent me some nice drafts! i uploaded them to: http://people.apache.org/~gpetracek/owb/logo_drafts/ regards, gerhard 2011/4/18 Rohit Kelapure kelap...@gmail.com Very nice. Thank you Gerhard and Adonis! On Mon, Apr 18, 2011 at 2:59 AM, Gerhard Petracek gerhard.petra...@gmail.com wrote: i've great news! adonis will create a logo for us. he designed the whole style of apache myfaces. usually he comes up with an awesome draft. so we just have to wait some time until we can talk about the first draft. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/4/9 Mark Struberg strub...@yahoo.de +1 This is on our list for too long ;) But who is going to do it? LieGrue, strub --- On Sat, 4/9/11, Gerhard Petracek gerhard.petra...@gmail.com wrote: From: Gerhard Petracek gerhard.petra...@gmail.com Subject: owb logo To: dev@openwebbeans.apache.org Date: Saturday, April 9, 2011, 6:31 PM hi @ all, what do you think about creating a new owb logo? regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: owb logo
That's really great news, Gerhard! Thanks a lot, Adonis :) Regards, Jakob 2011/4/18, Gerhard Petracek gerhard.petra...@gmail.com: i've great news! adonis will create a logo for us. he designed the whole style of apache myfaces. usually he comes up with an awesome draft. so we just have to wait some time until we can talk about the first draft. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/4/9 Mark Struberg strub...@yahoo.de +1 This is on our list for too long ;) But who is going to do it? LieGrue, strub --- On Sat, 4/9/11, Gerhard Petracek gerhard.petra...@gmail.com wrote: From: Gerhard Petracek gerhard.petra...@gmail.com Subject: owb logo To: dev@openwebbeans.apache.org Date: Saturday, April 9, 2011, 6:31 PM hi @ all, what do you think about creating a new owb logo? regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
[jira] Commented: (OWB-481) WebBeansConfigurationListener implementing ServletContextListener is not likely to work
[ https://issues.apache.org/jira/browse/OWB-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923803#action_12923803 ] Jakob Korherr commented on OWB-481: --- Note that the ServletContainerInitializer is only available for Servlet 3.0 environments, there is no such thing for Servlet 2.5. In addition you're just moving this problem from the ServletContextListener to the ServletContainerInitializer. Furthermore I think this is not an OWB problem, but rather a user problem. If the user wants to use OWB in his ServletContextListener(s), he has to make sure that OWB will be initialized at this point of time. We do the same in MyFaces for this problem. For the Geronimo integration I think it should be possible to call the OWB-initialization code from the Geronimo deployer before any ServletContainerInitializer or ServletContextListener is called in order to circumvent this problem. WebBeansConfigurationListener implementing ServletContextListener is not likely to work --- Key: OWB-481 URL: https://issues.apache.org/jira/browse/OWB-481 Project: OpenWebBeans Issue Type: Bug Reporter: David Jencks Assignee: Gurkan Erdogdu Currently WebBeansConfigurationListener implements ServletContextListener and uses the contextInitialized method to initialize OWB for the web app. Given an application containing a ServletContextListener that is a web bean, this requires that 1. the OWB WebBeansConfigurationListener ServletContextListener get installed before the app's ServletContextListeners 2. the OWB WebBeansConfigurationListener have it's contextInitialized called before the servlet container instantiates the apps ServletContextListeners that are web beans. There's no way to guarantee this will happen in a compliant servlet container. (Neither happens in the geronimo tomcat integration; we could force the first to happen, but not the second). It might be possible to do the initialization in a ServletContainerInitializer since I think these get called before any application classes start getting instantiated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [VOTE] release Apache OpenWebBeans-1.0.0 2nd try
+1 Regards, Jakob 2010/10/12 Mark Struberg strub...@yahoo.de: here is my +1 LieGrue, strub --- On Tue, 10/12/10, Mark Struberg strub...@yahoo.de wrote: From: Mark Struberg strub...@yahoo.de Subject: [VOTE] release Apache OpenWebBeans-1.0.0 2nd try To: dev@openwebbeans.apache.org Date: Tuesday, October 12, 2010, 12:08 PM Hi! I've re-rolled the release with the fixed readme and now like to call a 2nd VOTE on releasing Apache OpenWebBeans-1.0.0 . Maven staging repo: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-002/ SVN source tag (1021752): https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.0.0/ Source release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-002/org/apache/openwebbeans/openwebbeans/1.0.0/openwebbeans-1.0.0-source-release.zip Binary release: https://repository.apache.org/content/repositories/orgapacheopenwebbeans-002/org/apache/openwebbeans/openwebbeans-distribution/1.0.0/openwebbeans-distribution-1.0.0-binary.tar.gz PGP release key 2FDB81B1 http://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS Vote will be open for 72 hours. [ ] +1 approve [ ] +0 no opinion [ ] -1 veto (and reason why) still valid: A small note: I've created a owb_1.0.x branch which will contain the maintenance work on OWB-1.0.x. Feature development will be performed in trunk which now has a version of 1.1.0-SNAPSHOT txs and LieGrue, strub -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: ambiguous dependencies when using multiple qualifiers
OK, thanks for the clarification!
Regards,
Jakob
2010/9/29 Joseph Bergmark bergm...@apache.org:
I think you hit the nail on the head with your last paragraph.
Basically it only matters that the bean (or producer in this case)
matches all of the qualifiers on the injection point. From the
perspective of the specification it doesn't matter if the bean has
extra qualifiers beyond those on the injection point. Section 5.3 is
another key section here.
Sincerely,
Joe
On Wed, Sep 29, 2010 at 12:30 PM, Jakob Korherr jakob.korh...@gmail.com
wrote:
Hi,
I tested some scenarios when using multiple qualifiers for test-cases
in MyFaces CODI and stumbled upon the following scenario, which is not
totally clear to me.
Image you have the following producer methods:
�...@produces
�...@qualifier2
�...@applicationscoped
public ProducerBean createWithQualifier2()
{
return new ProducerBean();
}
�...@produces
�...@qualifier1
�...@qualifier2
�...@applicationscoped
public ProducerBean createWithQualifier1And2()
{
return new ProducerBean();
}
and you want to inject the instances produced by these producers. Now
you can use @Inject @Qualifier1 or @Inject @Qualifier1 @Qualifier2,
but when using @Inject @Qualifier2 you will get an exception, because
the injection point is ambiguous (both producers provide @Qualifier2).
However I was wondering if this is really unresolvable ambiguous,
because if you think about it, it would make sence to take the
producer createWithQualifier2() in this scenario (because the other
one provides additional qualifiers).
I also took a look in the CDI spec about this, but could only find the
following from section 2.3.4: A bean may only be injected to an
injection point if it has all the qualifiers of the injection point.
Of course this applies to both producers and thus, yes, it's kinda
ambiguous.
WDYT?
Regards,
Jakob
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
[jira] Updated: (OWB-466) Ensure removal of all ThreadLocal values
[ https://issues.apache.org/jira/browse/OWB-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Korherr updated OWB-466: -- Attachment: OWB-466.patch Ensure removal of all ThreadLocal values Key: OWB-466 URL: https://issues.apache.org/jira/browse/OWB-466 Project: OpenWebBeans Issue Type: Bug Affects Versions: 1.0.0-alpha-2 Reporter: Jakob Korherr Assignee: Gurkan Erdogdu Attachments: OWB-466.patch While running our automated webapp tests with MyFaces CODI and OWB, I always got the following log entries: 30.09.2010 16:14:14 org.apache.catalina.loader.WebappClassLoader clearThreadLocalMap SCHWERWIEGEND: A web application created a ThreadLocal with key of type [java.lang.ThreadLocal] (value [java.lang.threadlo...@543c944f]) and a value of type [org.apache.webbeans.inject.impl.InjectionPointImpl] (value [Field Injection Point, field name : postConstructApplicationEvent, Bean Owner : [Name:systemEventBroadcaster,WebBeans Type:MANAGED,API Types:[java.lang.Object,org.apache.myfaces.extensions.cdi.jsf2.impl.listener.system.SystemEventBroadcaster],Qualifiers:[javax.enterprise.inject.Any,javax.enterprise.inject.Default,javax.inject.Named]]]) but failed to remove it when the web application was stopped. To prevent a memory leak, the ThreadLocal has been forcibly removed. 30.09.2010 16:14:14 org.apache.catalina.loader.WebappClassLoader clearThreadLocalMap SCHWERWIEGEND: A web application created a ThreadLocal with key of type [java.lang.ThreadLocal] (value [java.lang.threadlo...@552cf9bd]) and a value of type [org.apache.webbeans.context.SessionContext] (value [org.apache.webbeans.context.sessioncont...@7bc012fa]) but failed to remove it when the web application was stopped. To prevent a memory leak, the ThreadLocal has been forcibly removed. 30.09.2010 16:14:14 org.apache.catalina.loader.WebappClassLoader clearThreadLocalMap SCHWERWIEGEND: A web application created a ThreadLocal with key of type [java.lang.ThreadLocal] (value [java.lang.threadlo...@552cf9bd]) and a value of type [org.apache.webbeans.context.SessionContext] (value [org.apache.webbeans.context.sessioncont...@7f1e1a8e]) but failed to remove it when the web application was stopped. To prevent a memory leak, the ThreadLocal has been forcibly removed. 30.09.2010 16:14:14 org.apache.coyote.http11.Http11Protocol destroy ..saying that Tomcat's webappclassloader had to remove some ThreadLocal values from the ThreadMap. I was able to track the affected ThreadLocal instances down: InstanceBean.local and WebContextsService.sessionContext. After digging into the code, I found out that there are many remove() operations on various ThreadLocal instances, but it was not thought that remove() only works for the current Thread. Thus when a ThreadLocal is set during a request it won't be removed when the container stops, because the shutdown-thread is clearly not the same as the request-thread. This means the request-ThreadLocal instances have to be removed after every request has ended - in requestDestroyed(ServletRequestEvent event). The provided patch adds some remove() calls in requestDestroyed() and also in afterStopApplication(). With this patch none of the above error-logs are shown in any of my test cases. However there might be some other ThreadLocals which should be cleaned up at every request, but this solution currently works for me! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OWB-462) Refactor AnnotationUtil.hasAnnotationMember()
Refactor AnnotationUtil.hasAnnotationMember() - Key: OWB-462 URL: https://issues.apache.org/jira/browse/OWB-462 Project: OpenWebBeans Issue Type: Task Components: Core Affects Versions: 1.0.0-alpha-2 Reporter: Jakob Korherr Assignee: Gurkan Erdogdu We needed a method to compare qualifiers for MyFaces CODI and stumbled upon AnnotationUtil.hasAnnotationMember(). However this method is really messy, because it uses the String representation of an annotation to compare it and thus fails in various cases (e.g. when using annotation instances which implement toString() differently or by using array values in the qualifier). Furthermore it does not detect @Nonbinding fields correctly, if there is more than one annotation on the annotation-method. Also it's kinda weird that the method takes the Annotation-Class as an extra parameter, but it could just get it from one of the Annotation instances. I checked all usages and found out that this argument can be dropped. In addition I think it's better to rename the method to isQualifierEqual() - the usage is just a lot clearer. I implemented a custom solution for MyFaces CODI and I think it should also be applied here. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OWB-462) Refactor AnnotationUtil.hasAnnotationMember()
[ https://issues.apache.org/jira/browse/OWB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Korherr updated OWB-462: -- Attachment: OWB-462.patch The patch contains the refactored code and some test cases. Refactor AnnotationUtil.hasAnnotationMember() - Key: OWB-462 URL: https://issues.apache.org/jira/browse/OWB-462 Project: OpenWebBeans Issue Type: Task Components: Core Affects Versions: 1.0.0-alpha-2 Reporter: Jakob Korherr Assignee: Gurkan Erdogdu Attachments: OWB-462.patch We needed a method to compare qualifiers for MyFaces CODI and stumbled upon AnnotationUtil.hasAnnotationMember(). However this method is really messy, because it uses the String representation of an annotation to compare it and thus fails in various cases (e.g. when using annotation instances which implement toString() differently or by using array values in the qualifier). Furthermore it does not detect @Nonbinding fields correctly, if there is more than one annotation on the annotation-method. Also it's kinda weird that the method takes the Annotation-Class as an extra parameter, but it could just get it from one of the Annotation instances. I checked all usages and found out that this argument can be dropped. In addition I think it's better to rename the method to isQualifierEqual() - the usage is just a lot clearer. I implemented a custom solution for MyFaces CODI and I think it should also be applied here. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
