[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125921#comment-17125921 ] Mark Struberg commented on OWB-1326: The method is from the spec. It will not get removed of course. But it was NEVER evaluated internally. It was basically cargo cult style carried around without being used by anyone. For container integrators we have the official spec SPI plus our own SPI. This is what is guaranteed to be stable over versions. Internal helper classes are not. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125911#comment-17125911 ] Gurkan Erdogdu commented on OWB-1326: - Yup, he did not remove the method in API :) I added the @deprecated to BeanAttributesImpl#isNull method. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125897#comment-17125897 ] Romain Manni-Bucau commented on OWB-1326: - #wording - or "TooMuchShortcutException" I guess, he removed the method from Bean but it is provided by BeanAttributes (parent). I also needed to review the code to fully get it right. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125894#comment-17125894 ] Gurkan Erdogdu commented on OWB-1326: - [~romain.manni-bucau] But he says he will remove and I understood that he deleted > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125885#comment-17125885 ] Romain Manni-Bucau commented on OWB-1326: - [~gerdogdu] did you get the method was not deleted but only its constant impl? so if anyone uses isNull it still works, Mark didn't remove it ;), he just changed the way we impl-ed so API - even internal - stays stable and the same. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125880#comment-17125880 ] Gurkan Erdogdu commented on OWB-1326: - [~romain.manni-bucau] OK lets explain this way :) How are you sure that nobody is using isNull? there is no only TomEE but other applications/servers may use it. Actually, this is not a specific to OWB codebase, look Tomcat coebase(lots of @deprecated code any maybe they are never used but still in there). Nobody can remove the API methods instantly, first need to deprecate then remove. What is the problem with using @Deprecate? I am not against the removal, but APIs must not be removed immediately. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125871#comment-17125871 ] Romain Manni-Bucau commented on OWB-1326: - [~gerdogdu] internal means no need of deprecation, if used - and I know it is ;) - it is at the cost of this kind of change and it is fine. That said the application server point is right but not blocking, tomee is not affected at all by that for example and the change does not prevent any app server to still use this kind of feature, really. I don't think it is worth backpressuring OWB for such a thing since technically OWB already enables to do that cleanly - and trivially for this particular case. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125866#comment-17125866 ] Gurkan Erdogdu commented on OWB-1326: - [~romain.manni-bucau]This is an internal API but application server integrations may use internal APIs too. It is not logical to remove it before deprecation. First let the public to know it will remove shortly via deprecation, then remove it. Please don't assume that interal APIs must not be used anywhere. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125864#comment-17125864 ] Romain Manni-Bucau commented on OWB-1326: - [~gerdogdu] Mark just simplified internals, nothing user can hit so it is really fine in a minor, please review the commit > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125836#comment-17125836 ] Gurkan Erdogdu commented on OWB-1326: - We need to support previous users of API (2.x) but I think that we can remove it with 3.0 release. We can comment to the method that this is deprecated and will be removed from 3.x > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125799#comment-17125799 ] Mark Struberg commented on OWB-1326: It's really useless. It's used nowhere. We carry this information around for no reason really. This was meant to say whether the bean might return something which is null sometimes. But a.) This information never was reliable b.) It's of no use. Because this information is only needed during runtime. It's simply not static. And that was the reason it got ditched from the spec. > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OWB-1326) Bean#isNullable is ignored since CDI-1.1.
[ https://issues.apache.org/jira/browse/OWB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125791#comment-17125791 ] Gurkan Erdogdu commented on OWB-1326: - Please don't remove the code, Deprecate it > Bean#isNullable is ignored since CDI-1.1. > - > > Key: OWB-1326 > URL: https://issues.apache.org/jira/browse/OWB-1326 > Project: OpenWebBeans > Issue Type: Task >Affects Versions: 2.0.16 >Reporter: Mark Struberg >Assignee: Mark Struberg >Priority: Major > Fix For: 2.0.17 > > > Bean#isNullable is ignored since CDI-1.1. We can remove all the internal code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
