[jira] Commented: (OWB-487) Section 5.5.7 restrictions on injecting InjectionPoint not enforced

2010-10-31 Thread Gurkan Erdogdu (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12926753#action_12926753
 ] 

Gurkan Erdogdu commented on OWB-487:


Is the previous paragraph about plain beans of n...@dependent scope 
enforced? 
I think it is checked on some other places in OWB.

 Section 5.5.7 restrictions on injecting InjectionPoint not enforced
 ---

 Key: OWB-487
 URL: https://issues.apache.org/jira/browse/OWB-487
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: 1.1.0
Reporter: David Jencks
Assignee: Gurkan Erdogdu
 Attachments: OWB-487.patch


 Section 5.5.7 ends with a couple restrictions on injecting InjectionPoint.  
 Theres a tck test for one of them, an InjectionPoint in a servlet is not OK.
 text:
 f a bean that declares any scope other than @Dependent has an injection point 
 of type InjectionPoint and qualifier @Default, the container automatically 
 detects the problem and treats it as a definition error.
 If a Java EE component class supporting injection that is not a bean has an 
 injection point of type InjectionPoint and qualifier @Default, the container 
 automatically detects the problem and treats it as a definition error.
 test:
 org.jboss.jsr299.tck.tests.lookup.injectionpoint.broken.not.bean.InjectionPointTest
 org.jboss.jsr299.tck.tests.lookup.injectionpoint.broken.not.bean.TestServlet_Broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OWB-487) Section 5.5.7 restrictions on injecting InjectionPoint not enforced

2010-10-29 Thread David Jencks (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12926445#action_12926445
 ] 

David Jencks commented on OWB-487:
--

My patch is definitely a very bad idea, it causes a lot of other tck failures.

Gerkan pointed out on the dev list that the tck test can be made to pass by 
having an OWBPlugin identify Servlets as EE components.  I've modified the 
geronimo OWB plugin to do this and the test now passes.

Is the previous paragraph about plain beans of n...@dependent scope enforced?  
It looks like the OWBInjector.checkInjectionPointForInjectInjectionPoint method 
that enforces the check for ee components is only called for ee components.

 Section 5.5.7 restrictions on injecting InjectionPoint not enforced
 ---

 Key: OWB-487
 URL: https://issues.apache.org/jira/browse/OWB-487
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: 1.1.0
Reporter: David Jencks
Assignee: Gurkan Erdogdu
 Attachments: OWB-487.patch


 Section 5.5.7 ends with a couple restrictions on injecting InjectionPoint.  
 Theres a tck test for one of them, an InjectionPoint in a servlet is not OK.
 text:
 f a bean that declares any scope other than @Dependent has an injection point 
 of type InjectionPoint and qualifier @Default, the container automatically 
 detects the problem and treats it as a definition error.
 If a Java EE component class supporting injection that is not a bean has an 
 injection point of type InjectionPoint and qualifier @Default, the container 
 automatically detects the problem and treats it as a definition error.
 test:
 org.jboss.jsr299.tck.tests.lookup.injectionpoint.broken.not.bean.InjectionPointTest
 org.jboss.jsr299.tck.tests.lookup.injectionpoint.broken.not.bean.TestServlet_Broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OWB-487) Section 5.5.7 restrictions on injecting InjectionPoint not enforced

2010-10-28 Thread Eric Covener (JIRA)

[ 
https://issues.apache.org/jira/browse/OWB-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12926028#action_12926028
 ] 

Eric Covener commented on OWB-487:
--

I think this is best read as ... qualifiers @Default, @Any, and no other 
qualifiers which really means when the dependency will be satisfied by the 
containers built-in injection point.

 Section 5.5.7 restrictions on injecting InjectionPoint not enforced
 ---

 Key: OWB-487
 URL: https://issues.apache.org/jira/browse/OWB-487
 Project: OpenWebBeans
  Issue Type: Bug
  Components: Core
Affects Versions: 1.1.0
Reporter: David Jencks
Assignee: Gurkan Erdogdu
 Attachments: OWB-487.patch


 Section 5.5.7 ends with a couple restrictions on injecting InjectionPoint.  
 Theres a tck test for one of them, an InjectionPoint in a servlet is not OK.
 text:
 f a bean that declares any scope other than @Dependent has an injection point 
 of type InjectionPoint and qualifier @Default, the container automatically 
 detects the problem and treats it as a definition error.
 If a Java EE component class supporting injection that is not a bean has an 
 injection point of type InjectionPoint and qualifier @Default, the container 
 automatically detects the problem and treats it as a definition error.
 test:
 org.jboss.jsr299.tck.tests.lookup.injectionpoint.broken.not.bean.InjectionPointTest
 org.jboss.jsr299.tck.tests.lookup.injectionpoint.broken.not.bean.TestServlet_Broken

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.