Re:disallow init parameters at invoke time?
+1 to disallow it as init-parameters are not used at invoke time. The init function invokes once and only once in users’ mind, they wouldn't aware of reuse of the container. | | Bill Zong | | billz...@163.com ShenZhen, China | 签名由网易邮箱大师定制 On 12/21/2019 19:40，Rodric Rabbah wrote： This PR https://github.com/apache/openwhisk/pull/4559 added init-time parameters. It allows those parameters to be specified on action creation/updates as well as at invoke time. This note is to solicit feedback on whether the controller should disallow init-parameters at invoke time. The reason is that unless the activation is a fresh (cold) activation, the init-parameters will not be observable by the action (init-paramters are only sent at /init time and not /run time). So it can be confusing although it is also convenient for rapid iterations in the cloud (update/invoke pattern where the invoke is always cold after an update). Opinions and feedback? -r
Re: JDK 11
Thanks Martin. What I’m most interested in is knowing what other than the Gatling tests which we are running in Travis and can run in Jenkins if anything you’re doing differently so that the project can replicate and automate it where necessary. -r > On Dec 22, 2019, at 2:34 PM, Martin Henke wrote: > > Rodric, > > I forgot to mention. When we find a degradation (and I honestly do not hope > to see one) and we find the reason, we will of course share the information > needed to setup tests in the Apache environment to catch those. > > Regards, > Martin > >> Am 22.12.2019 um 20:29 schrieb Martin Henke : >> >> Rodric, >> >> It seems to be natural that the IBM environment differs in machine >> configuration and network bandwidth and any other parameters from any other >> OW installation. >> >> Nevertheless I see value for the project to test the JDK upgrade >> additionally in our env to identify potential problems. As said, we saw >> performance degredations before, which were not caught in the Apache >> environments. >> >> Regards, >> Martin >> >> P.S I am away from keyboard for the next time and might be slow in answering. >> Am 22.12.2019 um 19:33 schrieb Rodric Rabbah : >>> >>> Thanks Martin. Can you share the environment details/how it’s different >>> from the Jenkins job Vincent set up at one point for the project - so that >>> any testing important to the project can be done in apache land. >>> >>> -r >>> On Dec 22, 2019, at 9:35 AM, Martin Henke wrote: Rodric, there are no special tests beside the ones that were already contributed by Christian from our team. The unknowns are given by our environment. Regards, Martin Von meinem iPhone gesendet > Am 21.12.2019 um 12:45 schrieb Rodric Rabbah : > > Martin thanks for the input. Do you or others plan to contribute any of > the > performance testing that you're doing/will do to the project - and what > would it take to facilitate this so that we are also increasing the > project > velocity? > > -r > >>> On Sat, Dec 21, 2019 at 5:08 AM Martin Henke >>> wrote: >> >> Rodric, >> >> thank you for taking on this dangling task. >> >> Since we saw some severe performance impacts when we tried to move OW to >> other Java 8 JDK versions >> before, we would like to run the final change through our performance >> tests. >> >> Therefore I would like to ask for a short deferral until midth of January >> when people have returned >> from their Christmas holidays (you know that we Germans tend to have long >> holidays :-)). >> >> Regards, >> Martin >> >> >>> On 2019/12/20 21:56:12, Rodric Rabbah wrote: >>> This PR https://github.com/apache/openwhisk/pull/4706 move openwhisk >> to> >>> using Java 11 for building and running the controller/invoker >> containers.> >>> It has been open since Oct 30 with no comments since Nov 14. It was >> covered> >>> at the Dec 4 community call> >>> >> https://cwiki.apache.org/confluence/display/OPENWHISK/2019-12-04+OW+Tech+Interchange+Meeting+Notes> >> >>> and there was agreement to merge the PR.> >>> >>> Accordingly, I will merge it next week.> >>> >>> -r> >>> >> >
Re: JDK 11
Rodric, I forgot to mention. When we find a degradation (and I honestly do not hope to see one) and we find the reason, we will of course share the information needed to setup tests in the Apache environment to catch those. Regards, Martin > Am 22.12.2019 um 20:29 schrieb Martin Henke : > > Rodric, > > It seems to be natural that the IBM environment differs in machine > configuration and network bandwidth and any other parameters from any other > OW installation. > > Nevertheless I see value for the project to test the JDK upgrade additionally > in our env to identify potential problems. As said, we saw performance > degredations before, which were not caught in the Apache environments. > > Regards, > Martin > > P.S I am away from keyboard for the next time and might be slow in answering. > >> Am 22.12.2019 um 19:33 schrieb Rodric Rabbah : >> >> Thanks Martin. Can you share the environment details/how it’s different >> from the Jenkins job Vincent set up at one point for the project - so that >> any testing important to the project can be done in apache land. >> >> -r >> >>> On Dec 22, 2019, at 9:35 AM, Martin Henke wrote: >>> >>> Rodric, >>> >>> there are no special tests beside the ones that were already contributed by >>> Christian from our team. >>> >>> The unknowns are given by our environment. >>> >>> Regards, >>> Martin >>> >>> Von meinem iPhone gesendet >>> Am 21.12.2019 um 12:45 schrieb Rodric Rabbah : Martin thanks for the input. Do you or others plan to contribute any of the performance testing that you're doing/will do to the project - and what would it take to facilitate this so that we are also increasing the project velocity? -r >> On Sat, Dec 21, 2019 at 5:08 AM Martin Henke wrote: > > Rodric, > > thank you for taking on this dangling task. > > Since we saw some severe performance impacts when we tried to move OW to > other Java 8 JDK versions > before, we would like to run the final change through our performance > tests. > > Therefore I would like to ask for a short deferral until midth of January > when people have returned > from their Christmas holidays (you know that we Germans tend to have long > holidays :-)). > > Regards, > Martin > > >> On 2019/12/20 21:56:12, Rodric Rabbah wrote: >> This PR https://github.com/apache/openwhisk/pull/4706 move openwhisk > to> >> using Java 11 for building and running the controller/invoker > containers.> >> It has been open since Oct 30 with no comments since Nov 14. It was > covered> >> at the Dec 4 community call> >> > https://cwiki.apache.org/confluence/display/OPENWHISK/2019-12-04+OW+Tech+Interchange+Meeting+Notes> > >> and there was agreement to merge the PR.> >> >> Accordingly, I will merge it next week.> >> >> -r> >> >>> >
Re: JDK 11
Rodric, It seems to be natural that the IBM environment differs in machine configuration and network bandwidth and any other parameters from any other OW installation. Nevertheless I see value for the project to test the JDK upgrade additionally in our env to identify potential problems. As said, we saw performance degredations before, which were not caught in the Apache environments. Regards, Martin P.S I am away from keyboard for the next time and might be slow in answering. > Am 22.12.2019 um 19:33 schrieb Rodric Rabbah : > > Thanks Martin. Can you share the environment details/how it’s different from > the Jenkins job Vincent set up at one point for the project - so that any > testing important to the project can be done in apache land. > > -r > >> On Dec 22, 2019, at 9:35 AM, Martin Henke wrote: >> >> Rodric, >> >> there are no special tests beside the ones that were already contributed by >> Christian from our team. >> >> The unknowns are given by our environment. >> >> Regards, >> Martin >> >> Von meinem iPhone gesendet >> >>> Am 21.12.2019 um 12:45 schrieb Rodric Rabbah : >>> >>> Martin thanks for the input. Do you or others plan to contribute any of the >>> performance testing that you're doing/will do to the project - and what >>> would it take to facilitate this so that we are also increasing the project >>> velocity? >>> >>> -r >>> > On Sat, Dec 21, 2019 at 5:08 AM Martin Henke wrote: Rodric, thank you for taking on this dangling task. Since we saw some severe performance impacts when we tried to move OW to other Java 8 JDK versions before, we would like to run the final change through our performance tests. Therefore I would like to ask for a short deferral until midth of January when people have returned from their Christmas holidays (you know that we Germans tend to have long holidays :-)). Regards, Martin > On 2019/12/20 21:56:12, Rodric Rabbah wrote: > This PR https://github.com/apache/openwhisk/pull/4706 move openwhisk to> > using Java 11 for building and running the controller/invoker containers.> > It has been open since Oct 30 with no comments since Nov 14. It was covered> > at the Dec 4 community call> > https://cwiki.apache.org/confluence/display/OPENWHISK/2019-12-04+OW+Tech+Interchange+Meeting+Notes> > and there was agreement to merge the PR.> > > Accordingly, I will merge it next week.> > > -r> > >>
Re: JDK 11
Thanks Martin. Can you share the environment details/how it’s different from the Jenkins job Vincent set up at one point for the project - so that any testing important to the project can be done in apache land. -r > On Dec 22, 2019, at 9:35 AM, Martin Henke wrote: > > Rodric, > > there are no special tests beside the ones that were already contributed by > Christian from our team. > > The unknowns are given by our environment. > > Regards, > Martin > > Von meinem iPhone gesendet > >> Am 21.12.2019 um 12:45 schrieb Rodric Rabbah : >> >> Martin thanks for the input. Do you or others plan to contribute any of the >> performance testing that you're doing/will do to the project - and what >> would it take to facilitate this so that we are also increasing the project >> velocity? >> >> -r >> On Sat, Dec 21, 2019 at 5:08 AM Martin Henke wrote: >>> >>> Rodric, >>> >>> thank you for taking on this dangling task. >>> >>> Since we saw some severe performance impacts when we tried to move OW to >>> other Java 8 JDK versions >>> before, we would like to run the final change through our performance >>> tests. >>> >>> Therefore I would like to ask for a short deferral until midth of January >>> when people have returned >>> from their Christmas holidays (you know that we Germans tend to have long >>> holidays :-)). >>> >>> Regards, >>> Martin >>> >>> On 2019/12/20 21:56:12, Rodric Rabbah wrote: This PR https://github.com/apache/openwhisk/pull/4706 move openwhisk >>> to> using Java 11 for building and running the controller/invoker >>> containers.> It has been open since Oct 30 with no comments since Nov 14. It was >>> covered> at the Dec 4 community call> >>> https://cwiki.apache.org/confluence/display/OPENWHISK/2019-12-04+OW+Tech+Interchange+Meeting+Notes> >>> and there was agreement to merge the PR.> Accordingly, I will merge it next week.> -r> >
Re: disallow init parameters at invoke time?
+1 To disallow init-parameters at invoke time. But I'd like to keep the OW environment variables that are sent at /init time. Best regards Seonghyun (@upgle) 2019년 12월 21일 (토) 오후 8:41, Rodric Rabbah 님이 작성: > This PR https://github.com/apache/openwhisk/pull/4559 added init-time > parameters. It allows those parameters to be specified on action > creation/updates as well as at invoke time. > > This note is to solicit feedback on whether the controller should disallow > init-parameters at invoke time. The reason is that unless the activation is > a fresh (cold) activation, the init-parameters will not be observable by > the action (init-paramters are only sent at /init time and not /run time). > > So it can be confusing although it is also convenient for rapid iterations > in the cloud (update/invoke pattern where the invoke is always cold after > an update). > > Opinions and feedback? > > -r >
Re: JDK 11
Rodric, there are no special tests beside the ones that were already contributed by Christian from our team. The unknowns are given by our environment. Regards, Martin Von meinem iPhone gesendet > Am 21.12.2019 um 12:45 schrieb Rodric Rabbah : > > Martin thanks for the input. Do you or others plan to contribute any of the > performance testing that you're doing/will do to the project - and what > would it take to facilitate this so that we are also increasing the project > velocity? > > -r > >> On Sat, Dec 21, 2019 at 5:08 AM Martin Henke wrote: >> >> Rodric, >> >> thank you for taking on this dangling task. >> >> Since we saw some severe performance impacts when we tried to move OW to >> other Java 8 JDK versions >> before, we would like to run the final change through our performance >> tests. >> >> Therefore I would like to ask for a short deferral until midth of January >> when people have returned >> from their Christmas holidays (you know that we Germans tend to have long >> holidays :-)). >> >> Regards, >> Martin >> >> >>> On 2019/12/20 21:56:12, Rodric Rabbah wrote: >>> This PR https://github.com/apache/openwhisk/pull/4706 move openwhisk >> to> >>> using Java 11 for building and running the controller/invoker >> containers.> >>> It has been open since Oct 30 with no comments since Nov 14. It was >> covered> >>> at the Dec 4 community call> >>> >> https://cwiki.apache.org/confluence/display/OPENWHISK/2019-12-04+OW+Tech+Interchange+Meeting+Notes> >> >>> and there was agreement to merge the PR.> >>> >>> Accordingly, I will merge it next week.> >>> >>> -r> >>>
Re: disallow init parameters at invoke time?
+1 to disallow it as init-parameters are not used at invoke time. The clearer the better. Best regards Dominic 2019년 12월 21일 (토) 오후 8:41, Rodric Rabbah 님이 작성: > This PR https://github.com/apache/openwhisk/pull/4559 added init-time > parameters. It allows those parameters to be specified on action > creation/updates as well as at invoke time. > > This note is to solicit feedback on whether the controller should disallow > init-parameters at invoke time. The reason is that unless the activation is > a fresh (cold) activation, the init-parameters will not be observable by > the action (init-paramters are only sent at /init time and not /run time). > > So it can be confusing although it is also convenient for rapid iterations > in the cloud (update/invoke pattern where the invoke is always cold after > an update). > > Opinions and feedback? > > -r >
Re: [proposal] remove vagrant support
+1 as we already discussed once at the community call. Best regards Dominic 2019년 12월 20일 (금) 오후 11:15, Rodric Rabbah 님이 작성: > hi, > > as I am going through the issues, there have been a bunch related to > vagrant rotting (which I've closed for the most part as stale). > > i propose to remove the vagrant support from the openwhisk repo and > documentation - i'm not aware of anyone maintaining it, especially judging > by the lack of answers to the questions/issues others have opened on > vagrant issues. > > i will proceed to remove it by silent assent if there are no objections in > 72 hours. > > -r >
