Re: Upcoming wskdebug release 1.3
If you can send me your key, preferably encrypted to my GPG key, I can add it to the KEYS file for you. See second to last key in this file for a copy of the key: https://dist.apache.org/repos/dist/release/logging/KEYS On Tue, 28 Jul 2020 at 21:41, Matt Sicker wrote: > > The KEYS file is indeed PMC-only writable. I believe it’s because only PMC > members can sign the release as their release votes are binding. I can take > care of this. > > On Tue, Jul 28, 2020 at 21:30 Rodric Rabbah wrote: >> >> > Can a PMC member help out? I'm buried for the next few days on some >> non-OpenWhisk deadlines. >> >> Will try tomorrow. >> >> -r > > -- > Matt Sicker -- Matt Sicker
Re: Upcoming wskdebug release 1.3
The KEYS file is indeed PMC-only writable. I believe it’s because only PMC members can sign the release as their release votes are binding. I can take care of this. On Tue, Jul 28, 2020 at 21:30 Rodric Rabbah wrote: > > Can a PMC member help out? I'm buried for the next few days on some > non-OpenWhisk deadlines. > > Will try tomorrow. > > -r > -- Matt Sicker
Re: Upcoming wskdebug release 1.3
> Can a PMC member help out? I'm buried for the next few days on some non-OpenWhisk deadlines. Will try tomorrow. -r
RE: Upcoming wskdebug release 1.3
Alexander Klimetschek wrote on 07/28/2020 09:50:48 PM: > > Ah, I had no idea about [1]. > > I tried to commit my key in the KEYS file, but I get the following error: > ...elided... I think this is another undocumented assumption. Sorry. I'm pretty sure the part of the svn repo that is used to stage releases is only writable by OpenWhisk PMC members per ASF policy. One of us will have to do some of the steps for you. Can a PMC member help out? I'm buried for the next few days on some non-OpenWhisk deadlines. --dave
Re: Upcoming wskdebug release 1.3
Ah, I had no idea about [1]. I tried to commit my key in the KEYS file, but I get the following error: $ svn ci KEYS SendingKEYS Transmitting file data .svn: E195023: Commit failed (details follow): svn: E195023: Changing file '/Users/alex/Work/code/nui/openwhisk-release/stagingArea/svn_release/KEYS' is forbidden by the server svn: E175013: Access to '/repos/dist/!svn/txr/40740-yd5/release/openwhisk/KEYS' forbidden svn: E195023: Your commit message was left in a temporary file: svn: E195023: '/Users/alex/Work/code/nui/openwhisk-release/stagingArea/svn_release/svn-commit.tmp' [1] https://github.com/apache/openwhisk-release/blob/master/docs/release_manager_setup.md Cheers, Alex From: David P Grove Sent: Tuesday, July 28, 2020 13:51 To: dev@openwhisk.apache.org Subject: RE: Upcoming wskdebug release 1.3 There perhaps should be a cross-reference somewhere. There is a separate document on "first time" setup for a release manager [1] that talks about setting up the signing infrastructure. --dave [1] https://github.com/apache/openwhisk-release/blob/master/docs/release_manager_setup.md Rodric Rabbah wrote on 07/28/2020 04:02:21 PM: > From: Rodric Rabbah > To: dev@openwhisk.apache.org > Date: 07/28/2020 04:03 PM > Subject: [EXTERNAL] Re: Upcoming wskdebug release 1.3 > > We may have one more step missing. Did you add your key to the KEYS file? > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_blob_master_docs_release-5Fmanager-5Fsetup.md-23publish-2Dyour-2Dpublic-2Dkey-2Dto-2Dthe-2Dproject-2Dkeys-2Dfile&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=DEIrPdMPA- > AMmYjPFPbmxd4V_dhoNMgol_GBLjmQ5Wg&e= > > I don't see your key here [1] and hence cannot verify the signature on the > release tarball yet. > > -r > > [1] https://urldefense.proofpoint.com/v2/url? > u=https-3A__dist.apache.org_repos_dist_release_openwhisk_KEYS&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=bh5ri0GNNeTDz1zGKVz9TyljGlx5_6jitnUB10CjOIM&e= > > > On Tue, Jul 28, 2020 at 3:59 PM Rodric Rabbah wrote: > > > Thanks Alex for noting these gaps! > > > > -r > > > > On Tue, Jul 28, 2020 at 3:20 PM Alexander Klimetschek > > wrote: > > > >> FWIW, I reported all these as issues (and the gen-release-vote.py one was > >> already reported): > >> > >> * https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_342&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=0X2YrKQ2PzjQzh1T3cxnOuoC- > Hjwbv-tq16Od76Qbs8&e= > >> * <https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_341&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=QXc0D7V- > OqjOfS_iRm-PnPg1PmKFiMWNZnWoHNuO2fo&e= > > >> https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_341&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=QXc0D7V- > OqjOfS_iRm-PnPg1PmKFiMWNZnWoHNuO2fo&e= > >> * https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_340&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=aPDAPENChIZOfT791CZmQAHaEUL6spc6LK4yz2i1qSg&e= > >> * https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_317&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=_dCdteTNUVXpRtmP6i04Ry3FplUFE9-9SZNxLEjaG9c&e= > >> > >> Cheers, > >> Alex > >> > >> > >> From: Alexander Klimetschek > >> Sent: Tuesday, July 28, 2020 11:47 > >> To: dev@openwhisk.apache.org > >> Subject: Re: Upcoming wskdebug release 1.3 > >> > >> Also: the ./gen-release-vote.py script assumes a certain naming > >> convention for cloning the https://urldefense.proofpoint.com/v2/ > url? > u=https-3A__git
RE: Upcoming wskdebug release 1.3
There perhaps should be a cross-reference somewhere. There is a separate document on "first time" setup for a release manager [1] that talks about setting up the signing infrastructure. --dave [1] https://github.com/apache/openwhisk-release/blob/master/docs/release_manager_setup.md Rodric Rabbah wrote on 07/28/2020 04:02:21 PM: > From: Rodric Rabbah > To: dev@openwhisk.apache.org > Date: 07/28/2020 04:03 PM > Subject: [EXTERNAL] Re: Upcoming wskdebug release 1.3 > > We may have one more step missing. Did you add your key to the KEYS file? > > https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_blob_master_docs_release-5Fmanager-5Fsetup.md-23publish-2Dyour-2Dpublic-2Dkey-2Dto-2Dthe-2Dproject-2Dkeys-2Dfile&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=DEIrPdMPA- > AMmYjPFPbmxd4V_dhoNMgol_GBLjmQ5Wg&e= > > I don't see your key here [1] and hence cannot verify the signature on the > release tarball yet. > > -r > > [1] https://urldefense.proofpoint.com/v2/url? > u=https-3A__dist.apache.org_repos_dist_release_openwhisk_KEYS&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=bh5ri0GNNeTDz1zGKVz9TyljGlx5_6jitnUB10CjOIM&e= > > > On Tue, Jul 28, 2020 at 3:59 PM Rodric Rabbah wrote: > > > Thanks Alex for noting these gaps! > > > > -r > > > > On Tue, Jul 28, 2020 at 3:20 PM Alexander Klimetschek > > wrote: > > > >> FWIW, I reported all these as issues (and the gen-release-vote.py one was > >> already reported): > >> > >> * https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_342&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=0X2YrKQ2PzjQzh1T3cxnOuoC- > Hjwbv-tq16Od76Qbs8&e= > >> * <https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_341&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=QXc0D7V- > OqjOfS_iRm-PnPg1PmKFiMWNZnWoHNuO2fo&e= > > >> https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_341&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=QXc0D7V- > OqjOfS_iRm-PnPg1PmKFiMWNZnWoHNuO2fo&e= > >> * https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_340&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=aPDAPENChIZOfT791CZmQAHaEUL6spc6LK4yz2i1qSg&e= > >> * https://urldefense.proofpoint.com/v2/url? > u=https-3A__github.com_apache_openwhisk-2Drelease_issues_317&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=_dCdteTNUVXpRtmP6i04Ry3FplUFE9-9SZNxLEjaG9c&e= > >> > >> Cheers, > >> Alex > >> > >> > >> From: Alexander Klimetschek > >> Sent: Tuesday, July 28, 2020 11:47 > >> To: dev@openwhisk.apache.org > >> Subject: Re: Upcoming wskdebug release 1.3 > >> > >> Also: the ./gen-release-vote.py script assumes a certain naming > >> convention for cloning the https://urldefense.proofpoint.com/v2/ > url? > u=https-3A__github.com_apache_openwhisk-2Drelease&d=DwIFaQ&c=jf_iaSHvJObTbx- > siA1ZOg&r=Fe4FicGBU_20P2yihxV- > apaNSFb6BSj6AlkptSF2gMk&m=5yYlLexRbv7o17SqJWk5sqD8oqfhO0BxPlMSlwGEeTQ&s=xE88inHjGL1_2DswT9SqqAY8xCm1gZK47_nheoQt4c0&e= > >> repo: > >> > >> * remote "upstream": for the actual repo > >> * remote "origin" (or anything): for ones local fork > >> > >> In my case I had no fork and just "origin" for the actual repo, resulting > >> in this error: > >> > >> subprocess.CalledProcessError: Command '['git', 'show-ref', '--hash', > >> '--abbrev', '--', 'refs/remotes/upstream/master']' returned non-zero exit > >> status 1 > >> > >> I quickly f
Re: Upcoming wskdebug release 1.3
We may have one more step missing. Did you add your key to the KEYS file? https://github.com/apache/openwhisk-release/blob/master/docs/release_manager_setup.md#publish-your-public-key-to-the-project-keys-file I don't see your key here [1] and hence cannot verify the signature on the release tarball yet. -r [1] https://dist.apache.org/repos/dist/release/openwhisk/KEYS On Tue, Jul 28, 2020 at 3:59 PM Rodric Rabbah wrote: > Thanks Alex for noting these gaps! > > -r > > On Tue, Jul 28, 2020 at 3:20 PM Alexander Klimetschek > wrote: > >> FWIW, I reported all these as issues (and the gen-release-vote.py one was >> already reported): >> >> * https://github.com/apache/openwhisk-release/issues/342 >> * <https://github.com/apache/openwhisk-release/issues/341> >> https://github.com/apache/openwhisk-release/issues/341 >> * https://github.com/apache/openwhisk-release/issues/340 >> * https://github.com/apache/openwhisk-release/issues/317 >> >> Cheers, >> Alex >> >> >> From: Alexander Klimetschek >> Sent: Tuesday, July 28, 2020 11:47 >> To: dev@openwhisk.apache.org >> Subject: Re: Upcoming wskdebug release 1.3 >> >> Also: the ./gen-release-vote.py script assumes a certain naming >> convention for cloning the https://github.com/apache/openwhisk-release >> repo: >> >> * remote "upstream": for the actual repo >> * remote "origin" (or anything): for ones local fork >> >> In my case I had no fork and just "origin" for the actual repo, resulting >> in this error: >> >> subprocess.CalledProcessError: Command '['git', 'show-ref', '--hash', >> '--abbrev', '--', 'refs/remotes/upstream/master']' returned non-zero exit >> status 1 >> >> I quickly fixed it by changing the script at [1] to use "origin". >> >> Not sure what the best solution is, I guess everyone has a different >> approach with forks vs. not. But maybe make it configurable and print a >> hint if the git show-ref returns an error? >> >> [1] >> https://github.com/apache/openwhisk-release/blob/master/tools/gen-release-vote.py#L88 >> >> Cheers, >> Alex >> >> From: Alexander Klimetschek >> Sent: Monday, July 27, 2020 21:17 >> To: dev@openwhisk.apache.org >> Subject: Re: Upcoming wskdebug release 1.3 >> >> Few things I noticed so far while prepping the release based on [1]: >> >> 1. It mentions "Start a [DISCUSS] thread on the dev list proposing the >> release" but I rarely see this happening in practice. How strictly is it >> required if nobody else is working on the same codebase? >> 2. Not really clear what to do _before_ the release signing (if you >> missed those, you have to redo the whole procedure...) >> * npm: release version in package.json >> * CHANGELOG >> 3. No link to PGP key management instructions (e.g. to upload >> fingerprint on id.apache.org). I eventually found this to be helpful [2]. >> 4. No link to Apache Rat which it says to run manually. >> >> [1] >> https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md >> [2] >> https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys >> >> Cheers, >> Alex >> >> >> From: Rodric Rabbah >> Sent: Wednesday, July 22, 2020 08:27 >> To: dev@openwhisk.apache.org >> Subject: Re: Upcoming wskdebug release 1.3 >> >> I reviewed and merged your PR. Instructions link you found is the correct >> starting point. If you find something that isn’t clear please use the >> opportunity to improve the docs 🙏🏼 >> >> -r >> >> > On Jul 22, 2020, at 11:24 AM, Alexander Klimetschek >> wrote: >> > >> > Hi fellow committers, >> > >> > I want to start the wskdebug 1.3 release soon. Two asks/questions: >> > >> > 1. would love to get reviews for the last remaining PR [1] so that I >> can merge it >> > 2. will then try to start the release process myself. instructions at >> [2] are the ones to follow, right? >> > >> > [1] https://github.com/apache/openwhisk-wskdebug/pull/76 >> > [2] >> https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md >> > >> > Cheers, >> > Alex >> >
Re: Upcoming wskdebug release 1.3
Thanks Alex for noting these gaps! -r On Tue, Jul 28, 2020 at 3:20 PM Alexander Klimetschek wrote: > FWIW, I reported all these as issues (and the gen-release-vote.py one was > already reported): > > * https://github.com/apache/openwhisk-release/issues/342 > * <https://github.com/apache/openwhisk-release/issues/341> > https://github.com/apache/openwhisk-release/issues/341 > * https://github.com/apache/openwhisk-release/issues/340 > * https://github.com/apache/openwhisk-release/issues/317 > > Cheers, > Alex > > > From: Alexander Klimetschek > Sent: Tuesday, July 28, 2020 11:47 > To: dev@openwhisk.apache.org > Subject: Re: Upcoming wskdebug release 1.3 > > Also: the ./gen-release-vote.py script assumes a certain naming convention > for cloning the https://github.com/apache/openwhisk-release repo: > > * remote "upstream": for the actual repo > * remote "origin" (or anything): for ones local fork > > In my case I had no fork and just "origin" for the actual repo, resulting > in this error: > > subprocess.CalledProcessError: Command '['git', 'show-ref', '--hash', > '--abbrev', '--', 'refs/remotes/upstream/master']' returned non-zero exit > status 1 > > I quickly fixed it by changing the script at [1] to use "origin". > > Not sure what the best solution is, I guess everyone has a different > approach with forks vs. not. But maybe make it configurable and print a > hint if the git show-ref returns an error? > > [1] > https://github.com/apache/openwhisk-release/blob/master/tools/gen-release-vote.py#L88 > > Cheers, > Alex > > From: Alexander Klimetschek > Sent: Monday, July 27, 2020 21:17 > To: dev@openwhisk.apache.org > Subject: Re: Upcoming wskdebug release 1.3 > > Few things I noticed so far while prepping the release based on [1]: > > 1. It mentions "Start a [DISCUSS] thread on the dev list proposing the > release" but I rarely see this happening in practice. How strictly is it > required if nobody else is working on the same codebase? > 2. Not really clear what to do _before_ the release signing (if you > missed those, you have to redo the whole procedure...) > * npm: release version in package.json > * CHANGELOG > 3. No link to PGP key management instructions (e.g. to upload > fingerprint on id.apache.org). I eventually found this to be helpful [2]. > 4. No link to Apache Rat which it says to run manually. > > [1] > https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md > [2] > https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys > > Cheers, > Alex > > > From: Rodric Rabbah > Sent: Wednesday, July 22, 2020 08:27 > To: dev@openwhisk.apache.org > Subject: Re: Upcoming wskdebug release 1.3 > > I reviewed and merged your PR. Instructions link you found is the correct > starting point. If you find something that isn’t clear please use the > opportunity to improve the docs 🙏🏼 > > -r > > > On Jul 22, 2020, at 11:24 AM, Alexander Klimetschek > wrote: > > > > Hi fellow committers, > > > > I want to start the wskdebug 1.3 release soon. Two asks/questions: > > > > 1. would love to get reviews for the last remaining PR [1] so that I can > merge it > > 2. will then try to start the release process myself. instructions at > [2] are the ones to follow, right? > > > > [1] https://github.com/apache/openwhisk-wskdebug/pull/76 > > [2] > https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md > > > > Cheers, > > Alex >
Re: Upcoming wskdebug release 1.3
FWIW, I reported all these as issues (and the gen-release-vote.py one was already reported): * https://github.com/apache/openwhisk-release/issues/342 * <https://github.com/apache/openwhisk-release/issues/341> https://github.com/apache/openwhisk-release/issues/341 * https://github.com/apache/openwhisk-release/issues/340 * https://github.com/apache/openwhisk-release/issues/317 Cheers, Alex From: Alexander Klimetschek Sent: Tuesday, July 28, 2020 11:47 To: dev@openwhisk.apache.org Subject: Re: Upcoming wskdebug release 1.3 Also: the ./gen-release-vote.py script assumes a certain naming convention for cloning the https://github.com/apache/openwhisk-release repo: * remote "upstream": for the actual repo * remote "origin" (or anything): for ones local fork In my case I had no fork and just "origin" for the actual repo, resulting in this error: subprocess.CalledProcessError: Command '['git', 'show-ref', '--hash', '--abbrev', '--', 'refs/remotes/upstream/master']' returned non-zero exit status 1 I quickly fixed it by changing the script at [1] to use "origin". Not sure what the best solution is, I guess everyone has a different approach with forks vs. not. But maybe make it configurable and print a hint if the git show-ref returns an error? [1] https://github.com/apache/openwhisk-release/blob/master/tools/gen-release-vote.py#L88 Cheers, Alex ____ From: Alexander Klimetschek Sent: Monday, July 27, 2020 21:17 To: dev@openwhisk.apache.org Subject: Re: Upcoming wskdebug release 1.3 Few things I noticed so far while prepping the release based on [1]: 1. It mentions "Start a [DISCUSS] thread on the dev list proposing the release" but I rarely see this happening in practice. How strictly is it required if nobody else is working on the same codebase? 2. Not really clear what to do _before_ the release signing (if you missed those, you have to redo the whole procedure...) * npm: release version in package.json * CHANGELOG 3. No link to PGP key management instructions (e.g. to upload fingerprint on id.apache.org). I eventually found this to be helpful [2]. 4. No link to Apache Rat which it says to run manually. [1] https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md [2] https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys Cheers, Alex ____ From: Rodric Rabbah Sent: Wednesday, July 22, 2020 08:27 To: dev@openwhisk.apache.org Subject: Re: Upcoming wskdebug release 1.3 I reviewed and merged your PR. Instructions link you found is the correct starting point. If you find something that isn’t clear please use the opportunity to improve the docs 🙏🏼 -r > On Jul 22, 2020, at 11:24 AM, Alexander Klimetschek > wrote: > > Hi fellow committers, > > I want to start the wskdebug 1.3 release soon. Two asks/questions: > > 1. would love to get reviews for the last remaining PR [1] so that I can > merge it > 2. will then try to start the release process myself. instructions at [2] are > the ones to follow, right? > > [1] https://github.com/apache/openwhisk-wskdebug/pull/76 > [2] > https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md > > Cheers, > Alex
Re: Upcoming wskdebug release 1.3
Also: the ./gen-release-vote.py script assumes a certain naming convention for cloning the https://github.com/apache/openwhisk-release repo: * remote "upstream": for the actual repo * remote "origin" (or anything): for ones local fork In my case I had no fork and just "origin" for the actual repo, resulting in this error: subprocess.CalledProcessError: Command '['git', 'show-ref', '--hash', '--abbrev', '--', 'refs/remotes/upstream/master']' returned non-zero exit status 1 I quickly fixed it by changing the script at [1] to use "origin". Not sure what the best solution is, I guess everyone has a different approach with forks vs. not. But maybe make it configurable and print a hint if the git show-ref returns an error? [1] https://github.com/apache/openwhisk-release/blob/master/tools/gen-release-vote.py#L88 Cheers, Alex ____ From: Alexander Klimetschek Sent: Monday, July 27, 2020 21:17 To: dev@openwhisk.apache.org Subject: Re: Upcoming wskdebug release 1.3 Few things I noticed so far while prepping the release based on [1]: 1. It mentions "Start a [DISCUSS] thread on the dev list proposing the release" but I rarely see this happening in practice. How strictly is it required if nobody else is working on the same codebase? 2. Not really clear what to do _before_ the release signing (if you missed those, you have to redo the whole procedure...) * npm: release version in package.json * CHANGELOG 3. No link to PGP key management instructions (e.g. to upload fingerprint on id.apache.org). I eventually found this to be helpful [2]. 4. No link to Apache Rat which it says to run manually. [1] https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md [2] https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys Cheers, Alex ____ From: Rodric Rabbah Sent: Wednesday, July 22, 2020 08:27 To: dev@openwhisk.apache.org Subject: Re: Upcoming wskdebug release 1.3 I reviewed and merged your PR. Instructions link you found is the correct starting point. If you find something that isn’t clear please use the opportunity to improve the docs 🙏🏼 -r > On Jul 22, 2020, at 11:24 AM, Alexander Klimetschek > wrote: > > Hi fellow committers, > > I want to start the wskdebug 1.3 release soon. Two asks/questions: > > 1. would love to get reviews for the last remaining PR [1] so that I can > merge it > 2. will then try to start the release process myself. instructions at [2] are > the ones to follow, right? > > [1] https://github.com/apache/openwhisk-wskdebug/pull/76 > [2] > https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md > > Cheers, > Alex
Re: Upcoming wskdebug release 1.3
Few things I noticed so far while prepping the release based on [1]: 1. It mentions "Start a [DISCUSS] thread on the dev list proposing the release" but I rarely see this happening in practice. How strictly is it required if nobody else is working on the same codebase? 2. Not really clear what to do _before_ the release signing (if you missed those, you have to redo the whole procedure...) * npm: release version in package.json * CHANGELOG 3. No link to PGP key management instructions (e.g. to upload fingerprint on id.apache.org). I eventually found this to be helpful [2]. 4. No link to Apache Rat which it says to run manually. [1] https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md [2] https://infra.apache.org/new-committers-guide.html#set-up-security-and-pgp-keys Cheers, Alex From: Rodric Rabbah Sent: Wednesday, July 22, 2020 08:27 To: dev@openwhisk.apache.org Subject: Re: Upcoming wskdebug release 1.3 I reviewed and merged your PR. Instructions link you found is the correct starting point. If you find something that isn’t clear please use the opportunity to improve the docs 🙏🏼 -r > On Jul 22, 2020, at 11:24 AM, Alexander Klimetschek > wrote: > > Hi fellow committers, > > I want to start the wskdebug 1.3 release soon. Two asks/questions: > > 1. would love to get reviews for the last remaining PR [1] so that I can > merge it > 2. will then try to start the release process myself. instructions at [2] are > the ones to follow, right? > > [1] https://github.com/apache/openwhisk-wskdebug/pull/76 > [2] > https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md > > Cheers, > Alex
Re: Upcoming wskdebug release 1.3
Thanks a lot! We'll do some short beta testing here at Adobe before I'll kick off the release process maybe tomorrow or Friday. Cheers, Alex From: Rodric Rabbah Sent: Wednesday, July 22, 2020 08:27 To: dev@openwhisk.apache.org Subject: Re: Upcoming wskdebug release 1.3 I reviewed and merged your PR. Instructions link you found is the correct starting point. If you find something that isn’t clear please use the opportunity to improve the docs 🙏🏼 -r > On Jul 22, 2020, at 11:24 AM, Alexander Klimetschek > wrote: > > Hi fellow committers, > > I want to start the wskdebug 1.3 release soon. Two asks/questions: > > 1. would love to get reviews for the last remaining PR [1] so that I can > merge it > 2. will then try to start the release process myself. instructions at [2] are > the ones to follow, right? > > [1] https://github.com/apache/openwhisk-wskdebug/pull/76 > [2] > https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md > > Cheers, > Alex
Re: Upcoming wskdebug release 1.3
I reviewed and merged your PR. Instructions link you found is the correct starting point. If you find something that isn’t clear please use the opportunity to improve the docs 🙏🏼 -r > On Jul 22, 2020, at 11:24 AM, Alexander Klimetschek > wrote: > > Hi fellow committers, > > I want to start the wskdebug 1.3 release soon. Two asks/questions: > > 1. would love to get reviews for the last remaining PR [1] so that I can > merge it > 2. will then try to start the release process myself. instructions at [2] are > the ones to follow, right? > > [1] https://github.com/apache/openwhisk-wskdebug/pull/76 > [2] > https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md > > Cheers, > Alex
Upcoming wskdebug release 1.3
Hi fellow committers, I want to start the wskdebug 1.3 release soon. Two asks/questions: 1. would love to get reviews for the last remaining PR [1] so that I can merge it 2. will then try to start the release process myself. instructions at [2] are the ones to follow, right? [1] https://github.com/apache/openwhisk-wskdebug/pull/76 [2] https://github.com/apache/openwhisk-release/blob/master/docs/release_instructions.md Cheers, Alex
