[GitHub] orc issue #197: ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code

2017-12-04 Thread rip-nsk 
Github user rip-nsk commented on the issue:

https://github.com/apache/orc/pull/197
  
Change in HAS_POST_2038 shows the bug in osx/clang build:
/Users/travis/build/apache/orc/tools/test/TestMatch.cc:149: Failure
  Expected: expectedLine
  Which is: "{\"time\": \"2038-05-05 12:34:56.1\", \"date\": 
\"2038-12-25\"}"
To be equal to: line
  Which is: "{\"time\": \"2038-05-05 11:34:56.1\", \"date\": 
\"2038-12-25\"}"
wrong output at row 0


---

[GitHub] orc pull request #197: ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code

2017-12-04 Thread rip-nsk 
GitHub user rip-nsk opened a pull request:

https://github.com/apache/orc/pull/197

ORCORC-271: Improve HAS_PRE_1970/HAS_POST_2038 code



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rip-nsk/orc ORC-271

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #197


commit e5eef3c08174bb628d3eb02e86b192bb8cc64fc9
Author: rip.nsk 
Date:   2017-12-05T00:34:36Z

Improve HAS_PRE_1970 check and fix dependent tests

Signed-off-by: rip-nsk 

commit 7f63a0cc4a0366c0dce5bdaf38acc52659d02e5d
Author: rip.nsk 
Date:   2017-12-05T00:35:46Z

Simplify HAS_POST_2038 check.

Signed-off-by: rip-nsk 




---

[jira] [Created] (ORC-271) Improve HAS_PRE_1970/HAS_POST_2038 code

2017-12-04 Thread rip.nsk (JIRA) 
rip.nsk created ORC-271:
---

 Summary: Improve HAS_PRE_1970/HAS_POST_2038 code
 Key: ORC-271
 URL: https://issues.apache.org/jira/browse/ORC-271
 Project: ORC
  Issue Type: Improvement
  Components: C++
Reporter: rip.nsk
Assignee: rip.nsk
Priority: Minor


gmtime suddenly returns correct tm value for -1000 in win32/msvc (but gmtime_s 
not, as specified)
Also, several test can be executed with negative time_t even if HAS_PRE_1970 is 
not defined.
HAS_POST_2038 can be simplified, to avoid dependency on TZ.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] orc pull request #195: ORC-269: cmake fails when PROTOBUF_HOME set and libhd...

2017-12-04 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/195


---

[GitHub] orc issue #193: ORC-267: INSTALL NOTICES and LICENSE to binary tarball

2017-12-04 Thread omalley 
Github user omalley commented on the issue:

https://github.com/apache/orc/pull/193
  
Yeah, I agree. I'd rather leave things consistent and share/doc/orc makes 
sense.

Arguably we should also add the html for the site there too.


---

[GitHub] orc issue #193: ORC-267: INSTALL NOTICES and LICENSE to binary tarball

2017-12-04 Thread jcrist 
Github user jcrist commented on the issue:

https://github.com/apache/orc/pull/193
  
From http://www.apache.org/dev/apply-license.html#new it looks like they 
recommend storing `LICENSE` and `NOTICE` in the root of the tar archive of a 
distribution (as you've done here). Unfortunately cpack doesn't make it easy to 
distinguish between files in `make install` and `make package`.

Neither `parquet-cpp` nor `arrow` include `LICENSE` or `NOTICE` on `make 
install` or `make package` (`parquet-cpp` only, arrow doesn't use `cpack`). For 
at least the python wrappers for these libraries, the actual release artifacts 
are generated via an external tool that adds in the LICENSE stuff.

This separation of build/package makes sense to me, but may not for this 
project (not sure how y'all handle releases). Perhaps the LICENSE/NOTICE could 
be added to the `tar.gz` file after `make package` manually via another make 
target? Adding to `doc/orc/{NOTICE,LICENSE}` might be equally fine? I'm not 
really sure what's best here, either is fine with me.


---

[GitHub] orc issue #193: ORC-267: INSTALL NOTICES and LICENSE to binary tarball

2017-12-04 Thread omalley 
Github user omalley commented on the issue:

https://github.com/apache/orc/pull/193
  
Legally, the binary artifacts from the Apache projects are supposed to 
include them. For tarballs it is traditionally at the root of the project. 
Especially for RPM and DEB packaging, you wouldn't want them at the root. 

How about we move it to doc/orc/{NOTICE,LICENSE}?


---

[GitHub] orc pull request #193: ORC-267: INSTALL NOTICES and LICENSE to binary tarbal...

2017-12-04 Thread jcrist 
Github user jcrist commented on a diff in the pull request:

https://github.com/apache/orc/pull/193#discussion_r154717285
  
--- Diff: CMakeLists.txt ---
@@ -105,6 +105,11 @@ INCLUDE(ThirdpartyToolchain)
 set (EXAMPLE_DIRECTORY ${CMAKE_SOURCE_DIR}/examples)
 
 add_subdirectory(c++)
+
+install(
+  FILES LICENSE NOTICE
+  DESTINATION .)
--- End diff --

If I do `make install`, these just get placed in my root directory. Other 
apache projects (e.g. arrow, parquet-cpp) don't install the `LICENSE` or 
`NOTICE` (the header files all have the license information), so why is this 
needed? This is why I removed these in #192, sorry if there was a good reason 
for installing these.


---