[GitHub] orc pull request #222: ORC-310 better error handling for codec

[sershe]

GitHub user sershe opened a pull request:

https://github.com/apache/orc/pull/222

ORC-310 better error handling for codec



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sershe/orc orc-310

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/222.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #222


commit d9727cb36c9b1e9f1c045e29d928401a680062cb
Author: sergey 
Date:   2018-03-01T00:00:51Z

ORC-310
better error handling for codec




---

[jira] [Created] (ORC-310) better error handling for codec

[Sergey Shelukhin (JIRA)]

Sergey Shelukhin created ORC-310:


 Summary: better error handling for codec
 Key: ORC-310
 URL: https://issues.apache.org/jira/browse/ORC-310
 Project: ORC
  Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] orc pull request #213: ORC-278 - Create in memory KeyProvider class

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/213


---

[GitHub] orc issue #213: ORC-278 - Create in memory KeyProvider class

[moresandeep]

Github user moresandeep commented on the issue:

https://github.com/apache/orc/pull/213
  
Hello @omalley 
The changes look good, thanks !


---

[GitHub] orc issue #220: ORC-306 Correct pre-1970 timestamps that were off by one sec...

[omalley]

Github user omalley commented on the issue:

https://github.com/apache/orc/pull/220
  
Here is another way to look at the problem with each timestamp's getTime() 
and getNanos():

Timestamp 1969-12-25 12:34:56.0 as -530704000 and 0
Timestamp 1969-12-25 12:34:56.0001 as -530704000 and 10
Timestamp 1969-12-25 12:34:56.0011 as -530703999 and 110

When we use getTime()/1000 the change happens between .00099 and 
.00100. 

If you don't think that Java will change, we could hard code the change to 
use 999_999 all of the time and not do the test.




---