[GitHub] [orc] guiyanakuang commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


guiyanakuang commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919736530


   Sorry, orc-example does not directly depend on orc-shims. It's just a 
problem with my env, I will close this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] guiyanakuang closed pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


guiyanakuang closed pull request #908:
URL: https://github.com/apache/orc/pull/908


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919666186


   BTW, please participate the votes. We have three votes in the dev mailing 
list. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] guiyanakuang commented on a change in pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


guiyanakuang commented on a change in pull request #908:
URL: https://github.com/apache/orc/pull/908#discussion_r708805448



##
File path: java/examples/pom.xml
##
@@ -36,6 +36,10 @@
   org.apache.orc
   orc-core
 
+
+  org.apache.orc
+  orc-shims
+

Review comment:
   I don't know why, but the current build prompt is the opposite of my 
environment, and I need some time to make sure to analyze it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919665869


   No problem. I just want to reach out to you. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] dongjoon-hyun commented on a change in pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


dongjoon-hyun commented on a change in pull request #908:
URL: https://github.com/apache/orc/pull/908#discussion_r708804939



##
File path: java/examples/pom.xml
##
@@ -36,6 +36,10 @@
   org.apache.orc
   orc-core
 
+
+  org.apache.orc
+  orc-shims
+

Review comment:
   CI seems to fail by this addition.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] guiyanakuang commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


guiyanakuang commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919662933


   > BTW, I sent you an email 
([guiyanaku...@gmail.com](mailto:guiyanaku...@gmail.com)) via Gmail. Did you 
check it?
   
   Sorry I just saw the email. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] guiyanakuang commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


guiyanakuang commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919661965


   > Thank you. Is this `main` only issue?
   
   It should be a problem caused by the merge of ORC-910, so I think only main 
is affected at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: [VOTE] Release Apache ORC 1.7.0 (RC0)

2021-09-14 Thread Dongjoon Hyun
+1

1. Shasum and gpg sig checked.
2. Built and ran the C++/Java tests (including tools/example/bench) from
the source

Test project /Users/dongjoon/RC/orc-1.7.0/build
Start 1: orc-test
1/7 Test #1: orc-test .   Passed4.28 sec
Start 2: java-test
2/7 Test #2: java-test    Passed  149.59 sec
Start 3: java-examples-test
3/7 Test #3: java-examples-test ...   Passed0.57 sec
Start 4: java-tools-test
4/7 Test #4: java-tools-test ..   Passed0.24 sec
Start 5: java-bench-gen-test
5/7 Test #5: java-bench-gen-test ..   Passed1.67 sec
Start 6: java-bench-scan-test
6/7 Test #6: java-bench-scan-test .   Passed1.26 sec
Start 7: tool-test
7/7 Test #7: tool-test    Passed   12.81 sec

100% tests passed, 0 tests failed out of 7

3. Docker tests passed. (on the branch-1.7)
4. Apache Spark integration test passed
   (RC0 staging + Spark 3.3.0-SNAPSHOT)
   https://github.com/dongjoon-hyun/spark/pull/70

Dongjoon


On Tue, Sep 14, 2021 at 6:49 PM William Hyun  wrote:

> +1
>
> - Checked gpg sign and checksum
> - Built and tested java from the source on mac env with Java8.
>
> On 2021/09/14 23:42:49, "Owen O'Malley"  wrote:
> > +1 (binding)
> >
> > * Checked sig and checksum
> > * Ran docker builds
> > * Built with -Pbenchmark & -Panalyze and -Papache-release
> >
> > On Mon, Sep 13, 2021 at 1:09 AM Dongjoon Hyun 
> > wrote:
> >
> > > Please vote on releasing the following candidate as Apache ORC version
> > > 1.7.0.
> > >
> > > [ ] +1 Release this package as Apache ORC 1.7.0
> > > [ ] -1 Do not release this package because ...
> > >
> > > TAG:
> > > https://github.com/apache/orc/releases/tag/release-1.7.0rc0
> > >
> > > RELEASE FILES:
> > > https://dist.apache.org/repos/dist/dev/orc/orc-1.7.0-rc0
> > >
> > > STAGING REPOSITORY:
> > > https://repository.apache.org/content/repositories/orgapacheorc-1047/
> > >
> > > LIST OF JIRA ISSUES:
> > > https://issues.apache.org/jira/projects/ORC/versions/12346293
> > >
> > > This vote will be open for 72 hours.
> > >
> > > Thanks,
> > > Dongjoon.
> > >
> >
>


[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919658994


   BTW, I sent you an email (guiyanaku...@gmail.com) via Gmail. Did you check 
it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] dongjoon-hyun commented on pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


dongjoon-hyun commented on pull request #908:
URL: https://github.com/apache/orc/pull/908#issuecomment-919658669


   Thank you. Is this `main` only issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] guiyanakuang opened a new pull request #908: ORC-995: Failed to build Java library. Declare dependence orc-shims

2021-09-14 Thread GitBox


guiyanakuang opened a new pull request #908:
URL: https://github.com/apache/orc/pull/908


   
   
   ### What changes were proposed in this pull request?
   
   Declare dependence orc-shims.
   
   ### Why are the changes needed?
   
   Fix Build.
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (ORC-995) Failed to build Java library

2021-09-14 Thread Yiqun Zhang (Jira)
Yiqun Zhang created ORC-995:
---

 Summary: Failed to build Java library
 Key: ORC-995
 URL: https://issues.apache.org/jira/browse/ORC-995
 Project: ORC
  Issue Type: Bug
  Components: build, Java
Affects Versions: 1.8.0
Reporter: Yiqun Zhang


Failed to build Java library
{code:java}
[INFO] --- maven-dependency-plugin:3.1.2:analyze-only (default) @ orc-examples 
---
[WARNING] Used undeclared dependencies found:
[WARNING]org.apache.orc:orc-shims:jar:1.8.0-SNAPSHOT:compile
[INFO] 
[INFO] Reactor Summary for Apache ORC 1.8.0-SNAPSHOT:
[INFO] 
[INFO] Apache ORC . SUCCESS [  1.592 s]
[INFO] ORC Shims .. SUCCESS [  1.590 s]
[INFO] ORC Core ... SUCCESS [01:49 min]
[INFO] ORC MapReduce .. SUCCESS [ 35.893 s]
[INFO] ORC Tools .. SUCCESS [ 12.179 s]
[INFO] ORC Examples ... FAILURE [  2.986 s]
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  02:44 min
[INFO] Finished at: 2021-09-15T10:43:44+08:00
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-dependency-plugin:3.1.2:analyze-only (default) 
on project orc-examples: Dependency problems found -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :orc-examples
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Apache ORC 1.5.13 (RC0)

2021-09-14 Thread William Hyun
+1 

- Checked gpg sign and checksum
- Built and tested java from the source on mac env with Java8.

William

On 2021/09/14 23:29:32, "Owen O'Malley"  wrote: 
> +1 (binding)
> 
> * Checked sig & checksum
> * Ran the docker builds
> * Compiled with -Panalyze & -Pbenchmark and -Papache-release
> 
> One annoyance is that TestByteRle.cc has a double semicolon that clang
> complains about and thus fails the ubuntu 20 with clang build.
> 
> diff --git a/c++/test/TestByteRle.cc b/c++/test/TestByteRle.cc
> index 2c4d4e3d..cdb9cf2e 100644
> --- a/c++/test/TestByteRle.cc
> +++ b/c++/test/TestByteRle.cc
> @@ -1104,7 +1104,7 @@ TEST(BooleanRle, skipTestWithNulls) {
>rle->skip(4);
>  }
>  rle->skip(0);
> -data.assign(data.size(), -1);;
> +data.assign(data.size(), -1);
>  rle->next(data.data(), data.size(), allNull.data());
>  for (size_t j = 0; j < data.size(); ++j) {
>EXPECT_EQ(0, data[j]) << "Output wrong at " << i << ", " << j;
> 
> 
> On Tue, Sep 14, 2021 at 5:08 AM Dongjoon Hyun  wrote:
> 
> > +1
> >
> > 1. Shasum and gpg sig checked.
> > 2. Built and ran the C++/Java unit tests.
> > 3. Tested Java tools uber jar manually.
> > 4. Tested Java example uber jar manually.
> > 5. Apache Spark integration test passed
> >(RC0 staging + Spark 3.1.3-SNAPSHOT)
> >https://github.com/apache/spark/pull/33972
> >
> > Dongjoon
> >
> > On 2021/09/13 03:53:54, Dongjoon Hyun  wrote:
> > > Please vote on releasing the following candidate as Apache ORC version
> > > 1.5.13.
> > >
> > > [ ] +1 Release this package as Apache ORC 1.5.13
> > > [ ] -1 Do not release this package because ...
> > >
> > > TAG:
> > > https://github.com/apache/orc/releases/tag/release-1.5.13rc0
> > >
> > > RELEASE FILES:
> > > https://dist.apache.org/repos/dist/dev/orc/orc-1.5.13-rc0
> > >
> > > STAGING REPOSITORY:
> > > https://repository.apache.org/content/repositories/orgapacheorc-1050
> > >
> > > LIST OF JIRA ISSUES:
> > > https://issues.apache.org/jira/projects/ORC/versions/12349322
> > >
> > > This vote will be open for 72 hours.
> > >
> > > Thanks,
> > > Dongjoon.
> > >
> >
> 


Re: [VOTE] Release Apache ORC 1.6.11 (RC0)

2021-09-14 Thread William Hyun
+1 

- Checked gpg sign and checksum
- Built and tested java from the source on mac env with Java8.

William

On 2021/09/14 23:23:48, "Owen O'Malley"  wrote: 
> +1 (binding)
> 
> * Ran the docker builds
> * Checked the sig/checksum
> * Built with -Panalyze and -Papache-release
> 
> On Tue, Sep 14, 2021 at 10:47 PM Pavan Lanka 
> wrote:
> 
> > +1 (non-binding)
> >
> > Performed the following:
> > * C++ build and test
> > * Java build and test using OpenJDK 8
> >
> > Regards,
> > Pavan
> >
> > > On Sep 12, 2021, at 8:04 PM, Dongjoon Hyun 
> > wrote:
> > >
> > > Please vote on releasing the following candidate as Apache ORC version
> > > 1.6.11.
> > >
> > > [ ] +1 Release this package as Apache ORC 1.6.11
> > > [ ] -1 Do not release this package because ...
> > >
> > > TAG:
> > > https://github.com/apache/orc/releases/tag/release-1.6.11rc0
> > >
> > > RELEASE FILES:
> > > https://dist.apache.org/repos/dist/dev/orc/orc-1.6.11-rc0
> > >
> > > STAGING REPOSITORY:
> > > https://repository.apache.org/content/repositories/orgapacheorc-1049
> > >
> > > LIST OF JIRA ISSUES:
> > > https://issues.apache.org/jira/projects/ORC/versions/12350499
> > >
> > > This vote will be open for 72 hours.
> > >
> > > Thanks,
> > > Dongjoon.
> >
> >
> 


Re: [VOTE] Release Apache ORC 1.7.0 (RC0)

2021-09-14 Thread William Hyun
+1 

- Checked gpg sign and checksum
- Built and tested java from the source on mac env with Java8.

On 2021/09/14 23:42:49, "Owen O'Malley"  wrote: 
> +1 (binding)
> 
> * Checked sig and checksum
> * Ran docker builds
> * Built with -Pbenchmark & -Panalyze and -Papache-release
> 
> On Mon, Sep 13, 2021 at 1:09 AM Dongjoon Hyun 
> wrote:
> 
> > Please vote on releasing the following candidate as Apache ORC version
> > 1.7.0.
> >
> > [ ] +1 Release this package as Apache ORC 1.7.0
> > [ ] -1 Do not release this package because ...
> >
> > TAG:
> > https://github.com/apache/orc/releases/tag/release-1.7.0rc0
> >
> > RELEASE FILES:
> > https://dist.apache.org/repos/dist/dev/orc/orc-1.7.0-rc0
> >
> > STAGING REPOSITORY:
> > https://repository.apache.org/content/repositories/orgapacheorc-1047/
> >
> > LIST OF JIRA ISSUES:
> > https://issues.apache.org/jira/projects/ORC/versions/12346293
> >
> > This vote will be open for 72 hours.
> >
> > Thanks,
> > Dongjoon.
> >
> 


Re: [VOTE] Release Apache ORC 1.7.0 (RC0)

2021-09-14 Thread Owen O'Malley
+1 (binding)

* Checked sig and checksum
* Ran docker builds
* Built with -Pbenchmark & -Panalyze and -Papache-release

On Mon, Sep 13, 2021 at 1:09 AM Dongjoon Hyun 
wrote:

> Please vote on releasing the following candidate as Apache ORC version
> 1.7.0.
>
> [ ] +1 Release this package as Apache ORC 1.7.0
> [ ] -1 Do not release this package because ...
>
> TAG:
> https://github.com/apache/orc/releases/tag/release-1.7.0rc0
>
> RELEASE FILES:
> https://dist.apache.org/repos/dist/dev/orc/orc-1.7.0-rc0
>
> STAGING REPOSITORY:
> https://repository.apache.org/content/repositories/orgapacheorc-1047/
>
> LIST OF JIRA ISSUES:
> https://issues.apache.org/jira/projects/ORC/versions/12346293
>
> This vote will be open for 72 hours.
>
> Thanks,
> Dongjoon.
>


Re: [VOTE] Release Apache ORC 1.5.13 (RC0)

2021-09-14 Thread Owen O'Malley
+1 (binding)

* Checked sig & checksum
* Ran the docker builds
* Compiled with -Panalyze & -Pbenchmark and -Papache-release

One annoyance is that TestByteRle.cc has a double semicolon that clang
complains about and thus fails the ubuntu 20 with clang build.

diff --git a/c++/test/TestByteRle.cc b/c++/test/TestByteRle.cc
index 2c4d4e3d..cdb9cf2e 100644
--- a/c++/test/TestByteRle.cc
+++ b/c++/test/TestByteRle.cc
@@ -1104,7 +1104,7 @@ TEST(BooleanRle, skipTestWithNulls) {
   rle->skip(4);
 }
 rle->skip(0);
-data.assign(data.size(), -1);;
+data.assign(data.size(), -1);
 rle->next(data.data(), data.size(), allNull.data());
 for (size_t j = 0; j < data.size(); ++j) {
   EXPECT_EQ(0, data[j]) << "Output wrong at " << i << ", " << j;


On Tue, Sep 14, 2021 at 5:08 AM Dongjoon Hyun  wrote:

> +1
>
> 1. Shasum and gpg sig checked.
> 2. Built and ran the C++/Java unit tests.
> 3. Tested Java tools uber jar manually.
> 4. Tested Java example uber jar manually.
> 5. Apache Spark integration test passed
>(RC0 staging + Spark 3.1.3-SNAPSHOT)
>https://github.com/apache/spark/pull/33972
>
> Dongjoon
>
> On 2021/09/13 03:53:54, Dongjoon Hyun  wrote:
> > Please vote on releasing the following candidate as Apache ORC version
> > 1.5.13.
> >
> > [ ] +1 Release this package as Apache ORC 1.5.13
> > [ ] -1 Do not release this package because ...
> >
> > TAG:
> > https://github.com/apache/orc/releases/tag/release-1.5.13rc0
> >
> > RELEASE FILES:
> > https://dist.apache.org/repos/dist/dev/orc/orc-1.5.13-rc0
> >
> > STAGING REPOSITORY:
> > https://repository.apache.org/content/repositories/orgapacheorc-1050
> >
> > LIST OF JIRA ISSUES:
> > https://issues.apache.org/jira/projects/ORC/versions/12349322
> >
> > This vote will be open for 72 hours.
> >
> > Thanks,
> > Dongjoon.
> >
>


Re: [VOTE] Release Apache ORC 1.6.11 (RC0)

2021-09-14 Thread Owen O'Malley
+1 (binding)

* Ran the docker builds
* Checked the sig/checksum
* Built with -Panalyze and -Papache-release

On Tue, Sep 14, 2021 at 10:47 PM Pavan Lanka 
wrote:

> +1 (non-binding)
>
> Performed the following:
> * C++ build and test
> * Java build and test using OpenJDK 8
>
> Regards,
> Pavan
>
> > On Sep 12, 2021, at 8:04 PM, Dongjoon Hyun 
> wrote:
> >
> > Please vote on releasing the following candidate as Apache ORC version
> > 1.6.11.
> >
> > [ ] +1 Release this package as Apache ORC 1.6.11
> > [ ] -1 Do not release this package because ...
> >
> > TAG:
> > https://github.com/apache/orc/releases/tag/release-1.6.11rc0
> >
> > RELEASE FILES:
> > https://dist.apache.org/repos/dist/dev/orc/orc-1.6.11-rc0
> >
> > STAGING REPOSITORY:
> > https://repository.apache.org/content/repositories/orgapacheorc-1049
> >
> > LIST OF JIRA ISSUES:
> > https://issues.apache.org/jira/projects/ORC/versions/12350499
> >
> > This vote will be open for 72 hours.
> >
> > Thanks,
> > Dongjoon.
>
>


[jira] [Created] (ORC-994) Fix javadoc so that it doesn't put files into the source tree

2021-09-14 Thread Owen O'Malley (Jira)
Owen O'Malley created ORC-994:
-

 Summary: Fix javadoc so that it doesn't put files into the source 
tree
 Key: ORC-994
 URL: https://issues.apache.org/jira/browse/ORC-994
 Project: ORC
  Issue Type: Improvement
Reporter: Owen O'Malley


Currently the javadoc configuration puts directories (orc-*) into the source 
directories, which then messes up the RAT checks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Apache ORC 1.6.11 (RC0)

2021-09-14 Thread Pavan Lanka
+1 (non-binding)

Performed the following:
* C++ build and test
* Java build and test using OpenJDK 8

Regards,
Pavan

> On Sep 12, 2021, at 8:04 PM, Dongjoon Hyun  wrote:
> 
> Please vote on releasing the following candidate as Apache ORC version
> 1.6.11.
> 
> [ ] +1 Release this package as Apache ORC 1.6.11
> [ ] -1 Do not release this package because ...
> 
> TAG:
> https://github.com/apache/orc/releases/tag/release-1.6.11rc0
> 
> RELEASE FILES:
> https://dist.apache.org/repos/dist/dev/orc/orc-1.6.11-rc0
> 
> STAGING REPOSITORY:
> https://repository.apache.org/content/repositories/orgapacheorc-1049
> 
> LIST OF JIRA ISSUES:
> https://issues.apache.org/jira/projects/ORC/versions/12350499
> 
> This vote will be open for 72 hours.
> 
> Thanks,
> Dongjoon.