[GitHub] orc pull request #295: ORC-389: Add ability to not decode Acid metadata colu...

2018-07-25 Thread ekoifman
GitHub user ekoifman opened a pull request:

https://github.com/apache/orc/pull/295

ORC-389: Add ability to not decode Acid metadata columns



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekoifman/orc ORC-389-branch-1.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #295


commit 95845239197bc3aff460eeaf53c5644f94aa10b7
Author: Eugene Koifman 
Date:   2018-07-26T00:44:03Z

ORC-389: Add ability to not decode Acid metadata columns




---


[GitHub] orc pull request #294: ORC-389: Add ability to not decode Acid metadata colu...

2018-07-25 Thread ekoifman
GitHub user ekoifman reopened a pull request:

https://github.com/apache/orc/pull/294

ORC-389: Add ability to not decode Acid metadata columns



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekoifman/orc ORC-389

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #294


commit 634404d9de38923507d0812cb3310022c03169e5
Author: Eugene Koifman 
Date:   2018-07-25T21:22:23Z

ORC-389: Add ability to not decode Acid metadata columns




---


[GitHub] orc pull request #294: ORC-389: Add ability to not decode Acid metadata colu...

2018-07-25 Thread ekoifman
Github user ekoifman closed the pull request at:

https://github.com/apache/orc/pull/294


---


[GitHub] orc pull request #294: ORC-389: Add ability to not decode Acid metadata colu...

2018-07-25 Thread ekoifman
GitHub user ekoifman opened a pull request:

https://github.com/apache/orc/pull/294

ORC-389: Add ability to not decode Acid metadata columns



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekoifman/orc ORC-389

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #294


commit 634404d9de38923507d0812cb3310022c03169e5
Author: Eugene Koifman 
Date:   2018-07-25T21:22:23Z

ORC-389: Add ability to not decode Acid metadata columns




---


[GitHub] orc pull request #157: ORC-223 FileDump utility should print user metadata

2017-08-14 Thread ekoifman
GitHub user ekoifman opened a pull request:

https://github.com/apache/orc/pull/157

ORC-223 FileDump utility should print user metadata

@sershe could you review please

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekoifman/orc ORC-223

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #157


commit 4525fdf49eda4bc13d29f12adae546b8eef370c2
Author: Eugene Koifman 
Date:   2017-08-14T22:51:25Z

ORC-223 FileDump utility should print user metadata




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] orc pull request #156: ORC-195 - FileFormatException should include file nam...

2017-08-14 Thread ekoifman
GitHub user ekoifman opened a pull request:

https://github.com/apache/orc/pull/156

ORC-195 - FileFormatException should include file name in the message

@omalley  could you review please

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekoifman/orc ORC-195

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #156


commit a04c78ddaf25935e362bd827c780af98b931696b
Author: Eugene Koifman 
Date:   2017-08-14T19:49:37Z

ORC-195 - FileFormatException should include file name in the message




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] orc issue #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configura...

2017-08-14 Thread ekoifman
Github user ekoifman commented on the issue:

https://github.com/apache/orc/pull/154
  
added validation, fixed comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

2017-08-11 Thread ekoifman
Github user ekoifman commented on a diff in the pull request:

https://github.com/apache/orc/pull/154#discussion_r132804794
  
--- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java ---
@@ -81,6 +81,7 @@ public Thread getOwner() {
*/
   public MemoryManagerImpl(Configuration conf) {
 double maxLoad = OrcConf.MEMORY_POOL.getDouble(conf);
+ROWS_BETWEEN_CHECKS = OrcConf.ROWS_BETWEEN_CHECKS.getLong(conf);
--- End diff --

default is set OrcConf - 5000
what would be reasonable range of valid values?  [1,?]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] orc issue #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configura...

2017-08-11 Thread ekoifman
Github user ekoifman commented on the issue:

https://github.com/apache/orc/pull/154
  
@prasanthj  could you review please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

2017-08-11 Thread ekoifman
GitHub user ekoifman opened a pull request:

https://github.com/apache/orc/pull/154

ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekoifman/orc ORC-228

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #154


commit ac56bacb0f58c5703cb7fb55ef8b70b7a08cd8a3
Author: Eugene Koifman 
Date:   2017-08-11T23:58:10Z

ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---