[GitHub] [orc] yuokada commented on pull request #655: ORC-694: Update docker files for adding Java11 support

2021-03-17 Thread GitBox


yuokada commented on pull request #655:
URL: https://github.com/apache/orc/pull/655#issuecomment-801516449


   @dongjoon-hyun 
   Just questions.
   For debian 10, the OS image already use jdk10. Should we support jdk8 on it?
   
   For debian 9 and ubuntu16, the openjdk-11 deb package isn't provided for 
both OSes.
   Do we need to support JDK 11 in both?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] yuokada commented on pull request #655: ORC-694: Update docker files for adding Java11 support

2021-03-15 Thread GitBox


yuokada commented on pull request #655:
URL: https://github.com/apache/orc/pull/655#issuecomment-799854873


   Created: https://github.com/apache/orc/pull/656



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [orc] yuokada commented on pull request #655: ORC-694: Update docker files for adding Java11 support

2021-03-15 Thread GitBox


yuokada commented on pull request #655:
URL: https://github.com/apache/orc/pull/655#issuecomment-799837292


   @dongjoon-hyun 
   `MAINTAINER` command is deprecated since docker 1.13 or later. So I replaced 
it with the `LABEL` command.
   https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
   
   But, we don't need to change it in this PR.
   
   Should we create another ticket to replace `MAINTAINER` command?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org