[GitHub] orc issue #41: ORC-58: Move code for reading rows from Reader to RowReader

2016-07-19 Thread omalley
Github user omalley commented on the issue:

https://github.com/apache/orc/pull/41
  
The ReaderOptions needs to split in half too:

* ReaderOptions
  * setTailLocation
  * setErrorStream
  * setSerializedFooter

* RowReaderOptions
  * include
  * range
  * throwOnHive11DecimalOverflow
  * forcedScaleOnHive11Decimal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] orc issue #41: ORC-58: Move code for reading rows from Reader to RowReader

2016-07-15 Thread swalkaus
Github user swalkaus commented on the issue:

https://github.com/apache/orc/pull/41
  
I might rename "Reader" something like "FileTailReader" but, in general, 
the refactoring makes sense. The schema can be read and columns metadata known 
before column selection is decided.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] orc issue #41: ORC-58: Move code for reading rows from Reader to RowReader

2016-06-20 Thread majetideepak
Github user majetideepak commented on the issue:

https://github.com/apache/orc/pull/41
  
@omalley, please let me know your feedback. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---