[GitHub] orc pull request #74: ORC-123: Fix memory leaks in ToolTest.cc

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #74: ORC-123: Fix memory leaks in ToolTest.cc

[majetideepak]

Github user majetideepak commented on a diff in the pull request:

https://github.com/apache/orc/pull/74#discussion_r92895084
  
--- Diff: tools/test/ToolTest.cc ---
@@ -82,8 +83,10 @@ int runProgram(const std::vector& command,
std::string ) {
 
   // create temporary filenames for stdout and stderr
-  char *stdoutName = strdup("/tmp/orc-test-stdout-");
-  char *stderrName = strdup("/tmp/orc-test-stderr-");
--- End diff --

`std::string` should work too. I am updating the patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] orc pull request #74: ORC-123: Fix memory leaks in ToolTest.cc

[omalley]

Github user omalley commented on a diff in the pull request:

https://github.com/apache/orc/pull/74#discussion_r92892464
  
--- Diff: tools/test/ToolTest.cc ---
@@ -82,8 +83,10 @@ int runProgram(const std::vector& command,
std::string ) {
 
   // create temporary filenames for stdout and stderr
-  char *stdoutName = strdup("/tmp/orc-test-stdout-");
-  char *stderrName = strdup("/tmp/orc-test-stderr-");
--- End diff --

Would it be easier to use std::array or std::vector?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---