[jira] [Commented] (PARQUET-2041) Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc
[
https://issues.apache.org/jira/browse/PARQUET-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17336993#comment-17336993
]
ASF GitHub Bot commented on PARQUET-2041:
-
williamhyun opened a new pull request #899:
URL: https://github.com/apache/parquet-mr/pull/899
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2041
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc
>
>
> Key: PARQUET-2041
> URL: https://issues.apache.org/jira/browse/PARQUET-2041
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
>Affects Versions: 1.13.0
>Reporter: William Hyun
>Priority: Major
>
> The current Javadoc doesn't mention zstd.
> -
> https://javadoc.io/doc/org.apache.parquet/parquet-hadoop/latest/org/apache/parquet/hadoop/ParquetOutputFormat.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [parquet-mr] williamhyun opened a new pull request #899: PARQUET-2041: Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc
williamhyun opened a new pull request #899:
URL: https://github.com/apache/parquet-mr/pull/899
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2041
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In
addition, my commits follow the guidelines from "[How to write a good git
commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain Javadoc that
explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (PARQUET-2041) Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc
William Hyun created PARQUET-2041: - Summary: Add zstd to `parquet.compression` description of ParquetOutputFormat Javadoc Key: PARQUET-2041 URL: https://issues.apache.org/jira/browse/PARQUET-2041 Project: Parquet Issue Type: Improvement Components: parquet-mr Affects Versions: 1.13.0 Reporter: William Hyun The current Javadoc doesn't mention zstd. - https://javadoc.io/doc/org.apache.parquet/parquet-hadoop/latest/org/apache/parquet/hadoop/ParquetOutputFormat.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PARQUET-2035) Java module import error due to shaded package shaded.parquet.it.unimi.dsi.fastutil
[
https://issues.apache.org/jira/browse/PARQUET-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335709#comment-17335709
]
Maxim Kolesnikov commented on PARQUET-2035:
---
Thanks [~iemejia], that's exactly what I was doing. I have a half baked patch
now, going to finalize it till the end of this week.
> Java module import error due to shaded package
> shaded.parquet.it.unimi.dsi.fastutil
> ---
>
> Key: PARQUET-2035
> URL: https://issues.apache.org/jira/browse/PARQUET-2035
> Project: Parquet
> Issue Type: Bug
> Components: parquet-avro
>Affects Versions: 1.12.0, 1.11.1
>Reporter: Maxim Kolesnikov
>Priority: Major
> Attachments: parquet-example.zip
>
>
> *Description:*
> Due to collision of shaded packages
> {code:java}
> shaded.parquet.it.unimi.dsi.fastutil{code}
> in
> {code:java}
> org.apache.parquet:parquet-avro{code}
> and
> {code:java}
> org.apache.parquet:parquet-column{code}
> it is not possible to use both these dependencies within a modularized java
> project at the same time.
>
>
> *How to reproduce:*
> * create a maven project with dependency
> org.apache.parquet:parquet-avro:1.11.1
> * declare java module that requires both parquet.avro and parquet.column
> * run
> {code:java}
> mvn compile{code}
>
> *Expected behaviour:*
> Project should compile without errors.
>
> *Actual behaviour:*
> Project fails with compilation errors:
>
> {code:java}
> [ERROR] the unnamed module reads package shaded.parquet.it.unimi.dsi.fastutil
> from both parquet.column and parquet.avro
> ...{code}
>
>
> *Reproducible example* (same code as in the attached zip file):
> https://github.com/xCASx/parquet-example
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PARQUET-2035) Java module import error due to shaded package shaded.parquet.it.unimi.dsi.fastutil
[
https://issues.apache.org/jira/browse/PARQUET-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335566#comment-17335566
]
Ismaël Mejía commented on PARQUET-2035:
---
Just for ref we had a similar issue reported on Beam and what we did was to
create a 'test' module based on Java 11 that fails in case of split packages,
for ref BEAM-8024 and
https://github.com/apache/beam/tree/master/sdks/java/testing/jpms-tests
> Java module import error due to shaded package
> shaded.parquet.it.unimi.dsi.fastutil
> ---
>
> Key: PARQUET-2035
> URL: https://issues.apache.org/jira/browse/PARQUET-2035
> Project: Parquet
> Issue Type: Bug
> Components: parquet-avro
>Affects Versions: 1.12.0, 1.11.1
>Reporter: Maxim Kolesnikov
>Priority: Major
> Attachments: parquet-example.zip
>
>
> *Description:*
> Due to collision of shaded packages
> {code:java}
> shaded.parquet.it.unimi.dsi.fastutil{code}
> in
> {code:java}
> org.apache.parquet:parquet-avro{code}
> and
> {code:java}
> org.apache.parquet:parquet-column{code}
> it is not possible to use both these dependencies within a modularized java
> project at the same time.
>
>
> *How to reproduce:*
> * create a maven project with dependency
> org.apache.parquet:parquet-avro:1.11.1
> * declare java module that requires both parquet.avro and parquet.column
> * run
> {code:java}
> mvn compile{code}
>
> *Expected behaviour:*
> Project should compile without errors.
>
> *Actual behaviour:*
> Project fails with compilation errors:
>
> {code:java}
> [ERROR] the unnamed module reads package shaded.parquet.it.unimi.dsi.fastutil
> from both parquet.column and parquet.avro
> ...{code}
>
>
> *Reproducible example* (same code as in the attached zip file):
> https://github.com/xCASx/parquet-example
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PARQUET-2039) AvroReadSupport.setRequestedProjection in 1.11.1+ not backwards compatible with MAPS
[
https://issues.apache.org/jira/browse/PARQUET-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335535#comment-17335535
]
Bil Bingham commented on PARQUET-2039:
--
Sorry for the confusion.
The writer is using parquet 1.10.0 (bundled with hive-exec)
The bug I found was using 1.11.0 and 1.11.1 as described above . (The reader at
1.10.0 , 1,11,0 works, at 1.11.1 it breaks)
In the test case I included I simply used the parquet schema of the file
converted with the AvroSchemeConverter.
{code:java}
{"type":"record","name":"hive_schema","fields":[{"name":"a","type":["null","string"],"default":null},{"name":"b","type":["null",{"type":"map","values":["null","string"]}],"default":null}]}{code}
> AvroReadSupport.setRequestedProjection in 1.11.1+ not backwards compatible
> with MAPS
>
>
> Key: PARQUET-2039
> URL: https://issues.apache.org/jira/browse/PARQUET-2039
> Project: Parquet
> Issue Type: Bug
> Components: parquet-avro, parquet-mr
>Affects Versions: 1.11.0, 1.11.1
>Reporter: Bil Bingham
>Priority: Minor
> Attachments: PQMapTest.java
>
>
>
> using AvroReadSupport.setRequestedProjection in 1.11.1 reading a 1.10.0
> generated parquet file sets MAP fields to null (and vice versa
> 1.10.0 reader against a 1.11.1 generated file)
> - Not using a projected schema works, the map fields are converted correctly.
> In my case. Parquet file is generated by hive
> {code:java}
> CREATE TABLE parquetmaptest (
> a string,
> b MAP
> )
> STORED AS PARQUET
> tblproperties(
> "parquet.compression"="SNAPPY"
> );
> insert into parquetmaptest select "a",map("k1","v1","k2","v2");{code}
> Using parquet-avro 1.11.1 (and appropriate dependencies) result in field "b"
> being null.
> {code:java}
> data:null
> row:{"a": "a", "b": null}{code}
> Using parquet-avro 1.11.0 (and appropriate dependencies) result in field "b"
> being the right map value.
> {code:java}
> data:{k1=v1, k2=v2}
> row:{"a": "a", "b": {"k1": "v1", "k2": "v2"}}{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (PARQUET-2040) Uniform encryption
Gidon Gershinsky created PARQUET-2040: - Summary: Uniform encryption Key: PARQUET-2040 URL: https://issues.apache.org/jira/browse/PARQUET-2040 Project: Parquet Issue Type: Improvement Components: parquet-mr Affects Versions: 1.12.0 Reporter: Gidon Gershinsky Assignee: Gidon Gershinsky PME low-level spec supports using the same encryption key for all columns, which is useful in a number of scenarios. However, this feature is not exposed yet in the high-level API, because its misuse can break the NIST limit on the number of AES GCM operations with one key. We will develop a limit-enforcing code and provide an API for uniform table encryption. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PARQUET-2039) AvroReadSupport.setRequestedProjection in 1.11.1+ not backwards compatible with MAPS
[
https://issues.apache.org/jira/browse/PARQUET-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335226#comment-17335226
]
Gabor Szadovszky commented on PARQUET-2039:
---
I am a bit confused about the version numbers. Are you comparing 1.11.1 and
1.10.0 or 1.11.1 and 1.11.0? Anyway, PARQUET-1879 seems to be related. It is
around the same area and got in to 1.11.1.
You are invoking {{setRequestedProjection}}. Could you please list the exact
avro schema you are using for the projection?
[~maccamlc], since your modification potentially caused this regression(?) you
may want to check this out.
> AvroReadSupport.setRequestedProjection in 1.11.1+ not backwards compatible
> with MAPS
>
>
> Key: PARQUET-2039
> URL: https://issues.apache.org/jira/browse/PARQUET-2039
> Project: Parquet
> Issue Type: Bug
> Components: parquet-avro, parquet-mr
>Affects Versions: 1.11.0, 1.11.1
>Reporter: Bil Bingham
>Priority: Minor
> Attachments: PQMapTest.java
>
>
>
> using AvroReadSupport.setRequestedProjection in 1.11.1 reading a 1.10.0
> generated parquet file sets MAP fields to null (and vice versa
> 1.10.0 reader against a 1.11.1 generated file)
> - Not using a projected schema works, the map fields are converted correctly.
> In my case. Parquet file is generated by hive
> {code:java}
> CREATE TABLE parquetmaptest (
> a string,
> b MAP
> )
> STORED AS PARQUET
> tblproperties(
> "parquet.compression"="SNAPPY"
> );
> insert into parquetmaptest select "a",map("k1","v1","k2","v2");{code}
> Using parquet-avro 1.11.1 (and appropriate dependencies) result in field "b"
> being null.
> {code:java}
> data:null
> row:{"a": "a", "b": null}{code}
> Using parquet-avro 1.11.0 (and appropriate dependencies) result in field "b"
> being the right map value.
> {code:java}
> data:{k1=v1, k2=v2}
> row:{"a": "a", "b": {"k1": "v1", "k2": "v2"}}{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
